]> git.koha-community.org Git - koha.git/commit
Bug 19126: Fix Members.t with IndependentBranches set
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 16 Aug 2017 11:15:19 +0000 (13:15 +0200)
committerMason James <mtj@kohaaloha.com>
Tue, 24 Oct 2017 03:42:08 +0000 (16:42 +1300)
commitb09bf03d4e324e63eb8336df7d7a5a9414c0231b
treed99b9f942c4a292f303e9217f3ee0ef2ff31df56
parent4fc60a9afd8b00044e8a7d07b86186faea2bd6e3
Bug 19126: Fix Members.t with IndependentBranches set

If you enabled that pref, Members.t fails with:
t/db_dependent/Members.t .. 63/63 # Looks like you failed 15 tests of 63.

The first one is:
t/db_dependent/Members.t .. 32/63
   Failed test 'Staff patron not deleted from list'
   at t/db_dependent/Members.t line 304.

Bottle neck is GetBorrowersToExpunge. The results of that sub depend on the
state of this preference.
Trivially fixing it here by disabling the pref before the first call.

Test plan:
[1] Do not apply this patch yet. Enable IndependentBranches.
[2] Run Members.t and observe that it fails.
[3] Apply this patch. And run Members.t again. It should pass now.

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Mason James <mtj@kohaaloha.com>
t/db_dependent/Members.t