]> git.koha-community.org Git - koha.git/commit
Bug 25537: Page reload at branchtransfers.pl loses destination branch
authorKyle M Hall <kyle@bywatersolutions.com>
Thu, 21 May 2020 17:52:32 +0000 (13:52 -0400)
committerAleisha Amohia <aleishaamohia@hotmail.com>
Mon, 22 Jun 2020 04:16:53 +0000 (16:16 +1200)
commit9402b7c24cac53003f5ddb22b021d10016e4f2c1
tree52d4e65be1d76191c3c7af673f497c93024e097a
parent0bc4e414593b4d57576d2f9615ed3146b4acb6b3
Bug 25537: Page reload at branchtransfers.pl loses destination branch

At branchtransfers.pl, one selects a destination branch and scans in any
number of items to generate transfers to that branch. However, anything
that makes the page reload causes your branch selection to be lost,
reverting you back to whichever branch comes first alphabetically.

This is an invitation to error when one has a stack of books to
send all to the same branch. Could that error handling get moved
into a modal or something that won't reload the page?

Test Plan:
1) Place a hold on an item and set it to waiting
2) Initiate a branch transfer from branchtransfers.pl for any branch but
   the first in the pulldown branch selector
3) Choose to cancel the hold and transfer
4) Note the pulldown reverts to the first option
5) Apply this patch
6) Repeat steps 1-3
7) Note the pulldown retains your preveiously selected branch!

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 8ab8df3866352568509ed34f02a5566e750dee21)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit c8c394d1704acab20717ac3939ee1e5d45343e92)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt