From 64b31d4cc897c884c40c27c242f70f0885df55d8 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 17 Oct 2018 19:07:20 -0300 Subject: [PATCH] Bug 21597: Column 'notforloan' cannot be null Fix t/db_dependent/Circulation.t items.notforloan: `notforloan` tinyint(1) NOT NULL DEFAULT '0', t/db_dependent/Circulation.t .. 115/119 DBD::mysql::st execute failed: Column 'notforloan' cannot be null [for Statement "UPDATE `items` SET `notforloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0=undef, 1='1046'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. # No tests run! # Failed test 'No tests run for subtest "item-level_itypes = 0"' # at t/db_dependent/Circulation.t line 2356. # Looks like you failed 1 test of 2. # Failed test 'CanBookBeIssued | notforloan' # at t/db_dependent/Circulation.t line 2359. Can't locate object method "rethrow" via package "DBD::mysql::st execute failed: Column 'notforloan' cannot be null [for Statement "UPDATE `items` SET `notforloan` = ? WHERE ( `itemnumber` = ? )" with ParamValues: 0=undef, 1='1046'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit a40b8ebde788ac4082670e30b03fcbade2cc5544) Signed-off-by: Martin Renvoize --- t/db_dependent/Circulation.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index b8a0618860..bf7fde48c1 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -2328,7 +2328,7 @@ subtest 'CanBookBeIssued | notforloan' => sub { ); # for loan at item type and item level - $item->notforloan(undef)->store; + $item->notforloan(0)->store; $item->biblioitem->itemtype($itemtype->{itemtype})->store; ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef ); is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' ); -- 2.39.5