3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
20 use Test::More tests => 64;
25 use t::lib::TestBuilder;
28 use DateTime::Duration;
40 use Koha::Notice::Templates;
42 use Koha::Patron::Categories;
43 use Koha::CirculationRules;
46 require_ok('C4::Reserves');
50 my $database = Koha::Database->new();
51 my $schema = $database->schema();
52 $schema->storage->txn_begin();
53 my $dbh = C4::Context->dbh;
54 $dbh->do('DELETE FROM circulation_rules');
56 my $builder = t::lib::TestBuilder->new;
58 my $frameworkcode = q//;
61 t::lib::Mocks::mock_preference('ReservesNeedReturns', 1);
63 # Somewhat arbitrary field chosen for age restriction unit tests. Must be added to db before the framework is cached
64 $dbh->do("update marc_subfield_structure set kohafield='biblioitems.agerestriction' where tagfield='521' and tagsubfield='a' and frameworkcode=?", undef, $frameworkcode);
65 my $cache = Koha::Caches->get_instance;
66 $cache->clear_from_cache("MarcStructure-0-$frameworkcode");
67 $cache->clear_from_cache("MarcStructure-1-$frameworkcode");
68 $cache->clear_from_cache("default_value_for_mod_marc-");
69 $cache->clear_from_cache("MarcSubfieldStructure-$frameworkcode");
73 my $branch_1 = $builder->build({ source => 'Branch' })->{ branchcode };
74 my $branch_2 = $builder->build({ source => 'Branch' })->{ branchcode };
75 my $branch_3 = $builder->build({ source => 'Branch' })->{ branchcode };
77 my $category_1 = $builder->build({ source => 'Category' })->{ categorycode };
78 my $category_2 = $builder->build({ source => 'Category' })->{ categorycode };
80 my $itemtype = $builder->build(
81 { source => 'Itemtype', value => { notforloan => undef } } )->{itemtype};
83 t::lib::Mocks::mock_userenv({ branchcode => $branch_1 });
85 my $bibnum = $builder->build_sample_biblio({frameworkcode => $frameworkcode})->biblionumber;
87 # Create a helper item instance for testing
88 my $item = $builder->build_sample_item({ biblionumber => $bibnum, library => $branch_1, itype => $itemtype });
90 my $biblio_with_no_item = $builder->build({
95 # Modify item; setting barcode.
96 my $testbarcode = '97531';
97 $item->barcode($testbarcode)->store; # FIXME We should not hardcode a barcode! Also, what's the purpose of this?
101 firstname => 'my firstname',
102 surname => 'my surname',
103 categorycode => $category_1,
104 branchcode => $branch_1,
106 Koha::Patron::Categories->find($category_1)->set({ enrolmentfee => 0})->store;
107 my $borrowernumber = Koha::Patron->new(\%data)->store->borrowernumber;
108 my $patron = Koha::Patrons->find( $borrowernumber );
109 my $borrower = $patron->unblessed;
110 my $biblionumber = $bibnum;
111 my $barcode = $testbarcode;
113 my $branchcode = Koha::Libraries->search->next->branchcode;
117 branchcode => $branchcode,
118 borrowernumber => $borrowernumber,
119 biblionumber => $biblionumber,
124 my ($status, $reserve, $all_reserves) = CheckReserves($item->itemnumber, $barcode);
126 is($status, "Reserved", "CheckReserves Test 1");
128 ok(exists($reserve->{reserve_id}), 'CheckReserves() include reserve_id in its response');
130 ($status, $reserve, $all_reserves) = CheckReserves($item->itemnumber);
131 is($status, "Reserved", "CheckReserves Test 2");
133 ($status, $reserve, $all_reserves) = CheckReserves(undef, $barcode);
134 is($status, "Reserved", "CheckReserves Test 3");
136 my $ReservesControlBranch = C4::Context->preference('ReservesControlBranch');
137 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'ItemHomeLibrary' );
139 'ItemHomeLib' eq GetReservesControlBranch(
140 { homebranch => 'ItemHomeLib' },
141 { branchcode => 'PatronHomeLib' }
142 ), "GetReservesControlBranch returns item home branch when set to ItemHomeLibrary"
144 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'PatronLibrary' );
146 'PatronHomeLib' eq GetReservesControlBranch(
147 { homebranch => 'ItemHomeLib' },
148 { branchcode => 'PatronHomeLib' }
149 ), "GetReservesControlBranch returns patron home branch when set to PatronLibrary"
151 t::lib::Mocks::mock_preference( 'ReservesControlBranch', $ReservesControlBranch );
154 ### Regression test for bug 10272
157 $requesters{$branch_1} = Koha::Patron->new({
158 branchcode => $branch_1,
159 categorycode => $category_2,
160 surname => "borrower from $branch_1",
161 })->store->borrowernumber;
162 for my $i ( 2 .. 5 ) {
163 $requesters{"CPL$i"} = Koha::Patron->new({
164 branchcode => $branch_1,
165 categorycode => $category_2,
166 surname => "borrower $i from $branch_1",
167 })->store->borrowernumber;
169 $requesters{$branch_2} = Koha::Patron->new({
170 branchcode => $branch_2,
171 categorycode => $category_2,
172 surname => "borrower from $branch_2",
173 })->store->borrowernumber;
174 $requesters{$branch_3} = Koha::Patron->new({
175 branchcode => $branch_3,
176 categorycode => $category_2,
177 surname => "borrower from $branch_3",
178 })->store->borrowernumber;
180 # Configure rules so that $branch_1 allows only $branch_1 patrons
181 # to request its items, while $branch_2 will allow its items
182 # to fill holds from anywhere.
184 $dbh->do('DELETE FROM circulation_rules');
185 Koha::CirculationRules->set_rules(
188 categorycode => undef,
191 reservesallowed => 25,
192 holds_per_record => 1,
197 # CPL allows only its own patrons to request its items
198 Koha::CirculationRules->set_rules(
200 branchcode => $branch_1,
204 returnbranch => 'homebranch',
209 # ... while FPL allows anybody to request its items
210 Koha::CirculationRules->set_rules(
212 branchcode => $branch_2,
216 returnbranch => 'homebranch',
221 my $bibnum2 = $builder->build_sample_biblio({frameworkcode => $frameworkcode})->biblionumber;
223 my ($itemnum_cpl, $itemnum_fpl);
224 $itemnum_cpl = $builder->build_sample_item(
226 biblionumber => $bibnum2,
227 library => $branch_1,
228 barcode => 'bug10272_CPL',
232 $itemnum_fpl = $builder->build_sample_item(
234 biblionumber => $bibnum2,
235 library => $branch_2,
236 barcode => 'bug10272_FPL',
241 # Ensure that priorities are numbered correcly when a hold is moved to waiting
243 $dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum2));
246 branchcode => $branch_3,
247 borrowernumber => $requesters{$branch_3},
248 biblionumber => $bibnum2,
254 branchcode => $branch_2,
255 borrowernumber => $requesters{$branch_2},
256 biblionumber => $bibnum2,
262 branchcode => $branch_1,
263 borrowernumber => $requesters{$branch_1},
264 biblionumber => $bibnum2,
268 ModReserveAffect($itemnum_cpl, $requesters{$branch_3}, 0);
270 # Now it should have different priorities.
271 my $biblio = Koha::Biblios->find( $bibnum2 );
272 my $holds = $biblio->holds({}, { order_by => 'reserve_id' });;
273 is($holds->next->priority, 0, 'Item is correctly waiting');
274 is($holds->next->priority, 1, 'Item is correctly priority 1');
275 is($holds->next->priority, 2, 'Item is correctly priority 2');
277 my @reserves = Koha::Holds->search({ borrowernumber => $requesters{$branch_3} })->waiting();
278 is( @reserves, 1, 'GetWaiting got only the waiting reserve' );
279 is( $reserves[0]->borrowernumber(), $requesters{$branch_3}, 'GetWaiting got the reserve for the correct borrower' );
282 $dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum2));
285 branchcode => $branch_3,
286 borrowernumber => $requesters{$branch_3},
287 biblionumber => $bibnum2,
293 branchcode => $branch_2,
294 borrowernumber => $requesters{$branch_2},
295 biblionumber => $bibnum2,
302 branchcode => $branch_1,
303 borrowernumber => $requesters{$branch_1},
304 biblionumber => $bibnum2,
309 # Ensure that the item's home library controls hold policy lookup
310 t::lib::Mocks::mock_preference( 'ReservesControlBranch', 'ItemHomeLibrary' );
313 # Return the CPL item at FPL. The hold that should be triggered is
314 # the one placed by the CPL patron, as the other two patron's hold
315 # requests cannot be filled by that item per policy.
316 (undef, $messages, undef, undef) = AddReturn('bug10272_CPL', $branch_2);
317 is( $messages->{ResFound}->{borrowernumber},
318 $requesters{$branch_1},
319 'restrictive library\'s items only fill requests by own patrons (bug 10272)');
321 # Return the FPL item at FPL. The hold that should be triggered is
322 # the one placed by the RPL patron, as that patron is first in line
323 # and RPL imposes no restrictions on whose holds its items can fill.
325 # Ensure that the preference 'LocalHoldsPriority' is not set (Bug 15244):
326 t::lib::Mocks::mock_preference( 'LocalHoldsPriority', '' );
328 (undef, $messages, undef, undef) = AddReturn('bug10272_FPL', $branch_2);
329 is( $messages->{ResFound}->{borrowernumber},
330 $requesters{$branch_3},
331 'for generous library, its items fill first hold request in line (bug 10272)');
333 $biblio = Koha::Biblios->find( $biblionumber );
334 $holds = $biblio->holds;
335 is($holds->count, 1, "Only one reserves for this biblio");
336 $holds->next->reserve_id;
338 # Tests for bug 9761 (ConfirmFutureHolds): new CheckReserves lookahead parameter, and corresponding change in AddReturn
339 # Note that CheckReserve uses its lookahead parameter and does not check ConfirmFutureHolds pref (it should be passed if needed like AddReturn does)
340 # Test 9761a: Add a reserve without date, CheckReserve should return it
341 $dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum));
344 branchcode => $branch_1,
345 borrowernumber => $requesters{$branch_1},
346 biblionumber => $bibnum,
350 ($status)=CheckReserves($item->itemnumber,undef,undef);
351 is( $status, 'Reserved', 'CheckReserves returns reserve without lookahead');
352 ($status)=CheckReserves($item->itemnumber,undef,7);
353 is( $status, 'Reserved', 'CheckReserves also returns reserve with lookahead');
355 # Test 9761b: Add a reserve with future date, CheckReserve should not return it
356 $dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum));
357 t::lib::Mocks::mock_preference('AllowHoldDateInFuture', 1);
358 my $resdate= dt_from_string();
359 $resdate->add_duration(DateTime::Duration->new(days => 4));
360 $resdate=output_pref($resdate);
361 my $reserve_id = AddReserve(
363 branchcode => $branch_1,
364 borrowernumber => $requesters{$branch_1},
365 biblionumber => $bibnum,
367 reservation_date => $resdate,
370 ($status)=CheckReserves($item->itemnumber,undef,undef);
371 is( $status, '', 'CheckReserves returns no future reserve without lookahead');
373 # Test 9761c: Add a reserve with future date, CheckReserve should return it if lookahead is high enough
374 ($status)=CheckReserves($item->itemnumber,undef,3);
375 is( $status, '', 'CheckReserves returns no future reserve with insufficient lookahead');
376 ($status)=CheckReserves($item->itemnumber,undef,4);
377 is( $status, 'Reserved', 'CheckReserves returns future reserve with sufficient lookahead');
379 # Test 9761d: Check ResFound message of AddReturn for future hold
380 # Note that AddReturn is in Circulation.pm, but this test really pertains to reserves; AddReturn uses the ConfirmFutureHolds pref when calling CheckReserves
381 # In this test we do not need an issued item; it is just a 'checkin'
382 t::lib::Mocks::mock_preference('ConfirmFutureHolds', 0);
383 (my $doreturn, $messages)= AddReturn('97531',$branch_1);
384 is($messages->{ResFound}//'', '', 'AddReturn does not care about future reserve when ConfirmFutureHolds is off');
385 t::lib::Mocks::mock_preference('ConfirmFutureHolds', 3);
386 ($doreturn, $messages)= AddReturn('97531',$branch_1);
387 is(exists $messages->{ResFound}?1:0, 0, 'AddReturn ignores future reserve beyond ConfirmFutureHolds days');
388 t::lib::Mocks::mock_preference('ConfirmFutureHolds', 7);
389 ($doreturn, $messages)= AddReturn('97531',$branch_1);
390 is(exists $messages->{ResFound}?1:0, 1, 'AddReturn considers future reserve within ConfirmFutureHolds days');
392 # End of tests for bug 9761 (ConfirmFutureHolds)
394 # test marking a hold as captured
395 my $hold_notice_count = count_hold_print_messages();
396 ModReserveAffect($item->itemnumber, $requesters{$branch_1}, 0);
397 my $new_count = count_hold_print_messages();
398 is($new_count, $hold_notice_count + 1, 'patron notified when item set to waiting');
400 # test that duplicate notices aren't generated
401 ModReserveAffect($item->itemnumber, $requesters{$branch_1}, 0);
402 $new_count = count_hold_print_messages();
403 is($new_count, $hold_notice_count + 1, 'patron not notified a second time (bug 11445)');
405 # avoiding the not_same_branch error
406 t::lib::Mocks::mock_preference('IndependentBranches', 0);
407 $item = Koha::Items->find($item->itemnumber);
411 'item that is captured to fill a hold cannot be deleted',
414 my $letter = ReserveSlip( { branchcode => $branch_1, reserve_id => $reserve_id } );
415 ok(defined($letter), 'can successfully generate hold slip (bug 10949)');
417 # Tests for bug 9788: Does Koha::Item->current_holds return a future wait?
418 # 9788a: current_holds does not return future next available hold
419 $dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum));
420 t::lib::Mocks::mock_preference('ConfirmFutureHolds', 2);
421 t::lib::Mocks::mock_preference('AllowHoldDateInFuture', 1);
422 $resdate= dt_from_string();
423 $resdate->add_duration(DateTime::Duration->new(days => 2));
424 $resdate=output_pref($resdate);
427 branchcode => $branch_1,
428 borrowernumber => $requesters{$branch_1},
429 biblionumber => $bibnum,
431 reservation_date => $resdate,
435 $holds = $item->current_holds;
436 my $dtf = Koha::Database->new->schema->storage->datetime_parser;
437 my $future_holds = $holds->search({ reservedate => { '>' => $dtf->format_date( dt_from_string ) } } );
438 is( $future_holds->count, 0, 'current_holds does not return a future next available hold');
439 # 9788b: current_holds does not return future item level hold
440 $dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum));
443 branchcode => $branch_1,
444 borrowernumber => $requesters{$branch_1},
445 biblionumber => $bibnum,
447 reservation_date => $resdate,
448 itemnumber => $item->itemnumber,
451 $future_holds = $holds->search({ reservedate => { '>' => $dtf->format_date( dt_from_string ) } } );
452 is( $future_holds->count, 0, 'current_holds does not return a future item level hold' );
453 # 9788c: current_holds returns future wait (confirmed future hold)
454 ModReserveAffect( $item->itemnumber, $requesters{$branch_1} , 0); #confirm hold
455 $future_holds = $holds->search({ reservedate => { '>' => $dtf->format_date( dt_from_string ) } } );
456 is( $future_holds->count, 1, 'current_holds returns a future wait (confirmed future hold)' );
457 # End of tests for bug 9788
459 $dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum));
460 # Tests for CalculatePriority (bug 8918)
461 my $p = C4::Reserves::CalculatePriority($bibnum2);
462 is($p, 4, 'CalculatePriority should now return priority 4');
465 branchcode => $branch_1,
466 borrowernumber => $requesters{'CPL2'},
467 biblionumber => $bibnum2,
471 $p = C4::Reserves::CalculatePriority($bibnum2);
472 is($p, 5, 'CalculatePriority should now return priority 5');
473 #some tests on bibnum
474 $dbh->do("DELETE FROM reserves WHERE biblionumber=?",undef,($bibnum));
475 $p = C4::Reserves::CalculatePriority($bibnum);
476 is($p, 1, 'CalculatePriority should now return priority 1');
477 #add a new reserve and confirm it to waiting
480 branchcode => $branch_1,
481 borrowernumber => $requesters{$branch_1},
482 biblionumber => $bibnum,
484 itemnumber => $item->itemnumber,
487 $p = C4::Reserves::CalculatePriority($bibnum);
488 is($p, 2, 'CalculatePriority should now return priority 2');
489 ModReserveAffect( $item->itemnumber, $requesters{$branch_1} , 0);
490 $p = C4::Reserves::CalculatePriority($bibnum);
491 is($p, 1, 'CalculatePriority should now return priority 1');
492 #add another biblio hold, no resdate
495 branchcode => $branch_1,
496 borrowernumber => $requesters{'CPL2'},
497 biblionumber => $bibnum,
501 $p = C4::Reserves::CalculatePriority($bibnum);
502 is($p, 2, 'CalculatePriority should now return priority 2');
503 #add another future hold
504 t::lib::Mocks::mock_preference('AllowHoldDateInFuture', 1);
505 $resdate= dt_from_string();
506 $resdate->add_duration(DateTime::Duration->new(days => 1));
509 branchcode => $branch_1,
510 borrowernumber => $requesters{'CPL2'},
511 biblionumber => $bibnum,
513 reservation_date => output_pref($resdate),
516 $p = C4::Reserves::CalculatePriority($bibnum);
517 is($p, 2, 'CalculatePriority should now still return priority 2');
518 #calc priority with future resdate
519 $p = C4::Reserves::CalculatePriority($bibnum, $resdate);
520 is($p, 3, 'CalculatePriority should now return priority 3');
521 # End of tests for bug 8918
523 # Tests for cancel reserves by users from OPAC.
524 $dbh->do('DELETE FROM reserves', undef, ($bibnum));
527 branchcode => $branch_1,
528 borrowernumber => $requesters{$branch_1},
529 biblionumber => $bibnum,
533 my (undef, $canres, undef) = CheckReserves($item->itemnumber);
535 is( CanReserveBeCanceledFromOpac(), undef,
536 'CanReserveBeCanceledFromOpac should return undef if called without any parameter'
539 CanReserveBeCanceledFromOpac( $canres->{resserve_id} ),
541 'CanReserveBeCanceledFromOpac should return undef if called without the reserve_id'
544 CanReserveBeCanceledFromOpac( undef, $requesters{CPL} ),
546 'CanReserveBeCanceledFromOpac should return undef if called without borrowernumber'
549 my $cancancel = CanReserveBeCanceledFromOpac($canres->{reserve_id}, $requesters{$branch_1});
550 is($cancancel, 1, 'Can user cancel its own reserve');
552 $cancancel = CanReserveBeCanceledFromOpac($canres->{reserve_id}, $requesters{$branch_2});
553 is($cancancel, 0, 'Other user cant cancel reserve');
555 ModReserveAffect($item->itemnumber, $requesters{$branch_1}, 1);
556 $cancancel = CanReserveBeCanceledFromOpac($canres->{reserve_id}, $requesters{$branch_1});
557 is($cancancel, 0, 'Reserve in transfer status cant be canceled');
559 $dbh->do('DELETE FROM reserves', undef, ($bibnum));
562 branchcode => $branch_1,
563 borrowernumber => $requesters{$branch_1},
564 biblionumber => $bibnum,
568 (undef, $canres, undef) = CheckReserves($item->itemnumber);
570 ModReserveAffect($item->itemnumber, $requesters{$branch_1}, 0);
571 $cancancel = CanReserveBeCanceledFromOpac($canres->{reserve_id}, $requesters{$branch_1});
572 is($cancancel, 0, 'Reserve in waiting status cant be canceled');
574 # End of tests for bug 12876
577 ####### Testing Bug 13113 - Prevent juvenile/children from reserving ageRestricted material >>>
580 t::lib::Mocks::mock_preference( 'AgeRestrictionMarker', 'FSK|PEGI|Age|K' );
582 #Reserving an not-agerestricted Biblio by a Borrower with no dateofbirth is tested previously.
584 #Set the ageRestriction for the Biblio
585 my $record = GetMarcBiblio({ biblionumber => $bibnum });
586 my ( $ageres_tagid, $ageres_subfieldid ) = GetMarcFromKohaField( "biblioitems.agerestriction" );
587 $record->append_fields( MARC::Field->new($ageres_tagid, '', '', $ageres_subfieldid => 'PEGI 16') );
588 C4::Biblio::ModBiblio( $record, $bibnum, $frameworkcode );
590 is( C4::Reserves::CanBookBeReserved($borrowernumber, $biblionumber)->{status} , 'OK', "Reserving an ageRestricted Biblio without a borrower dateofbirth succeeds" );
592 #Set the dateofbirth for the Borrower making them "too young".
593 $borrower->{dateofbirth} = DateTime->now->add( years => -15 );
594 Koha::Patrons->find( $borrowernumber )->set({ dateofbirth => $borrower->{dateofbirth} })->store;
596 is( C4::Reserves::CanBookBeReserved($borrowernumber, $biblionumber)->{status} , 'ageRestricted', "Reserving a 'PEGI 16' Biblio by a 15 year old borrower fails");
598 #Set the dateofbirth for the Borrower making them "too old".
599 $borrower->{dateofbirth} = DateTime->now->add( years => -30 );
600 Koha::Patrons->find( $borrowernumber )->set({ dateofbirth => $borrower->{dateofbirth} })->store;
602 is( C4::Reserves::CanBookBeReserved($borrowernumber, $biblionumber)->{status} , 'OK', "Reserving a 'PEGI 16' Biblio by a 30 year old borrower succeeds");
604 is( C4::Reserves::CanBookBeReserved($borrowernumber, $biblio_with_no_item->{biblionumber})->{status} , '', "Biblio with no item. Status is empty");
606 ####### EO Bug 13113 <<<
609 ok( C4::Reserves::IsAvailableForItemLevelRequest($item, $patron), "Reserving a book on item level" );
611 my $pickup_branch = $builder->build({ source => 'Branch' })->{ branchcode };
612 t::lib::Mocks::mock_preference( 'UseBranchTransferLimits', '1' );
613 t::lib::Mocks::mock_preference( 'BranchTransferLimitsType', 'itemtype' );
614 my $limit = Koha::Item::Transfer::Limit->new(
616 toBranch => $pickup_branch,
617 fromBranch => $item->holdingbranch,
618 itemtype => $item->effective_itemtype,
621 is( C4::Reserves::IsAvailableForItemLevelRequest($item, $patron, $pickup_branch), 0, "Item level request not available due to transfer limit" );
622 t::lib::Mocks::mock_preference( 'UseBranchTransferLimits', '0' );
624 my $categorycode = $borrower->{categorycode};
625 my $holdingbranch = $item->{holdingbranch};
626 Koha::CirculationRules->set_rules(
628 categorycode => $categorycode,
629 itemtype => $item->effective_itemtype,
630 branchcode => $holdingbranch,
637 # tests for MoveReserve in relation to ConfirmFutureHolds (BZ 14526)
638 # hold from A pos 1, today, no fut holds: MoveReserve should fill it
639 $dbh->do('DELETE FROM reserves', undef, ($bibnum));
640 t::lib::Mocks::mock_preference('ConfirmFutureHolds', 0);
641 t::lib::Mocks::mock_preference('AllowHoldDateInFuture', 1);
644 branchcode => $branch_1,
645 borrowernumber => $borrowernumber,
646 biblionumber => $bibnum,
650 MoveReserve( $item->itemnumber, $borrowernumber );
651 ($status)=CheckReserves( $item->itemnumber );
652 is( $status, '', 'MoveReserve filled hold');
653 # hold from A waiting, today, no fut holds: MoveReserve should fill it
656 branchcode => $branch_1,
657 borrowernumber => $borrowernumber,
658 biblionumber => $bibnum,
663 MoveReserve( $item->itemnumber, $borrowernumber );
664 ($status)=CheckReserves( $item->itemnumber );
665 is( $status, '', 'MoveReserve filled waiting hold');
666 # hold from A pos 1, tomorrow, no fut holds: not filled
667 $resdate= dt_from_string();
668 $resdate->add_duration(DateTime::Duration->new(days => 1));
669 $resdate=output_pref($resdate);
672 branchcode => $branch_1,
673 borrowernumber => $borrowernumber,
674 biblionumber => $bibnum,
676 reservation_date => $resdate,
679 MoveReserve( $item->itemnumber, $borrowernumber );
680 ($status)=CheckReserves( $item->itemnumber, undef, 1 );
681 is( $status, 'Reserved', 'MoveReserve did not fill future hold');
682 $dbh->do('DELETE FROM reserves', undef, ($bibnum));
683 # hold from A pos 1, tomorrow, fut holds=2: MoveReserve should fill it
684 t::lib::Mocks::mock_preference('ConfirmFutureHolds', 2);
687 branchcode => $branch_1,
688 borrowernumber => $borrowernumber,
689 biblionumber => $bibnum,
691 reservation_date => $resdate,
694 MoveReserve( $item->itemnumber, $borrowernumber );
695 ($status)=CheckReserves( $item->itemnumber, undef, 2 );
696 is( $status, '', 'MoveReserve filled future hold now');
697 # hold from A waiting, tomorrow, fut holds=2: MoveReserve should fill it
700 branchcode => $branch_1,
701 borrowernumber => $borrowernumber,
702 biblionumber => $bibnum,
704 reservation_date => $resdate,
707 MoveReserve( $item->itemnumber, $borrowernumber );
708 ($status)=CheckReserves( $item->itemnumber, undef, 2 );
709 is( $status, '', 'MoveReserve filled future waiting hold now');
710 # hold from A pos 1, today+3, fut holds=2: MoveReserve should not fill it
711 $resdate= dt_from_string();
712 $resdate->add_duration(DateTime::Duration->new(days => 3));
713 $resdate=output_pref($resdate);
716 branchcode => $branch_1,
717 borrowernumber => $borrowernumber,
718 biblionumber => $bibnum,
720 reservation_date => $resdate,
723 MoveReserve( $item->itemnumber, $borrowernumber );
724 ($status)=CheckReserves( $item->itemnumber, undef, 3 );
725 is( $status, 'Reserved', 'MoveReserve did not fill future hold of 3 days');
726 $dbh->do('DELETE FROM reserves', undef, ($bibnum));
728 $cache->clear_from_cache("MarcStructure-0-$frameworkcode");
729 $cache->clear_from_cache("MarcStructure-1-$frameworkcode");
730 $cache->clear_from_cache("default_value_for_mod_marc-");
731 $cache->clear_from_cache("MarcSubfieldStructure-$frameworkcode");
733 subtest '_koha_notify_reserve() tests' => sub {
737 my $wants_hold_and_email = {
743 letter_code => 'HOLD'
746 my $mp = Test::MockModule->new( 'C4::Members::Messaging' );
748 $mp->mock("GetMessagingPreferences",$wants_hold_and_email);
750 $dbh->do('DELETE FROM letter');
752 my $email_hold_notice = $builder->build({
755 message_transport_type => 'email',
758 module => 'reserves',
763 my $sms_hold_notice = $builder->build({
766 message_transport_type => 'sms',
769 module => 'reserves',
774 my $hold_borrower = $builder->build({
775 source => 'Borrower',
777 smsalertnumber=>'5555555555',
780 })->{borrowernumber};
782 C4::Reserves::AddReserve(
784 branchcode => $item->homebranch,
785 borrowernumber => $hold_borrower,
786 biblionumber => $item->biblionumber,
790 ModReserveAffect($item->itemnumber, $hold_borrower, 0);
791 my $sms_message_address = $schema->resultset('MessageQueue')->search({
792 letter_code => 'HOLD',
793 message_transport_type => 'sms',
794 borrowernumber => $hold_borrower,
795 })->next()->to_address();
796 is($sms_message_address, undef ,"We should not populate the sms message with the sms number, sending will do so");
798 my $email_message_address = $schema->resultset('MessageQueue')->search({
799 letter_code => 'HOLD',
800 message_transport_type => 'email',
801 borrowernumber => $hold_borrower,
802 })->next()->to_address();
803 is($email_message_address, undef ,"We should not populate the hold message with the email address, sending will do so");
807 subtest 'ReservesNeedReturns' => sub {
810 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
812 homebranch => $library->branchcode,
813 holdingbranch => $library->branchcode,
815 my $item = $builder->build_sample_item($item_info);
816 my $patron = $builder->build_object(
818 class => 'Koha::Patrons',
819 value => { branchcode => $library->branchcode, }
822 my $patron_2 = $builder->build_object(
824 class => 'Koha::Patrons',
825 value => { branchcode => $library->branchcode, }
831 t::lib::Mocks::mock_preference('ReservesNeedReturns', 1); # Test with feature disabled
832 my $hold = place_item_hold( $patron, $item, $library, $priority );
833 is( $hold->priority, $priority, 'If ReservesNeedReturns is 1, priority must not have been set to changed' );
834 is( $hold->found, undef, 'If ReservesNeedReturns is 1, found must not have been set waiting' );
837 t::lib::Mocks::mock_preference('ReservesNeedReturns', 0); # '0' means 'Automatically mark a hold as found and waiting'
838 $hold = place_item_hold( $patron, $item, $library, $priority );
839 is( $hold->priority, 0, 'If ReservesNeedReturns is 0 and no other status, priority must have been set to 0' );
840 is( $hold->found, 'W', 'If ReservesNeedReturns is 0 and no other status, found must have been set waiting' );
843 $item->onloan('2010-01-01')->store;
844 $hold = place_item_hold( $patron, $item, $library, $priority );
845 is( $hold->priority, 1, 'If ReservesNeedReturns is 0 but item onloan priority must be set to 1' );
848 t::lib::Mocks::mock_preference('AllowHoldsOnDamagedItems', 0); # '0' means damaged holds not allowed
849 $item->onloan(undef)->damaged(1)->store;
850 $hold = place_item_hold( $patron, $item, $library, $priority );
851 is( $hold->priority, 1, 'If ReservesNeedReturns is 0 but item damaged and not allowed holds on damaged items priority must be set to 1' );
853 t::lib::Mocks::mock_preference('AllowHoldsOnDamagedItems', 1); # '0' means damaged holds not allowed
854 $hold = place_item_hold( $patron, $item, $library, $priority );
855 is( $hold->priority, 0, 'If ReservesNeedReturns is 0 and damaged holds allowed, priority must have been set to 0' );
856 is( $hold->found, 'W', 'If ReservesNeedReturns is 0 and damaged holds allowed, found must have been set waiting' );
859 my $hold_1 = place_item_hold( $patron, $item, $library, $priority );
860 is( $hold_1->found, 'W', 'First hold on item is set to waiting with ReservesNeedReturns set to 0' );
861 is( $hold_1->priority, 0, 'First hold on item is set to waiting with ReservesNeedReturns set to 0' );
862 $hold = place_item_hold( $patron_2, $item, $library, $priority );
863 is( $hold->priority, 1, 'If ReservesNeedReturns is 0 but item already on hold priority must be set to 1' );
867 my $transfer = $builder->build_object({
868 class => "Koha::Item::Transfers",
870 itemnumber => $item->itemnumber,
871 datearrived => undef,
874 $item->damaged(0)->store;
875 $hold = place_item_hold( $patron, $item, $library, $priority );
876 is( $hold->found, undef, 'If ReservesNeedReturns is 0 but item in transit the hold must not be set to waiting' );
877 is( $hold->priority, 1, 'If ReservesNeedReturns is 0 but item in transit the hold must not be set to waiting' );
881 $hold = place_item_hold( $patron, $item, $library, $priority );
882 is( $hold->priority, 0, 'If ReservesNeedReturns is 0 and no other status, priority must have been set to 0' );
883 is( $hold->found, 'W', 'If ReservesNeedReturns is 0 and no other status, found must have been set waiting' );
884 $hold_1 = place_item_hold( $patron, $item, $library, $priority );
885 is( $hold_1->priority, 1, 'If ReservesNeedReturns is 0 but item has a hold priority is 1' );
886 $hold_1->suspend(1)->store; # We suspend the hold
887 $hold->delete; # Delete the waiting hold
888 $hold = place_item_hold( $patron, $item, $library, $priority );
889 is( $hold->priority, 0, 'If ReservesNeedReturns is 0 and other hold(s) suspended, priority must have been set to 0' );
890 is( $hold->found, 'W', 'If ReservesNeedReturns is 0 and other hold(s) suspended, found must have been set waiting' );
895 t::lib::Mocks::mock_preference('ReservesNeedReturns', 1); # Don't affect other tests
898 subtest 'ChargeReserveFee tests' => sub {
902 my $library = $builder->build_object({ class => 'Koha::Libraries' });
903 my $patron = $builder->build_object({ class => 'Koha::Patrons' });
906 my $title = 'A title';
908 my $context = Test::MockModule->new('C4::Context');
909 $context->mock( userenv => { branch => $library->id } );
911 my $line = C4::Reserves::ChargeReserveFee( $patron->id, $fee, $title );
913 is( ref($line), 'Koha::Account::Line' , 'Returns a Koha::Account::Line object');
914 ok( $line->is_debit, 'Generates a debit line' );
915 is( $line->debit_type_code, 'RESERVE' , 'generates RESERVE debit_type');
916 is( $line->borrowernumber, $patron->id , 'generated line belongs to the passed patron');
917 is( $line->amount, $fee , 'amount set correctly');
918 is( $line->amountoutstanding, $fee , 'amountoutstanding set correctly');
919 is( $line->description, "$title" , 'description is title of reserved item');
920 is( $line->branchcode, $library->id , "Library id is picked from userenv and stored correctly" );
923 subtest 'reserves.item_level_hold' => sub {
926 my $item = $builder->build_sample_item;
927 my $patron = $builder->build_object(
929 class => 'Koha::Patrons',
930 value => { branchcode => $item->homebranch }
934 subtest 'item level hold' => sub {
936 my $reserve_id = AddReserve(
938 branchcode => $item->homebranch,
939 borrowernumber => $patron->borrowernumber,
940 biblionumber => $item->biblionumber,
942 itemnumber => $item->itemnumber,
946 my $hold = Koha::Holds->find($reserve_id);
947 is( $hold->item_level_hold, 1, 'item_level_hold should be set when AddReserve is called with a specific item' );
950 ModReserveAffect( $item->itemnumber, $patron->borrowernumber, 1 );
952 # Revert the waiting status
953 C4::Reserves::RevertWaitingStatus(
954 { itemnumber => $item->itemnumber } );
956 $hold = Koha::Holds->find($reserve_id);
958 is( $hold->itemnumber, $item->itemnumber, 'Itemnumber should not be removed when the waiting status is revert' );
960 $hold->delete; # cleanup
963 subtest 'biblio level hold' => sub {
965 my $reserve_id = AddReserve(
967 branchcode => $item->homebranch,
968 borrowernumber => $patron->borrowernumber,
969 biblionumber => $item->biblionumber,
974 my $hold = Koha::Holds->find($reserve_id);
975 is( $hold->item_level_hold, 0, 'item_level_hold should not be set when AddReserve is called without a specific item' );
978 ModReserveAffect( $item->itemnumber, $patron->borrowernumber, 1 );
980 $hold = Koha::Holds->find($reserve_id);
981 is( $hold->itemnumber, $item->itemnumber, 'Itemnumber should be set on hold confirmation' );
983 # Revert the waiting status
984 C4::Reserves::RevertWaitingStatus( { itemnumber => $item->itemnumber } );
986 $hold = Koha::Holds->find($reserve_id);
987 is( $hold->itemnumber, undef, 'Itemnumber should be removed when the waiting status is revert' );
994 subtest 'MoveReserve additional test' => sub {
998 # Create the items and patrons we need
999 my $biblio = $builder->build_sample_biblio();
1000 my $itype = $builder->build_object({ class => "Koha::ItemTypes", value => { notforloan => 0 } });
1001 my $item_1 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber,notforloan => 0, itype => $itype->itemtype });
1002 my $item_2 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber, notforloan => 0, itype => $itype->itemtype });
1003 my $patron_1 = $builder->build_object({ class => "Koha::Patrons" });
1004 my $patron_2 = $builder->build_object({ class => "Koha::Patrons" });
1006 # Place a hold on the title for both patrons
1007 my $reserve_1 = AddReserve(
1009 branchcode => $item_1->homebranch,
1010 borrowernumber => $patron_1->borrowernumber,
1011 biblionumber => $biblio->biblionumber,
1013 itemnumber => $item_1->itemnumber,
1016 my $reserve_2 = AddReserve(
1018 branchcode => $item_2->homebranch,
1019 borrowernumber => $patron_2->borrowernumber,
1020 biblionumber => $biblio->biblionumber,
1022 itemnumber => $item_1->itemnumber,
1025 is($patron_1->holds->next()->reserve_id, $reserve_1, "The 1st patron has a hold");
1026 is($patron_2->holds->next()->reserve_id, $reserve_2, "The 2nd patron has a hold");
1028 # Fake the holds queue
1029 $dbh->do(q{INSERT INTO hold_fill_targets VALUES (?, ?, ?, ?, ?,?)},undef,($patron_1->borrowernumber,$biblio->biblionumber,$item_1->itemnumber,$item_1->homebranch,0,$reserve_1));
1031 # The 2nd hold should be filed even if the item is preselected for the first hold
1032 MoveReserve($item_1->itemnumber,$patron_2->borrowernumber);
1033 is($patron_2->holds->count, 0, "The 2nd patrons no longer has a hold");
1034 is($patron_2->old_holds->next()->reserve_id, $reserve_2, "The 2nd patrons hold was filled and moved to old holds");
1038 subtest 'RevertWaitingStatus' => sub {
1042 # Create the items and patrons we need
1043 my $biblio = $builder->build_sample_biblio();
1044 my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1045 my $itype = $builder->build_object(
1046 { class => "Koha::ItemTypes", value => { notforloan => 0 } } );
1047 my $item_1 = $builder->build_sample_item(
1049 biblionumber => $biblio->biblionumber,
1050 itype => $itype->itemtype,
1051 library => $library->branchcode
1054 my $patron_1 = $builder->build_object( { class => "Koha::Patrons" } );
1055 my $patron_2 = $builder->build_object( { class => "Koha::Patrons" } );
1056 my $patron_3 = $builder->build_object( { class => "Koha::Patrons" } );
1057 my $patron_4 = $builder->build_object( { class => "Koha::Patrons" } );
1059 # Place a hold on the title for both patrons
1061 my $hold_1 = place_item_hold( $patron_1, $item_1, $library, $priority );
1062 my $hold_2 = place_item_hold( $patron_2, $item_1, $library, $priority );
1063 my $hold_3 = place_item_hold( $patron_3, $item_1, $library, $priority );
1064 my $hold_4 = place_item_hold( $patron_4, $item_1, $library, $priority );
1066 $hold_1->set_waiting;
1067 AddIssue( $patron_3->unblessed, $item_1->barcode, undef, 'revert' );
1069 my $holds = $biblio->holds;
1070 is( $holds->count, 3, 'One hold has been deleted' );
1073 $holds->next->priority, $holds->next->priority,
1074 $holds->next->priority
1077 'priorities have been reordered'
1081 subtest 'CheckReserves additional test' => sub {
1085 my $item = $builder->build_sample_item;
1086 my $reserve1 = $builder->build_object(
1088 class => "Koha::Holds",
1092 itemnumber => undef,
1093 biblionumber => $item->biblionumber,
1094 waitingdate => undef,
1095 cancellationdate => undef,
1096 item_level_hold => 0,
1097 lowestPriority => 0,
1098 expirationdate => undef,
1099 suspend_until => undef,
1105 my $reserve2 = $builder->build_object(
1107 class => "Koha::Holds",
1111 biblionumber => $item->biblionumber,
1112 borrowernumber => $reserve1->borrowernumber,
1113 itemnumber => undef,
1114 waitingdate => undef,
1115 cancellationdate => undef,
1116 item_level_hold => 0,
1117 lowestPriority => 0,
1118 expirationdate => undef,
1119 suspend_until => undef,
1126 my $tmp_holdsqueue = $builder->build(
1128 source => 'TmpHoldsqueue',
1130 borrowernumber => $reserve1->borrowernumber,
1131 biblionumber => $reserve1->biblionumber,
1135 my $fill_target = $builder->build(
1137 source => 'HoldFillTarget',
1139 borrowernumber => $reserve1->borrowernumber,
1140 biblionumber => $reserve1->biblionumber,
1141 itemnumber => $item->itemnumber,
1142 item_level_request => 0,
1147 ModReserveAffect( $item->itemnumber, $reserve1->borrowernumber, 1,
1148 $reserve1->reserve_id );
1149 my ( $status, $matched_reserve, $possible_reserves ) =
1150 CheckReserves( $item->itemnumber );
1152 is( $status, 'Reserved', "We found a reserve" );
1153 is( $matched_reserve->{reserve_id},
1154 $reserve1->reserve_id, "We got the Transit reserve" );
1155 is( scalar @$possible_reserves, 2, 'We do get both reserves' );
1159 sub count_hold_print_messages {
1160 my $message_count = $dbh->selectall_arrayref(q{
1163 WHERE letter_code = 'HOLD'
1164 AND message_transport_type = 'print'
1166 return $message_count->[0]->[0];
1169 sub place_item_hold {
1170 my ($patron,$item,$library,$priority) = @_;
1172 my $hold_id = C4::Reserves::AddReserve(
1174 branchcode => $library->branchcode,
1175 borrowernumber => $patron->borrowernumber,
1176 biblionumber => $item->biblionumber,
1177 priority => $priority,
1178 title => "title for fee",
1179 itemnumber => $item->itemnumber,
1183 my $hold = Koha::Holds->find($hold_id);
1187 # we reached the finish
1188 $schema->storage->txn_rollback();