]> git.koha-community.org Git - koha.git/commit
Bug 17785: Fix OAI-PMH's XSLT-generated URLs under Plack
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tue, 20 Dec 2016 15:11:36 +0000 (16:11 +0100)
committerKatrin Fischer <katrin.fischer.83@web.de>
Wed, 4 Jan 2017 06:43:26 +0000 (06:43 +0000)
commit269bbee289e7faf1d30b133c4ea413a51229ff3e
tree2631f66664159080361473ef8ccb5f4d479f5562
parentaae8f936df2e6e7a76da55151daa79138da3a277
Bug 17785: Fix OAI-PMH's XSLT-generated URLs under Plack

Look at e.g. the URL for Show More at the end of the output of Records or
Identifiers. If you use Plack, you will see that it refers to
yourserver:/opac/oai.pl, which is not correct.

This is caused by using CGI's self_url in combination with script alias,
mounting point, etc. Note that we cannot solve this problem in the code of
Koha only. Since HTTP::OAI modules also call self_url, we still end up
with some wrong url's.

Instead of a larger architectural operation on Apache and Plack config files,
this patch adjusts the final xslt transformation on the OAI response.
It hardcodes the correct path only once, in a xslt variable. And replaces
all oai:OAI-PMH/oai:request/text() calls, containing wrong URLs, by this
variable.

Test plan:
Run oai.pl. Try the various verbs.
Verify that the URLs point to /cgi-bin/koha/oai.pl.

Edit: changed commit subject

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Works as expected. Good workaround until a definitive solution is implemented.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 1b492938e4eee4d1babe26417cfbf69cede2b844)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
koha-tmpl/opac-tmpl/xslt/OAI.xslt