Bug 26367: Prevent warn about undefined values when record level hold has an itemtype
authorNick Clemens <nick@bywatersolutions.com>
Thu, 3 Sep 2020 12:15:57 +0000 (12:15 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 8 Jan 2021 06:48:41 +0000 (07:48 +0100)
commit48235e4d616a8bc9a330733486799270409331a3
treecf5af229bb1f78bea13b7f5b987186c71325e9dd
parent120179cc87fc8242448cb7ef370f04dea759fb80
Bug 26367: Prevent warn about undefined values when record level hold has an itemtype

To test:
 1 - set AllowHoldItemTypeSelection to 'Allow'
 2 - Find a patron from Library A
 3 - Find a record with an item from Library A
 4 - Place a title level hold with itemtype specified for a delivery at Library A for patron and record above
 5 - perl misc/cronjobs/holds/build_holds_queue.pl
 6 - There are warns:
 Use of uninitialized value in hash element at /kohadevbox/koha/C4/HoldsQueue.pm line 523.
 Use of uninitialized value in string eq at /kohadevbox/koha/C4/HoldsQueue.pm line 523
 7 - Apply this patch
 8 - perl misc/cronjobs/holds/build_holds_queue.pl
 9 - No more warns!
10 - prove -v t/db_dependent/HoldsQueue.t
11 - All tests pass!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit d2e2a3975fb66d8c2e2766ecbe014fb71952e6d0)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/HoldsQueue.pm