]> git.koha-community.org Git - koha.git/commit
Bug 23233: AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP...
authorKyle M Hall <kyle@bywatersolutions.com>
Fri, 28 Jun 2019 18:07:39 +0000 (14:07 -0400)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 16 Dec 2019 11:08:52 +0000 (11:08 +0000)
commit50bb8e96f10638278dcec9a8eebf52c7f74209f2
treefdd482b74baa1cd0f37e71a116e22e9af984c6d6
parent044b6eadd591f6f6c02496ed3d47403cc2d3f7f5
Bug 23233: AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only

The system preference AllowItemsOnHoldCheckout only affects SIP based checkouts. I believe we should rename it AllowItemsOnHoldCheckoutSIP so it matches AllowItemsOnHoldCheckoutSCO. We should also update the description as well.

As far as I know AllowItemsOnHoldCheckout has never affected anything except SIP traffic. That does not preclude the addition of another AllowItemsOnHoldCheckout syspref that would affect the staff interface, but that would be an enhancement and is outside the scope of this bug report.

Test Plan:
1) Test AllowItemsOnHoldCheckout via SIP
2) Apply this patch
3) Test AllowItemsOnHoldCheckoutSIP via SIP
4) Note there is no difference!
5) Note the syspref description has been update to mention SIP

Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
C4/Items.pm
C4/SIP/ILS/Transaction/Checkout.pm
C4/UsageStats.pm
Koha/Item.pm
installer/data/mysql/atomicupdate/bug_23233.perl [new file with mode: 0644]
installer/data/mysql/sysprefs.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref