]> git.koha-community.org Git - koha.git/commit
Bug 14138: Patroncard: Warn user if PDF creation fails
authorMarc Véron <veron@veron.ch>
Tue, 5 Jul 2016 17:23:59 +0000 (19:23 +0200)
committerFrédéric Demians <f.demians@tamil.fr>
Mon, 1 Aug 2016 11:31:21 +0000 (13:31 +0200)
commit5de1b336da5d0acdd589cacbf11abc9f8b35692e
tree9b58954faa218ffb62815614211d25884f5c4673
parenta112833fe15379d2c6d6e9cbcd2a728fc22ac720
Bug 14138: Patroncard: Warn user if PDF creation fails

Change patroncards/create-pdf.pl to redirect with an error message
instead of writing an invalid pdf that does not open in pdf viewer.

To test:
- Apply patch

- Test that pdf creator behaves as before (with valid batches and
  patron lists)

- While testing, copy pdf link address from window with title 'Click
  the following link(s) to download...'

- Open another staff client browser tab

- Paste link to browser address field, change batch id rsp. patron
  list id to an invalid value and submit

- The window should redirect to cgi-bin/koha/patroncards/create-pdf.pl
  and display an error message

- Bonus test 1: Create an empty patron list and test patron card
  creation. You should get an error message as appropriate.

- Bonus test 2: Use a link with params like the following:
  ...create-pdf.pl?borrower_number=61&template_id=2&layout_id=1&start_card=1
  Verify that you can create a pdf with a valid borrower_number and that
  you get the error message with an invalid borrower number

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit b51f2baa7c1035657594f90d17c7c9eeedf4ea84)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt
patroncards/create-pdf.pl