]> git.koha-community.org Git - koha.git/commit
Bug 27654: Sort module.keys hash when render columns_settings.tt
authorPetro Vashchuk <stalkernoid@gmail.com>
Mon, 8 Feb 2021 14:04:48 +0000 (16:04 +0200)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Mon, 22 Feb 2021 22:53:49 +0000 (22:53 +0000)
commit5fb93c86f343bd1b02cdb05aba5c323dead6008d
tree7ae48e92150c4e51ffbe3e41b5be51e413605d62
parent1039d11869dae9d0753ae897486cb81e9d5d26f2
Bug 27654: Sort module.keys hash when render columns_settings.tt

On the "Administration -> Table settings" page, the order of
"tables related to pages" sections is different with each page refresh.
Cause of that is that Perl gives random order for hash keys where
those elements are stored on template render. To avoid that we
add a "sort" method where getting keys similarly how it was done
previously to display tables always in the same order.

To reproduce:
    1) Head over to /cgi-bin/koha/admin/columns_settings.pl
    2) Open any collapsed module settings, for example
"Acquisition tables". Check the order of pages.
    3) Reload the page. Check the order of the same elements again.
They always come in random order, it's easily distinguishable.
    4) Apply the patch.
    5) Repeat steps 1-3 again and ensure that the order of pages
stays the same no matter how many times you reload the page.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit f58c271b4255e85b3b6ddf90a9e802249954cc13)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit fa597b5209a1d756c3a053fa2c93737172809c4a)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt