Bug 20696: Fix a few ugly "eq undef" comparisons in Search.pm
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 2 May 2018 14:13:20 +0000 (16:13 +0200)
committerNick Clemens <nick@bywatersolutions.com>
Tue, 29 May 2018 14:12:52 +0000 (14:12 +0000)
commit69f74104d5e705b95d8207e61fedfbd71ca2e673
treeb32cb41f0b8f2aa44ca859a011ee73d1b5b642f4
parentda6fde55dd2f4e11f73490d6502483748666d1e7
Bug 20696: Fix a few ugly "eq undef" comparisons in Search.pm

Comparisons like $a eq undef should normally raise a warning like:
    Use of uninitialized value in string eq at ...
But unfortunately we still suppress warnings here and there.

Test plan:
[1] Just read this patch and confirm the small changes.
[2] Git grep on "eq undef" and do not find other occurrences.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Passes test plan and QA tools. Searching works correctly.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/Search.pm