Bug 26738: [20.05.x] (bug 24819 follow-up) Fix manager selection
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 2 Nov 2020 14:01:32 +0000 (15:01 +0100)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 17 Nov 2020 17:46:48 +0000 (17:46 +0000)
commit7045235a8d039ccbe5ba1c89f2b616c8c9ba3738
tree1ef5c587efeb5173e104bd463a55932b74888d8d
parentac5a9f2694cc6c1ac2929268024eff520602d20d
Bug 26738: [20.05.x] (bug 24819 follow-up) Fix manager selection

Bug 23590 added a new feature to select the manager of a suggestion.
One month later bug 24819 added the ability to pick the suggester.

This second patchset broke the manager selection.

This patch simplifies the way the suggester is selected, using the
generic way and mimicking what is done for the manager.

Test plan:
- create a new purchase suggestion from within acquisitions (suggestion.pl?op=add)
- click "select manager," search for user, click Select
- see that the user you just selected shows under "Created by,"
- see that "Managed by" still says "You"
- modify the suggester
- save your suggestion
=> Everything is saved correctly

QA will test the permission alert:
Edit suggestion.tt and remove "&permissions=suggestions.suggestions_manage"
Edit the suggestion, select a manager, pick a patron in the list who
does not have sufficient permissions, save
=> you get the alert

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Bug 26738: (QA follow-up) Add missing filter

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/tables/suggester_search.tt [deleted file]
koha-tmpl/intranet-tmpl/prog/js/suggestions.js [deleted file]
suggestion/add_user_search.pl
suggestion/suggester_search.pl [deleted file]
suggestion/suggestion.pl