Bug 17592: Remove itemtype-related maxsuspensiondays.t warnings
authorTomas Cohen Arazi <tomascohen@theke.io>
Tue, 8 Nov 2016 19:28:07 +0000 (16:28 -0300)
committerMason James <mtj@kohaaloha.com>
Mon, 12 Dec 2016 01:54:09 +0000 (14:54 +1300)
commit78ae5d237eb1913e19e19030da7557d1ff8ef823
treefe5a553e08abe8f00e03f7275c5b0b5cc8eff73c
parent4d9dc278fddcccb0d64dacd8665c9a1d061f9b08
Bug 17592: Remove itemtype-related maxsuspensiondays.t warnings

This patch makes t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t create
good sample data for its tests. It does so by creating a random
itemtype.

To test:
- Run
  $ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t
=> FAIL: lots of warnings about "item-level_itypes set but no itemtype
set for item"
- Apply the patch
- Run:
  $ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t
=> SUCCESS: Tests are green, and no warnings.
- Sign off :-D

Sponsored-by: ByWater Solutions
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Mason James <mtj@kohaaloha.com>
t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t