]> git.koha-community.org Git - koha.git/commit
Bug 1861: There is a problem introduced with an earlier patch, on this patchset
authorChris Cormack <chrisc@catalyst.net.nz>
Tue, 30 Dec 2014 02:37:39 +0000 (15:37 +1300)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Wed, 31 Dec 2014 15:13:54 +0000 (12:13 -0300)
commita847067d7ef5350f9572c92407971baa7af76216
treeaae42c07c3ee2ef930835ab35674396d4e7bb2d6
parentee02bcb14f30a897c1e3eeac3933ba83dacf3abe
Bug 1861: There is a problem introduced with an earlier patch, on this patchset

-    $data{'userid'} = Generate_Userid($data{'borrowernumber'},
$data{'firstname'}, $data{'surname'}) if $data{'userid'} eq '';
+    $data{'userid'} = Generate_Userid( $data{'borrowernumber'},
$data{'firstname'}, $data{'surname'} )
+      if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) );

Check_Userid returns 1 if it is unique.  So this means unique userids
will always be discarded and new ones created.

This is why all the tests depending on a userid are now failing

To test

1/ run perl t/db_dependent/Serials_2.t
2/ Notice lots of tests fail
3/ OR Add a borrower with a userid set, notice the userid is ignored
and one is generated instead
4/ Apply patch
5/ Add a new borrower, notice the userid sticks (if it is unique)
6/ Run perl t/db_dependent/Serials_2.t notice tests pass
7/ Run perl t/db_dependent/Members.t notice tests still pass

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/Members.pm