]> git.koha-community.org Git - koha.git/commit
Bug 2539. Remove unintegrated "spsuggest" code from search scripts.
authorJoe Atzberger <joe.atzberger@liblime.com>
Thu, 2 Jul 2009 03:47:35 +0000 (22:47 -0500)
committerGalen Charlton <galen.charlton@liblime.com>
Wed, 15 Jul 2009 01:20:25 +0000 (21:20 -0400)
commitaf1fb6f0b44d9ba67c2b6149b4b68e611c53bdeb
treeb2b0cbcdbfa9546dfba1a4a10c2c740ee2c00f4c
parentdff98d61f0898d12e0e62987ef55e05a8034c67a
Bug 2539. Remove unintegrated "spsuggest" code from search scripts.

The intent of kohaspsuggest is very confused.  It wanted to simultaneously
log every search query, and get spelling suggestions from a totally different
database_host:db_user:db_password:database.  The implementation seems
never have really made it into 3.0, however, since the only trace of the
tables it wants to query are in misc/migration_tools/22_to_30/phrase_log.sql

The job misc/spellcheck_suggest/make_spellcheck_suggest.pl does not even
target the same remote DB as the syspref tells the search code to do.  Instead, it hits the
local DB and, not finding the tables that have no way of existing in a 3.0
install, it CREATES its own tables spontaneously, using MyISAM storage, no less.
This script should be drastically overhauled, or more likely just removed.

Other fixes:
Commented out unconditional warn!
Also reduced bizarre whitespace amounts in catalogue/search.pl and
fixed warning as recommended by perl -wc:
    Scalar value @newresults[0] better written as $newresults[0]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
catalogue/search.pl
opac/opac-search.pl