Bug 35322: Fix the logic for checking for holds in CanBookBeIssued
authorKyle M Hall <kyle@bywatersolutions.com>
Mon, 13 Nov 2023 15:37:43 +0000 (10:37 -0500)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 2 Feb 2024 17:56:31 +0000 (17:56 +0000)
commitb59f8701af40f34cb9a41c1d59265fb8f8391d1b
tree27d58cdb9c230d6d401afa7804afa2f276ea283f
parentdbc487fddda2c8eeb450e58a470268ad90e5bc98
Bug 35322: Fix the logic for checking for holds in CanBookBeIssued

We are having reports that AllowItemsOnHoldCheckoutSCO and AllowItemsOnHoldCheckoutSIP no longer work. It appreas that in CanBookBeIssued, the ignore reserves check was changed from "check reserves unless the ignore reserves flag was passed" to "check reserves unless the ignore reserves flag was passed *and* we have a recall". I think this was a logic mistake and we want to check reserves unless we have an ignore flag *or* there is a recall.

Test Plan:
1) Enable AllowItemsOnHoldCheckoutSCO
2) Place a hold on an item
3) Attempt to check that item out to another patron
4) Note the checkout is blocked
5) Apply this patch
6) Restart all the things!
7) Attempt the checkout again
8) The checkout now succeeds!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 9b10f69ee318c6fe3fa1ffb6de82c0f9888cac71)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit c279c31dafd92b83bdce86bbdce6012fed2a50be)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
C4/Circulation.pm