]> git.koha-community.org Git - koha.git/commit
Bug 18958: (follow-up) Ensure hold fill target reserve_id is set for all hold types
authorNick Clemens <nick@bywatersolutions.com>
Tue, 25 Aug 2020 10:35:02 +0000 (10:35 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 16 Oct 2020 16:48:15 +0000 (16:48 +0000)
commitbac2e6892a817482f14249aceb1420c2700416d6
tree113669d4c29de158fce982ea6f5cdb08816a529e
parentdbb9e36c68de686a9f6f6b8ba63c2f58006bd6d5
Bug 18958: (follow-up) Ensure hold fill target reserve_id is set for all hold types

MapItemsToHoldRequests has three sections: Local holds, item level holds, bib level holds

Only one of them was setting the reserve_id. This patch makes al three set it and adds tests

To test:
1 - Repeat test plan on bug
2 - sudo koha-mysql kohadev
    SELECT * FROM hold_fill_targets
3 - Ensure reserve_id is set at appropriate times
4 - prove -v  t/db_dependent/HoldsQueue.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Bug 18958: (QA follow-up) Fix number of tests

In HoldsQueue.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit b255ca7c6eec7be3027e6ade00d8477102062281)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
C4/HoldsQueue.pm
t/db_dependent/HoldsQueue.t