]> git.koha-community.org Git - koha.git/commit
Bug 17944 - Add Koha::ItemType->can_be_deleted and use it from admin/itemtypes.pl
authorAlex Buckley <alexbuckley@catalyst.net.nz>
Sun, 22 Jan 2017 01:52:50 +0000 (01:52 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 9 Jun 2017 14:23:32 +0000 (16:23 +0200)
commitc31db771b38053867369fd5833f0b4f1ee7e9b0d
tree868f9e9d9fd5f0f15df1919cbc9625c3b296109f
parent14e8f5bb713bd4f45a85f028e0c9b5738f3eefd5
Bug 17944 - Add Koha::ItemType->can_be_deleted and use it from admin/itemtypes.pl

Removed the sql code from Itemtypes.pm and replaced  it with DBIx
database query in the itemtypes.pl administrative script

Test plan:
1. In the staff interface, stage and manage MARC records for import

2. Try to delete an itemtype. If there are items of that itemtype in the
   database then a message telling you the number of items of that
   itemtype there are will be displayed.

3. Record that number

4. View the admin/itemtpes.pl script and confirm that there is sql code
   written in this file.

5. Apply this patch

6. View the admin/itemtypes.pl script and observe that there is no sql
   in this file. There is however DBIx code, for example
   $schema->resultset('Item')->search({ 'itype' => $itemtype_code} );
   which is searching for items with the itype value matching
   $itemtype_code value.

7. In the staff interface try to delete the same itemtype

8. Record the number of items there are with that itemtype in the
   resulting message

9. The numbers recorded in steps 3 and 8 should match showing that the
   DBIx code is working as intended

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit db3ebe47e859e85659b1a2565a03bcb6b59df0ff)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/ItemType.pm
admin/itemtypes.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
t/db_dependent/Koha/ItemTypes.t