]> git.koha-community.org Git - koha.git/commit
Bug 18697: Fix date calculations for weekly frequencies in Serials
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tue, 30 May 2017 13:01:52 +0000 (15:01 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 29 Jun 2017 07:14:04 +0000 (09:14 +0200)
commitdae1a7ccdf49b8d99748a659c6fff80185980e7f
treed91e53853ebd04ec0635bab67aa221c22358127c
parent45c31333a879e35ecf7ddc12d5305002c80ba065
Bug 18697: Fix date calculations for weekly frequencies in Serials

Same solution applied as in bug 18356/18607. Consistency++

The code in _get_next_date_week is again very similar to the code in
_get_next_date_month or _get_next_date_year. I will not merge them here,
but we could consider that in the future.

Code in GetFictiveIssueNo has been adjusted similarly to month and year.

Test plan:
[1] Do not apply this patch. Create a subscription for 3/week.
    When the first issue date is on a Saturday or Sunday, the
    intervals in the prediction pattern are 0,0,7,0,0,7,etc.
    Starting on Wed-Fri 1,1,5,etc. Starting on Mon-Tue 2,2,3,etc.
[2] Apply this patch. Check again.
    The interval should be always 2,2,3 now and no longer depend on the
    day_of_week of first issue date.
[3] Check another weekly frequency with multiple units per issue.
    Say 1 issue/3 weeks.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit ffb1c87d2962b19a07798da3bf81bef328270145)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/Serials.pm