Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics' table
authorTomas Cohen Arazi <tomascohen@theke.io>
Sun, 26 Jul 2015 05:05:16 +0000 (02:05 -0300)
committerMason James <mtj@kohaaloha.com>
Mon, 12 Dec 2016 01:54:10 +0000 (14:54 +1300)
commitdb99e5ff04298683a4b6651f0b906de0336b5646
tree957a0a79301dd98f8b53220da77407b9f2a932b3
parent22cbe4618555a0fa07c321abdfebe0fa8cd0dd3f
Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics' table

This patch adds tests for C4::Circulation::AddReturn(). Both tests are wrapped
inside a subtest, and look for AddReturn storing the right itemtype on the
'statistics' table.

Note: It also refactors the file a bit, to avoid side effects. And uses TestBuilder
to make it independent on already-present db data. It also removes warnings by mocking
C4::Context::userenv

To test:
- Apply the patch
- Run the tests:
  $ prove t/db_dependent/Circulation/Returns.t
=> FAIL: Tests fail bacause AddReturn is not storing the itemtype
- Sign off :-D

Sponsored-by: Universidad Empresarial Siglo 21
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Mason James <mtj@kohaaloha.com>
t/db_dependent/Circulation/Returns.t