]> git.koha-community.org Git - koha.git/commit
Bug 27180: Update fines on holidays
authorNick Clemens <nick@bywatersolutions.com>
Wed, 9 Dec 2020 15:39:09 +0000 (15:39 +0000)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Fri, 22 Jan 2021 20:38:43 +0000 (20:38 +0000)
commitedadfd0cc00d68271040bd6bcfa4b0e9f5d2adc3
tree4a594004087af9f1e1fbda9036151a60a3fc9a88
parent52e2fed230d2f4464ff38583f8d61989766d9584
Bug 27180: Update fines on holidays

This patch removes code that prevents fines from being update on holidays.
The fines are already being calculated, and that takes the calendar into account if
needed, so fines won't be assessed on holidays if they shouldn't.

To test:
 1 - set finesCalendar to 'ignore'
 2 - Checkout an item due yesterday
 3 - Ensure circ rules have a fine amount set
 4 - Make today a holiday
 5 - run fines.pl
 6 - No fine assessed
 7 - Apply patch
 8 - run fines.pl
 9 - Fine assessed!
10 - set finesCalendar to 'use'
11 - checkout an item, due yesterday
12 - run fines.pl
13 - no fine assessed

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 80e1b4e66f01a07cad9bf37625d879f649edf52a)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 69821f7aba39009b850aef5716a0818f3cb61d54)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
misc/cronjobs/fines.pl