]> git.koha-community.org Git - koha.git/commit
Bug 20110: Adding same user multiple times to same budget
authorPasi Kallinen <pasi.kallinen@joensuu.fi>
Wed, 31 Jan 2018 09:11:56 +0000 (11:11 +0200)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 16 Feb 2018 01:20:01 +0000 (01:20 +0000)
commitf2c3d7aedfbb4028595a4ed8e8128f1d25b3eae0
tree63bf42b572907724788b5bf41821e65eea0ce654
parenteb119a7b07d99a8ec4b6d3d146ab0f6a3e914d6a
Bug 20110: Adding same user multiple times to same budget

In javascript, using indexOf to test if a number exists in an array
of strings doesn't work, and makes it possible to add the same user
multiple times into the same budget fund.
Make borrowernumber into string and compare that instead.

Test plan:

1) Go to Home -> Administration -> Budgets -> Funds -> Add Fund
2) Add a user to the fund
3) Try to add the same user again to the same fund. No error.
4) Apply patch
5) Do 1, 2, and 3 again. You should now get an error message
   saying the user is already in the list.

Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Conflicts:
koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt