IMPROVEMENT (for #1416 : Available items marked waiting as soon as hold is placed)

In fact, #1416 is not a bug, it's a feature : SAN-OP librarians place the reserve "book in hand", and confirm on phone that it's available
NPL save the reserve, but pick them from the shelves once a day only. So the item must be "to pull"

This commit improves the behaviour :
- document Reserves.pm a little, it was needed !
- add a systempreference ReservesNeedReturns, that let the library choose it's behaviour
- define the systempref in english & french systempreferences files
- add the systempref through the web installer (bumping to 3.00.00.003)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Revert "#1485 saving issuingrules"

This reverts commit 31eaffcb04ab1cf2100b3b387b82eb3b1e2ac9e8.

New object-oriented date module to soon replace Date.pm.

Also included is a traditional perl (t/Dates.t) test script.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

#1456, automatically suggest user branch as pickup branch

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bugfix : some column add a wrong size

In Koha 3.0, most short code have been resized to varchar(10). This includes itemtype, branchcode, patron category
I've found some tables refering to an old-small-size definition

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

splitting updatedatabase in 2 parts

- update 22to30, that does the update from 22 to 3.0 using old mechanism.
- updatedatabase, that just does new updating stuff.

Note that there are fixes on some column size (next commit will contain fixed kohastructure.sql)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

#1485 saving issuingrules

lot of bugs to fix...
- a foreign key on patron category is stupid as we have a wildcard
- having a wildcard on itemtype is useless, removing it in template
- reindenting & removing some commented lines
- fixing some SQL bugs (insert/update lines)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

#1473: MARCfindbreeding breaks MARC21 records in reservoir

doesn't change anything for UNIMARC (as expected), UNTESTED for MARC21, pls test it

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

#668 cancel reserve on checkout does not work

The reserve was cancelled only under certain circumstances (depending on reserve status)
cancelling everytime.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

1340 (querying 2 z3950 servers merged results)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1415: typo s/button/submit/

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

move the xslt dir to a language-specific dir

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding barcode index

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for 1279: Detail page should display error message for invalid biblionumbers

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

refining label printing

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

new auth values for MARC21

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Missing session->delete on users voluntary logout

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

improvements to marc21 framework

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding session storage to the other place sessions are made

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Setting up a system preference to choose whether CGI::Session uses mysql, or

temporary files
Need to add it to a couple more places in C4::Auth

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

partial 1481: adding back missing updateitem.pl script

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

improvements to english auth values

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more work on 1481: adding back drop-downs for

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

partial 1481: adding to templates, fixing non-display of data

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

partial 1481: adding back missing updateitem.pl script

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updates to marc21 default framework

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

improvements to the english sysprefs

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removing cvs-specific version statement

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

refining barcode plugin, two new options

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding dateaccessioned plugin

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removing multivolume,multivolumepart,binding

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bug #1462 correction.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding better english stopwords

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Acquisition minor improvements

Fixing a SQL bug hdl introduced yesterday when updating queries & that I missed when reviewing them.
changing the look of the basket & parcel by adding & moving some link

The goal is to have the same kind of lists & links everywhere. (Will continue on monday)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

MARC21 plugins fixed

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

1409 empty search term in subscription search biblio

+ removing some useless code

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

commenting a warn

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

1363 (mandatory field break MARC editor)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing upbutton that has disappeared & fixedfield condition check

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

#1452 (Labels for item editor are truncated)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BUGFIX: Handle etc/zebradb tree

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Version bump to match updater/updatedatabase

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

#1459 yadc : Yet Another Date::Calc problem...

if dateexpiry is empty, set issuingimpossible without any calculation

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

#1447 : avoid a SQL message when filling the table

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

moving _( function to header

This function is used to extract strings for translator tool. It must be available everywhere, moving it to head-close.inc
& removing it elsewhere

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BUG FIXING : 210$c is now searching EDITORS

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

french translation .po

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

small html fix (mostly for translator purposes)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

improving alternate (drupal inspired) stylesheet

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

(minor) removing useless template params

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bump to 3.00.00.006 : issues.issuedate auto fill added on update

In Koha 2.2 there was no field to store the issue date. There was only a timestamp
which is modified every time you do something on the line.
it's fixed in 3.0, but the new issuedate field is empty for 2.2 catalogue migrated to 3.0
This fills the issue date with a value that is probably wrong, but we can't know the correct one.
at least we have something and the stats works (Date::Calc is very unhappy if the field is empty)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding IndependantBranches Filter + adding some ordering on member list display.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Revert "Adding IndependantBranches Filter + adding some ordering on member list display."

This reverts commit 0dee069f30f05f0d63d3b5e5047cdd3986aa373c.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding IndependantBranches Filter + adding some ordering on member list display.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

No need of wrdl for kw search

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updating opac searches, same as librarian

(adding explicit wrdl to some queries)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updating french translation

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Revert "fix for bug 1468, but not sure if this is the best"

This reverts commit ae206e86adf8eb281fd1029364c1e705f2ffa197.

Merge branches 'master' and 'mymerges'

More work on global resident search, toolbars, and menus.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Merge branches 'master' and 'mywork'

fix mail -> male

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

syntax error in memberentry

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding support for M and N sex

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for bug 1468, but not sure if this is the best

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

#1455 (placing reserve from OPAC)

SANOP hadn't ported reserve to OPAC yet. that's why opac reserves were no more working.

I've fixed that, but it need more testing...

Signed-off-by: Chris Cormack <crc@liblime.com>

Adding IndependantBranches Filter + adding some ordering on member list display.

Signed-off-by: Chris Cormack <crc@liblime.com>

Revert "Adding IndependantBranches Filter + adding some ordering on member list display."

This reverts commit 0dee069f30f05f0d63d3b5e5047cdd3986aa373c.

Signed-off-by: Chris Cormack <crc@liblime.com>

Adding IndependantBranches Filter + adding some ordering on member list display.

Signed-off-by: Chris Cormack <crc@liblime.com>

Bug Fixing : privilege for blinddetailbibliosearch mistakenly was editauthorities

Signed-off-by: Chris Cormack <crc@liblime.com>

BUG FIXING : Using LEFT JOIN in replacement of implicit inner joins. WARN NOT FULLY TESTED

Signed-off-by: Chris Cormack <crc@liblime.com>

History was broken by my correction on SQL for SearchHistory. Corrected.

Signed-off-by: Chris Cormack <crc@liblime.com>

No need of wrdl for kw search

Signed-off-by: Chris Cormack <crc@liblime.com>

removing warn

Signed-off-by: Chris Cormack <crc@liblime.com>

updating opac searches, same as librarian

(adding explicit wrdl to some queries)

Signed-off-by: Chris Cormack <crc@liblime.com>

bugfix $itemtype => $value

Signed-off-by: Chris Cormack <crc@liblime.com>

#1445 checking that there is an expiry date

if there is none, automatically warn the librarian

Signed-off-by: Chris Cormack <crc@liblime.com>

(minor) updating doc & removing warn

Signed-off-by: Chris Cormack <crc@liblime.com>

#1450 (marc21 plugins)

dunno why toins missed to report new marc editor changes to marc21 plugins...
(00x & leader.tmpl tested, other not tested, I don't know which field they are for. but it's a copy paste of 1 line, should work anyway)

Signed-off-by: Chris Cormack <crc@liblime.com>

add tip to branches for IP feature

Signed-off-by: Chris Cormack <crc@liblime.com>

#1449: Installer improved to add a zebra/Nozebra screen

+ some minor changes in html

Signed-off-by: Chris Cormack <crc@liblime.com>

fix to the new input param

Signed-off-by: Chris Cormack <crc@liblime.com>

adding new input to marc21 plugins

Signed-off-by: Chris Cormack <crc@liblime.com>

restoring marc21 plugin templates

Signed-off-by: Chris Cormack <crc@liblime.com>

fix for bug 1451

Signed-off-by: Chris Cormack <crc@liblime.com>

chmod 644 on all modules

Signed-off-by: Chris Cormack <crc@liblime.com>

FIX for #1441 (AutoLocate not work as advertised)

Signed-off-by: Chris Cormack <crc@liblime.com>

fix for #1430 (subscription add fails)

due to us date format not properly set

Signed-off-by: Chris Cormack <crc@liblime.com>

unimarc specific : sorting on date-of-publication

Signed-off-by: Chris Cormack <crc@liblime.com>

oups, sorry, missing #

Signed-off-by: Chris Cormack <crc@liblime.com>

Adding itemtypes and branches in MARCdetail BugFixing moremember.tmpl : column descriptions were messed.

Signed-off-by: Chris Cormack <crc@liblime.com>

Bug FIXING : Some SQL queries had an old SQL 4.1 form.

Fixing it with LEFT JOIN.

MUST Be CAUTIOUS about biblioitems numbers.
Does a biblio have one and only one biblioitem ?
I took this for granted. But maybe it is not supposed to be so.

Signed-off-by: Chris Cormack <crc@liblime.com>

BUG FIXING + Modification in API for DelIssue

DelIssue now takes in a reference hash of data to delete (serialid, subscriptionid and serialseq are required)
DelIssue now delete one peculiar serialid and doesnot proceed only on serialseq any longer.

Signed-off-by: Chris Cormack <crc@liblime.com>

filefind.png. Why not having the same architecture between intranet and opac img or images ?

Signed-off-by: Chris Cormack <crc@liblime.com>

Bug Fixing : page changes were broken for unimarcfield_4XX.pl

Signed-off-by: Chris Cormack <crc@liblime.com>

some cleaning in Auth

Signed-off-by: Chris Cormack <crc@liblime.com>

removing un-open TMPL_IF

Signed-off-by: Chris Cormack <crc@liblime.com>

Refining holds menu display; restructuring forgotton stopwords.tmpl with breadcrumbs, layout, etc; Formatting reports-home.tmpl as "dashboard."

Signed-off-by: Chris Cormack <crc@liblime.com>

Several changes: - add check in link to circulation checkouts listing

Signed-off-by: Chris Cormack <crc@liblime.com>

More work to toolbars and menus. Adding experimental YUI-based toolbar to detail.tmpl. Adding dashboard-style layout to tools-home.tmpl. Correcting markup in request.tmpl. Adding patron information variables to request.pl for display in holds-menu.inc.

Signed-off-by: Chris Cormack <crc@liblime.com>