Garry Collum [Mon, 8 Jun 2009 20:54:23 +0000 (16:54 -0400)]
Bug 2889: Removed toggle variable from koha2marclinks.tmpl. Used template __odd__ variable.
Removed toggle variable from koha2marclinks.tmpl and koh2marclinks.pl. Used template __odd__ variable instead.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Mon, 8 Jun 2009 21:36:25 +0000 (17:36 -0400)]
Bug 2889: Removed toggle variable from currency.tmpl. Used template __odd__ instead.
Removed toggle variable from currency.tmpl and currency.pl. Used template __odd_ variable instead.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 5 Jun 2009 22:47:00 +0000 (17:47 -0500)]
bug 3259 part 3: changed last 'Too Many Renewals' to 'Not Renewable'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nicole Engard [Thu, 4 Jun 2009 15:48:32 +0000 (10:48 -0500)]
Fix Bug 3259 part 2 - fixed terminology on circulation.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nicole Engard [Thu, 4 Jun 2009 15:44:20 +0000 (10:44 -0500)]
Fix Bug 3259 - change 'too many renewals' to 'not renewable'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 5 Jun 2009 22:38:32 +0000 (17:38 -0500)]
followup: remove unconditional warn
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Thu, 4 Jun 2009 17:43:53 +0000 (12:43 -0500)]
Standalone branch selection
selectbranchprinter now posts to itself to set the branch. That also means that
other pages can set the branch by linking to selectbranchprinter like:
/cgi-bin/koha/circ/selectbranchprinter.pl?branch=MAIN
We use HTTP_REFERER to allow the user to continue back to wherever they linked from,
defaulting to circulation.pl (the former POST target).
Note that all "branchprinter" functions are basically useless as the data is not
properly handled in the session storage. Chris C. expects this to be addressed
with later patches for HLT. There appear to be no 3.0 users of this intended
functionality yet.
Includes squashed patch to fix tmpl and to automatically redirect if there are no
POST params to be recycled.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 29 May 2009 21:09:34 +0000 (16:09 -0500)]
Cleanup selectbranchprinter.pl and .tmpl
Use GetBranchesLoop and warnings. Remove unused code. Moved the Get's to after auth.
I begin to show how this script will use referer to redirect back to the sending
page upon successful change of branch or printer (see hidden div and recycle_loop).
Indicator for singleBranchMode added.
Also added another helper function for GetBranchesLoop, namely mybranch. This
encapsulates the logic for finding an intelligent default selection, which is
almost always desirable.
This does not resolve bug 2426, but is work in that direction.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 5 Jun 2009 17:18:50 +0000 (12:18 -0500)]
Cleanup cities.pl and .tmpl - major
80% of the javascript was junk.
Bad check failed on non-existant field borrowers.select_city.
Enabled warnings. Reduced "StringSearch" to 3 lines, removed unused args and vars.
Fixed row highlighting and removed "toggle" code. Etc.
TODO: Stop redirecting to the same page. Instead get the correct data and show it
on THIS pass.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 5 Jun 2009 22:06:16 +0000 (17:06 -0500)]
followup previous patch - remove disused $opacstylesheet
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 24 Apr 2009 20:09:55 +0000 (15:09 -0500)]
Bug 3127 - Stub function prevents undefined reference
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Thu, 5 Feb 2009 19:04:20 +0000 (13:04 -0600)]
Bug 2919 -- fix value_builder plugins for dateaccessioned, barcode
This patch depends on my previous one "Begin cleanup on additem" and
fixes one bug introduced in that patch.
Overhaul of additem sections to factor out common pieces especially attributes.
Plugin js vastly simplified and reimplemented in jquery. Performance improved.
Note that a particularly busy cataloging department should still leave
barcode blank for server-side autopopulation to avoid collision.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 7 Apr 2009 19:03:02 +0000 (14:03 -0500)]
Adding new "tag" icon to tag link in lists interface. Also removing an unwanted ID from opac-shelves.tmpl markup.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 7 Apr 2009 19:48:16 +0000 (14:48 -0500)]
More fixes for Bug 3044
Hiding the results page's "Add to Cart" links with CSS and revealing them with javascript; Writing the "Add to Cart" link to the opac-detail page with js using the biblionumber embedded in the Export form.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 18 Mar 2009 12:49:56 +0000 (07:49 -0500)]
Writing Cart button to DOM with inline script. Fixes Bug 3044 without reintroducing Bug 2887 ("Cart is not translated").
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Sat, 4 Apr 2009 18:53:48 +0000 (13:53 -0500)]
New styles for bulk hold and bulk tag inputs on search results page.
This change gives the buttons a link style like is used on the lists page. My hope is that the similarity will help the user recognize the function, and the differentiation from the "Save" button will improve the clarity over having three similar buttons.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frédéric Demians [Wed, 1 Apr 2009 19:36:28 +0000 (21:36 +0200)]
Internationalize Amazon support
With this patch:
* On Amazon book cover, 'search inside' text is not displayed
anymore because it's not translatable.
* Link the image to local Amazon web site 'search inside' service.
Based on AmazonLocale syspref.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 13 Mar 2009 14:57:14 +0000 (09:57 -0500)]
DDCN callnumber splitting with test.
Similar to previous patch for LCCN splitting, this patch incorporates
changes to split_ddcn and supplies a test file for verifying proper
operation. Note that the only previously documented example for intended
operation is included as one of the tests.
This regexps are created to be rather forgiving. For example, the function
will not choke if two spaces were included where the "spec" (such as it is)
expects one. Obviously this is because for CN splitting purposes, it doesn't
matter, we're not going to ever split in the middle of whitespace.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 3 Apr 2009 16:14:49 +0000 (11:14 -0500)]
fix syntax error in tags JavaScript
FF will tolerate a trailing comma in an
array literal, but Internet Explorer does not.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 1 Apr 2009 16:02:48 +0000 (11:02 -0500)]
add } that slipped out because of bad merge
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joshua Ferraro [Fri, 6 Feb 2009 18:52:08 +0000 (12:52 -0600)]
Move Amazon.pm to External/ directory
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Sat, 7 Mar 2009 00:27:50 +0000 (18:27 -0600)]
Test for LCCN splitting.
This test establishes what LCCN splitting is required to do
to be considered successful. See Bug 2691.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Mon, 9 Mar 2009 20:19:31 +0000 (15:19 -0500)]
Bug 2691 - LCCN split (for labels)
This corresponds with the test I submitted earlier and essentially
overrides the partial improvement from Nighswonger under Bug 2500.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Daniel Sweeney [Mon, 9 Mar 2009 21:44:36 +0000 (16:44 -0500)]
Fixed a typo that kept branches out of the Advance Notice and Item Due notifications.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Mason James [Tue, 10 Mar 2009 01:50:53 +0000 (14:50 +1300)]
Resubmitting: fixes print statements with missing 'STDERR' in Auth_with_ldap.pm,
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Tue, 27 Jan 2009 00:24:10 +0000 (18:24 -0600)]
Branchoverdues circ report reworking.
branchoverdues.pl
~ Removed unused variables.
~ Use elsif where applicable.
~ Added many FIXMEs.
~ Added help description.
~ Changed link to more accurate description.
~ REFACTORED branchoverdues-specific function in C4 for obvious consolidation.
This report is still of questionable value, since it's dataset has such strange
hardcoded limitations. It is not clear that "FU" type fines and notifys=0 are
reliable or useful indicators to query on, in hardcoded form.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
James Winter [Wed, 4 Mar 2009 20:57:01 +0000 (15:57 -0500)]
bug 2703: Changed spent.pl select statment to include joins between tables.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Thu, 5 Mar 2009 20:37:49 +0000 (14:37 -0600)]
Markup and style corrections.
Corrects case of "onclick" and creates new style for "send" link rather than re-using inapplicable toolbar ID.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Mason James [Mon, 26 Jan 2009 00:05:30 +0000 (13:05 +1300)]
- perltidy corrects broken indentation on 'if' block.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Mason James [Thu, 22 Jan 2009 22:04:50 +0000 (11:04 +1300)]
fix for bug-2923, corrects renew status in SCO
- removes unneeded HTML::Template::Pro
- some indent/newline tidies
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 25 Feb 2009 19:29:41 +0000 (13:29 -0600)]
display library name instead of code in limit description
The OPAC and staff search results page will now display
the library name instead of the library code in the limit
part of the search description, e.g.,
"kw,wrdl: cat branch:Centerville" instead of
"kw,wrdl: cat branch:CPL"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Fri, 20 Feb 2009 16:59:28 +0000 (10:59 -0600)]
Adding additional information and consolidating display of information in holds queue report
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Thu, 26 Feb 2009 19:17:52 +0000 (13:17 -0600)]
Correction: Greybox js should be loaded only if XSLTDetailsDisplay is on (not only if GoogleJackets is on)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 25 Feb 2009 14:38:37 +0000 (08:38 -0600)]
Using "escape=html" on TMPL_VAR containing SQL to prevent HTML from breaking when SQL includes double-quotes.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joshua Ferraro [Wed, 4 Feb 2009 16:46:22 +0000 (10:46 -0600)]
Adding warnings to request/ files
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 30 Jan 2009 21:21:29 +0000 (15:21 -0600)]
holds policies fixes
* use item branch instead of patron's branch to
look up the applicable hold policies - this makes
requesting in the OPAC consistent with the intranet.
* when generating pick list using build_holds_queue.pl, only match items
to patrons if request is allowed.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Sat, 7 Feb 2009 20:39:18 +0000 (14:39 -0600)]
Fix for Bug 2911: popup calendar not available in IE
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
John Beppu [Tue, 3 Feb 2009 22:02:11 +0000 (16:02 -0600)]
[Checkout Slips Part 3 14/16] SQL
- fixed syntax errors (thanks Dan)
- made sample_notices.sql mandatory
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Liz Rea [Thu, 4 Jun 2009 16:22:00 +0000 (11:22 -0500)]
Bug 3289 - Fixed bad conditional check that made news items not show up until the day after pubdate.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Wed, 3 Jun 2009 21:37:01 +0000 (17:37 -0400)]
Bug 2624: Fix for non-persistent check boxes in check-in screen.
Found this bug when playing with AutomaticItemReturn. The "Forgive overdue charges" and "Dropbox mode" would lose their value the item was transfered (if automatic transfer was off), caught a hold, or caught a hold at another location.
This patch does not completely do away with the problem. If an item is checked-in in simple mode, then one of the forms mentioned above opens, then the user checks one of the selection boxes, the value is not retained. Javasript would have to be added to transfer the value to the confirmation form when the checkbox is clicked.
This patch also cleans up a few minor XHTML errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Thu, 4 Jun 2009 10:26:10 +0000 (12:26 +0200)]
(bug #3291) fix blue.css to bold fields and tags in marc view
Add a css property, and fix a class, to show fields and subfields as bold.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Wed, 3 Jun 2009 16:26:26 +0000 (11:26 -0500)]
Minor POD update - copied section doesn't apply to other function
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Sat, 30 May 2009 22:30:13 +0000 (18:30 -0400)]
Bug 3268: Adds the ability to edit the description of a holiday.
Adds another radio button to the edit holiday form. This is a partial fix, because you cannot make an edit to a single holiday for multiple branches.
Also fixed a small XHTML error and a wording error from my previous patch on holidays.tmpl (bug 3274).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Sat, 30 May 2009 16:29:11 +0000 (12:29 -0400)]
Bug 3274: Patch to fix Holiday Exceptions radio button.
Holiday exceptions only make since for repeatable holidays. Javascript showHoliday function was looking for a 'showTitle' id that no longer existed in the showHolidau form. Added a hidden input field because of the possibility of re-adding the title text input field at a later time.
Added code to determine whether a holiday as an exception or not, so that the "Delete this program" radio button changes to "Delete this exception" because that is the program's true functionality if the holiday is an exception.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Sun, 31 May 2009 02:27:33 +0000 (22:27 -0400)]
Bug 3275: Fixes typo (maxlentgh) in opac-suggestions.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Sun, 31 May 2009 11:02:29 +0000 (07:02 -0400)]
Bug 3276: Minor XHTML error in opac-passwd.tmpl
Fixes a reference to a non-existent id.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
savitra.sirohi [Wed, 3 Jun 2009 03:55:41 +0000 (09:25 +0530)]
Allow zebra search for Lexile numbers in field 521$a
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Tue, 2 Jun 2009 22:44:31 +0000 (18:44 -0400)]
Bug 3283: Fix for a minor XHTML error in opac-tags_subject.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Tue, 2 Jun 2009 20:05:05 +0000 (15:05 -0500)]
bug 3170 followup
* tags >= 010, not just > 010, can have subfields
* fixed so that mandatory fields are checked
regardless of whether a new one is created
or an existing one modified
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Fri, 29 May 2009 10:32:46 +0000 (12:32 +0200)]
(bug #3170) do not check fields < 010
This patch add a if, to disallow the check of fields < 010, because they could have no subfields, and are mandatory.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Thu, 30 Apr 2009 13:09:36 +0000 (15:09 +0200)]
(bug #3170) check if mandatory fields are not empty
This patch make authority and biblio add/edit to check that at least one subfield of mandatory fields are filled-in.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 29 May 2009 13:37:14 +0000 (08:37 -0500)]
bug 3272: preserve formatting when editing help
Tweak the TinyMCE settings so that more of the original
whitespace and HTML is preserved when editing help, making
help patches easier to understand.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Zeno Tajoli [Fri, 29 May 2009 08:28:25 +0000 (10:28 +0200)]
Fix(2) bug 3266 The 'link' feature in MARC_framework is only for MARCDisplay This second patch for the same bug is only for white spaces and newlines
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Fri, 29 May 2009 02:30:24 +0000 (22:30 -0400)]
Bug 3252: Fixes XHTML on catalog statistic form page.
Several form input fields were within a <table> element, but not in a <td>. This patch pulls the input fields out of the table.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 29 May 2009 01:13:21 +0000 (20:13 -0500)]
bug 2884: followup patch
[1] Restore behavior of the input field for the library
code; when adding a new library, it should be a
a text box; when editing an existing library,
should be a hidden input.
[2] When user attempts to add a new library with the same
code as that of an existing library, populate the form
with what the user entered for the new library, not the
values from the existing library.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Paul Poulain [Thu, 28 May 2009 16:32:16 +0000 (18:32 +0200)]
fix for #2884: Add error management to branches
While trying to add a new Branch with an existing Branch code, the UI says "Library saved" instead of something such as "Please select a unique branch code".
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Paul Poulain [Thu, 28 May 2009 16:32:21 +0000 (18:32 +0200)]
removing comments
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Paul Poulain [Thu, 28 May 2009 16:32:19 +0000 (18:32 +0200)]
Fixing API of ModBiblioMarc
no need to retrieve $biblionumber, as we already know it
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Paul Poulain [Thu, 28 May 2009 16:32:24 +0000 (18:32 +0200)]
(not new_acq related) smallfix to avoid a die in case of an invalid record
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Paul Poulain [Thu, 28 May 2009 16:32:27 +0000 (18:32 +0200)]
removing useless line (use Data::Dumper)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Zeno Tajoli [Thu, 28 May 2009 12:45:20 +0000 (14:45 +0200)]
Fix bug 3266 The 'link' feature in MARC_framework is only for MARCDisplay
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Thu, 28 May 2009 01:48:12 +0000 (21:48 -0400)]
Bug 2266: Could not uncollapse a tag if you turn on advancedMARCeditor - Revised.
Added javascript and if/else logic to the addbiblio.tmpl and a corresponding anchor tag in CSS.
If advancedMARCeditor is on, the user now clicks on the tag number to expand the marc fields.
If advancedMARCeditor is off, no functionality has changed. The user clicks on the marc tag's title to expand the marc fields.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Wed, 27 May 2009 18:38:58 +0000 (13:38 -0500)]
Allow option to preserve Extended Attributes on patron import update.
Essentially, this patch provides the option to overwrite only matching
Extended Attributes, instead of all of them, treating the ext. fields more
like normal fields.
Several functions added to Members::Attributes with corresponding tests.
[ LL ref. 342 ]
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Rick Welykochy [Wed, 27 May 2009 18:10:44 +0000 (13:10 -0500)]
bug 2641, 3263: Staff Search Results Interface Changes
New detail view: labeled MARC
New bib record view in the staff interface that
displays the MARC record in a single page.
Featured sponsored by MassCat.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Wed, 27 May 2009 18:10:43 +0000 (13:10 -0500)]
bug 1933: started work fixing IntranetBiblioDefaultView syspref
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Ricardo Dias Marques [Tue, 26 May 2009 22:42:34 +0000 (23:42 +0100)]
Updated INSTALL.opensuse file to wiki version
Updated INSTALL.opensuse file to match the one currently (as of 26-May-2009) available in the wiki at:
Installation Guide for Installing Koha 3 on openSUSE 11 - Koha Developer Wiki
http://wiki.koha.org/doku.php?id=opensuse_11.0
This commit is supposed to be applied to the 3.0.x branch.
Changelog:
– Updated last modification date to 02-Dec-2008
– Tried to clarify that one should add the word "rewrite" (without the quotes) to /etc/sysconfig/apache2 in case a2enmod does NOT work
– "make test" does NOT return "Can't connect to data source" errors any longer. Updating "make install" section accordingly
– Updated "make test" output for Koha installation (it doesn't give connect errors any longer)
– Added prompt to accept permanent instlallation of "Test-Manifest-1.22.tar.gz" during "XML::RSS" install
– Installing "XML::RSS" now also installs "Time::y2038"
– Added "force install" of "Barcode::128"
– Added output of "MARC::Charset" installation (that points that it is already up to date)
– Updated "CGI::Session::Serialize::yaml" section that now installs Test::Pod
– Added "MIME::LITE" installation that is new in Koha 3.0 Final
– Removed ImageMagick installation because it's no longer required in Koha 3.0 Final
– Added instructions to install the "GD" Perl module and its package dependencies
– Added "Email::Date" installation that is new in Koha 3.0 Final
– Updated list of prerequisites according to changes done in Koha 3.0 Final
– Added missing step to install yaz. Thanks to Bob Ewart for catching it
– Added explanation of answering Yes to "Install the Zebra configuration files" in a NOZEBRA installation, like this one
– Added explanation of "fr" (French) choice for Koha install
– Promoted run "make install" to Heading 4
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Chris Cormack [Fri, 22 May 2009 20:05:56 +0000 (08:05 +1200)]
Quick fix to catch some instances of XSS vulnerability, there will be more probably, thanks for the heads up Mark
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Sun, 24 May 2009 16:10:23 +0000 (12:10 -0400)]
Bug 1687: Can't assign holidays to all branches at once.
This patch adds a select box to the new holiday form that allows the user to copy the holiday to all branches. If a holiday for a particular location already exists for a location, that holiday and location is not changed.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Mon, 25 May 2009 00:51:18 +0000 (20:51 -0400)]
Bug 3022: Cataloging statistic wizard not pulling the itemtype data correctly.
Added code to detect if the syspref for item-level_itypes is being used. The report now correctly returns data based on the syspref. There are some pre-existing XML errors with the FORM view of catalogue_stats.pl. I'll send a subsequent patch to deal with these.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 22 May 2009 19:35:35 +0000 (14:35 -0500)]
Cleanup transferstoreceive.pl and .tmpl
Removed unused variables. Replaced EXPR.
Inserted hidden span to correct tablesorter behavior on title field. Without this patch
because of the link href in the cell, the sort would end up being effectively on
biblionumber, not title.
Mostly whitespace edits in template.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nicole Engard [Sun, 24 May 2009 01:35:46 +0000 (20:35 -0500)]
Fixed capitalization and standardized statements.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Mon, 25 May 2009 13:24:44 +0000 (09:24 -0400)]
Bug 3253: Fixes XHTML for the Patron Statistics form page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Garry Collum [Mon, 25 May 2009 13:49:01 +0000 (09:49 -0400)]
Bug 3254: Fixes the Catalog by Item Type report XHTML.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Owen Leonard [Fri, 22 May 2009 17:52:37 +0000 (12:52 -0500)]
Fix for Bug 3233, tabs on detail page change when clicking on MARC view
This change adds a check for the XSLTDetailsDisplay preference since different MARC view tabs display on the detail page if that pref is on or off.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 22 May 2009 18:37:49 +0000 (13:37 -0500)]
Cleanup circ/overdue.pl
This also fixes a deficiency with overdue.tmpl not retaining the
user's selection of sort order when displaying results.
Removed 9 unused variables.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 22 May 2009 14:18:37 +0000 (09:18 -0500)]
bug 3243: fix adding patron after resorting in patron label search
Also needed to keep track of the batch type.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
MJ Ray [Thu, 21 May 2009 14:27:19 +0000 (15:27 +0100)]
bug 3243: pcard-members-search fails to add patrons to batch after using some links
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
MJ Ray [Fri, 22 May 2009 13:53:13 +0000 (14:53 +0100)]
Add patron card member searching by category code
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Fri, 22 May 2009 12:41:22 +0000 (07:41 -0500)]
followup to previous patch - don't use TMPL_IF EXPR
Because of the way that HTML::Template::Pro evaluates
expressions, any variable referred to in a TMPL_IF EXPR
must be be present when the template is parsed, otherwise
you get Apache error log warnings like this:
non-initialized variable new_subfield
For a simple flag check, TMPL_IF NAME="new_subfield" is sufficient.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Andrei V. Toutoukine [Fri, 22 May 2009 11:53:29 +0000 (15:53 +0400)]
=?utf-8?q?Usability=20of=20marc=5Fsubfield=D1=8B=5Fstructure
modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 22 May 2009 01:37:49 +0000 (20:37 -0500)]
Cleanup circ/billing.pl
Remove ton of unused variables.
Remove wrong use of BiblioDefaultView on INTRANET side.
Consolidate failover values.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 22 May 2009 01:37:47 +0000 (20:37 -0500)]
Cleanup circ/stats.pl
Use elsif and else. FIXME's added.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Fri, 22 May 2009 01:37:48 +0000 (20:37 -0500)]
Cleanup C4/Stats.pm
Use C4::Debug. Remove $sth->finish and an unconditional warn.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Michael Hafen [Thu, 13 Nov 2008 23:19:05 +0000 (16:19 -0700)]
followup to patch by Galen - add javascript to prevent premature submission of forms in Fines pages
Adds javascript to the manual invoice and manual credit pages to prevent
the premature submission of these forms when using a barcode scanner.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Thu, 21 May 2009 20:03:57 +0000 (15:03 -0500)]
bug 2897: fix English sample notices
Same as Joe's prior 2897 patch, but applied to the English
sample_notices.sql - due to a Git merge and rename detection
oddity, his original submitted patch was applied to the French
sample_notices.sql. Since the two files are
currently identical, no problem in the end.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Thu, 21 May 2009 19:26:02 +0000 (14:26 -0500)]
bug 2726: updated doc to explain auth_by_bind option
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Michael Hafen [Wed, 29 Oct 2008 19:48:04 +0000 (13:48 -0600)]
in Auth_with_ldap.pm try binding with user password or compare
This changes the checkpw code in Auth_with_ldap. Along with comparing
the user entered password against the directory attibute userPassword
you can try to bind with the users dn and password.
This is controlled by the option auth_by_bind, which, if set, causes
this code to try binding instead of comparing.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
MJ Ray [Thu, 21 May 2009 14:27:20 +0000 (15:27 +0100)]
bug 2287: use defaults when needed even if CSV has correct number of columns
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Thu, 21 May 2009 14:00:09 +0000 (09:00 -0500)]
clean up redundant test
Credit to Joe Atzberger for cathing this.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Tue, 19 May 2009 11:54:50 +0000 (13:54 +0200)]
(bug #3235) improve searchorder
If an supplierid is provided with a ordernumber, the search should be able to return everytime a record. This patch do the job.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Nahuel ANGELINETTI [Tue, 19 May 2009 09:53:50 +0000 (11:53 +0200)]
(bug #3149) fix searchorder
this patch fix the searchorder function, and add to the SQL query a "AND biblionumber" statement if a biblionumber is speficied.
Sometimes C4::Acquisitions::searchorder() find more than one result, so the user is looping to the same page to choose the great record, adding a contraint to biblionumber allows to be more strict.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Wed, 20 May 2009 16:56:26 +0000 (11:56 -0500)]
More cleanup on returns.pl
Removed unused variable. Corrected comments.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Wed, 20 May 2009 21:55:09 +0000 (16:55 -0500)]
Cleanup and enhance bookcount.pl and .tmpl
Eliminated bug with date handling outputting an English string.
Row striping added. Highlight for "my branch" row added.
GetBranchesLoop used instead of recreating data structure, so we get the
benefit of branches being sorted (by display name).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Wed, 20 May 2009 19:39:03 +0000 (14:39 -0500)]
Add onlymine helper function.
This should allow scripts to use GetBranchesLoop without having to reproduce
the check for:
(1) IndependantBranches,
(2) User logged in,
(3) User Not superlibrarian, and
(4) User branch set.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Thu, 21 May 2009 12:46:34 +0000 (07:46 -0500)]
more permissions fixes on uk-UA installer SQL files
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Galen Charlton [Thu, 21 May 2009 11:52:59 +0000 (06:52 -0500)]
fixed permissions on ru-RU and uk-UA installer SQL files
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Andrei V. Toutoukine [Thu, 21 May 2009 08:42:24 +0000 (12:42 +0400)]
Bug: Importing sample data removes marcflavour variable (ru-RU)
modified: installer/data/mysql/ru-RU/mandatory/system_preferences_optimal.sql
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Andrei V. Toutoukine [Thu, 21 May 2009 08:42:23 +0000 (12:42 +0400)]
import of the authorized values fails on the step 3 of the web-installation (ru-RU)
ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 1
modified: installer/data/mysql/ru-RU/authorised_values/authorised_values_[DAMAGED].csv.sql
modified: installer/data/mysql/ru-RU/authorised_values/authorised_values_[LOST].csv.sql
modified: installer/data/mysql/ru-RU/authorised_values/authorised_values_[NOT_LOAN].csv.sql
modified: installer/data/mysql/ru-RU/authorised_values/authorised_values_[RESTRICTED].csv.sql
modified: installer/data/mysql/ru-RU/authorised_values/authorised_values_[STACK].csv.sql
modified: installer/data/mysql/ru-RU/authorised_values/authorised_values_[WITHDRAWN].csv.sql
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Andrei V. Toutoukine [Thu, 21 May 2009 08:42:22 +0000 (12:42 +0400)]
Bug 3107. Creation of `permissions` table fails during the web-installation (ru-RU)
ERROR 1452 (23000) at line 3: Cannot add or update a child row: a foreign key constraint fails (`koha/permissions`,
CONSTRAINT `permissions_ibfk_1` FOREIGN KEY (`module_bit`) REFERENCES `userflags` (`bit`) ON DELETE CASCADE ON
UPDATE CASCADE)
renamed: installer/data/mysql/ru-RU/mandatory/permissions.sql -> installer/data/mysql/ru-RU/mandatory/userpermissions.sql
renamed: installer/data/mysql/ru-RU/mandatory/permissions.txt -> installer/data/mysql/ru-RU/mandatory/userpermissions.txt
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Joe Atzberger [Tue, 19 May 2009 18:23:49 +0000 (13:23 -0500)]
Cleanup returns, consolidate some repeated logic.
Use one $userenv_branch instead of many calls to C4::Context->userenv->{'branch'}
for comparisons. Script is not warnings safe yet, but getting closer.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>