In databases where biblionumber is not necessarily
the same as biblioitemnumber, the title of
certain hold requests displayed by moremember.pl
could be drawn from the wrong record.
Ryan Higgins [Thu, 11 Sep 2008 19:31:05 +0000 (14:31 -0500)]
Remove acquisitions permission requirement on catalogue/showmarc.pl
This script is linked to from z39.50 search as well as acquisitions.
cataloguing/z3950_search.pl requires only the 'catalogue' flag, so
requiring only that permission here. A user without acquisitions permissions
would get a login instead of the record display without this change.
Owen Leonard [Wed, 10 Sep 2008 19:02:20 +0000 (14:02 -0500)]
Some formatting fixes for bookcount.tmpl and issuehistory.tmpl. Linking to moredetail.pl from issuehistory.pl (just as barcode on detail.pl links to moredetail.pl).
Owen Leonard [Tue, 9 Sep 2008 15:26:40 +0000 (10:26 -0500)]
A few more en-US spelling corrections; Markup corrections; Standardizing on "email" instead of "e-mail"; Copying isbn-formatting from opac-detail.pl to detail.pl;
bug 2585: fix search links for names (XSLT OPAC display)
Fix malformed OPAC search syntax that caused this bug:
When using the default stylesheet for MARC21 XSLT OPAC details display, the
search links for name headings (from 100, 700, 710, 710, 111, and 711) that are
linked to authority records don't work. When the user clicks on such a link,
they are directed to the advanced search form instead of the search results.
Danny Bouman [Thu, 4 Sep 2008 15:50:58 +0000 (11:50 -0400)]
bug2580: category name and home library will now correctly display on all patron tabs
This patch fixes several improperly named variables and includes the home library variable on the pages that were missing it. The category
description was added to the GetMemberDetails function since a couple of the pages using that function required the variable.
Michael Hafen [Thu, 28 Aug 2008 20:58:21 +0000 (14:58 -0600)]
bugfix: need to return something if an itemtype doesn't have an image
I noticed that on the search pages if an itemtype doesn't have an image it's information doesn't make it out the the template. I don't understand why, but this fixes it.
Internet Explorer seems to have a problem with JS array and object constructors that have a comma at the end. There may be other JavaScript files that have this problem.
Joe Atzberger [Wed, 3 Sep 2008 20:49:54 +0000 (15:49 -0500)]
HTML validation adjustments to about.pl
Corrects the Tidy errors:
line 428 column 19 - Error: "tr" not finished but containing element ended
line 428 column 19 - Error: end tag for "tr" omitted, but OMITTAG NO was specified
line 426 column 25 - Info: start tag was here
line 452 column 31 - Error: end tag for "strong" omitted, but OMITTAG NO was specified
line 452 column 12 - Info: start tag was here
line 518 column 17 - Error: document type does not allow element "ul" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag
line 525 column 17 - Error: document type does not allow element "ul" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag
Galen Charlton [Thu, 28 Aug 2008 13:46:04 +0000 (08:46 -0500)]
bug 2568: set default value of intranetuserjs to blank
The intranetuserjs syspref allows a Koha administrator
to insert arbitrary JavaScript into the staff page header.
Now that this syspref is functional again, this patch
changes the installation scripts so that the default
value is blank - any JavaScript we ship with Koha should
be in the templates, not in a syspref.
Documentation changes: none per se. However, I do want to
point out that the intranetuserjs syspref is a bit of a
dangerous one - enter a value with incorrect syntax, and
you could make it difficult to access the staff interface -
and should probably be marked as an advanced option.
Joe Atzberger [Tue, 26 Aug 2008 03:57:01 +0000 (22:57 -0500)]
Fines fixes: apparent problems with fines prevent processing.
CalcFine returned values that mismatched expectations in fines.pl.
fines.pl refactored: added debugging, prevent needless recreation of
Calendar objects by storing them in hash by branch.
Still outstanding problems with fines, including the output of a field
that has no other references in Koha (so is always undef) and the
incorrect description of FinesMode.
Calendar exported "new" erroneously. I also cleaned up the queries to
avoid needlessly compiling additional statement handles.
Please test and consider application to 3.0 maintenance.
Galen Charlton [Mon, 25 Aug 2008 17:13:38 +0000 (12:13 -0500)]
bug 2552: correct issue history display
The loan history for a bib can be incorrect if the bib's
biblioitemnumber is not the same as its biblionumber.
This was due to a bad join in GetBiblioIssues().
Credit to Michael Hafen for patching a similar bug,
which inspired me to check for other bad joins.
Owen Leonard [Wed, 30 Jul 2008 13:24:20 +0000 (08:24 -0500)]
Fix for Bug 2424: Altering layout of advanced search screen to make it compatible with Internet Explorer 6. Documentarians: this will require an updated screenshot.
Galen Charlton [Fri, 22 Aug 2008 00:59:45 +0000 (19:59 -0500)]
bug 2545: fix XSLTDetailsDisplay
Corrected so that when XSLTDetailsDisplay is ON but
XSLTResultsDisplay is OFF, the portion of the OPAC bib
details page that's derived from the MARC bib record
is no longer missing.
Jesse Weaver [Wed, 20 Aug 2008 18:21:50 +0000 (13:21 -0500)]
fix for bug 1771: Template errors with remote itemtype image
This adds a new function, getitemtypeimagelocation, that returns the image
unmodified for absolute urls and returns the proper intranet or opac path
otherwise. It also updates all of the relevant files to use that function.
Jesse Weaver [Tue, 19 Aug 2008 19:01:23 +0000 (14:01 -0500)]
fix for bug 2477: Improve Speed of the Shelf Browser
This patch updates the queries for the shelf browser in opac-detail.pl for a
slight performance gain. It also adds a param for dateformat to C4::Auth to
fix a warning.
Andrew Moore [Fri, 15 Aug 2008 18:17:14 +0000 (13:17 -0500)]
Bug 2524: improving the submitted test reports
switching from 'prove' to 'perl' to run the test scripts when we're preparing
them to be submitted to smolder. Prove adds an additional summary at the end
of the test run which confuses the TAP parser in smolder. It thinks that an
additional test has been run, and it fails it.
Then, I added a '-' before the command in the Makefile. THat's so that even
if 'perl' returns a failing code (because some tess failed), the rest of the
rules are run and a report gets submitted. Othewise, only passing reports
get sent.
Andrew Moore [Fri, 15 Aug 2008 13:41:28 +0000 (08:41 -0500)]
Bug 2524: Adding script to submit test reports to smolder server
This patch adds a target in the t/Makefile and a script in t/smolder_smoke_signal
to submit the results of test runs to a smolder server. It will allow users to submit
their own test results to a central location by running "make submit" from the t/
directory.
Smolder is a web-based application that aggregates and presents the output of
tests. We have an instance running at:
http://arwen.metavore.com:8000/app/public_projects/smoke_reports/1
More information about using smolder for Koha is available at:
http://wiki.koha.org/doku.php?id=en:development:smoke_reports
I intend to have the test suite run each night automatically and the results
sent to the smolder server. This will help us keep track of the current state
of the the code and possibly catch bugs introduced by changes. I encourge others
to submit their own test results if they want, especially if they are on an unusual
platform or are with a non-standard configuration.
Jesse Weaver [Thu, 14 Aug 2008 18:08:47 +0000 (13:08 -0500)]
Fix for bug 2155: duplicate checkin box on returns screen
This changes some css and markup to make the return box at the top not show when one is on the checkin screen. It also moves the markup for the autocompleting search box to its own file.
Joe Atzberger [Thu, 14 Aug 2008 18:52:39 +0000 (13:52 -0500)]
Prevent compilation errors from complex C4 import/export.
SIP code uses UNIVERSAL modules that do not tolerate the circular deps in
C4, specifically, in Auth.pm. Changing the order so that UNIVERSAL follows
the other imports is important to avoiding failures like:
perl -w -e 'use UNIVERSAL qw(can); use C4::Auth;'
"MarkIssueReturned" is not exported by the C4::Circulation module
This patch should resolve the problem earlier seen with Shelves too.
When placing a hold request from the staff interface,
now correctly indicate if the patron account has expired.
Prior to this patch, would warn that the account
had expired even when the expiry date is in the future,
and vice versa.
Joe Atzberger [Tue, 12 Aug 2008 20:56:28 +0000 (15:56 -0500)]
masthead - realign terminology for Tag Cloud
Tag Cloud should link to user-generated tags, in a cloud display.
What used to be called "Tag Cloud" (ISBD subject links for UNIMARC libraries)
should be called a "Subject ...". AFAICT it doesn't currently use a "cloudy"
display, so some other term might be more appropriate.
projects / koha.git / log