Auth_with_ldap: support non-RFC#2798 user IDs.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Context.pm - bugfix punctuation (; vs ,)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

authorities result lists where badly paged.

finalresult contained the whole list and not only the useful results.
resultlist contained only 19 elements. adding one
parameters passed through pages contained also empty parameters deleting them.
Conflicts:

C4/AuthoritiesMarc.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BiblioAddAuthorities : adding "" in search term, in case there is a ()

+ improving some tests
+ removing some comments

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

AddAuthority, adding 100 field for UNIMARC if it's not provided

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bug FIX : 437 'Browse Members' function should return paged results

Adding pagination_bar to results if needed.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removing some unnecessary lines

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix to delete a virtualshelf content correctly

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

NoZera don't handle fuzzy/stemming/weight

so ignoring those sysprefs

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

unimarc.abs change : defaulting author sorting to 700$a

instead of 200$f
+ some tab added to have something easier to read
Some libraries don't use authorities (700$a),
but they are usually small libraries, so won't be with zebra !

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

french translation, updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

moremember.pl - We will be doing a lot of debugging on Members, this is just the beginning.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Auth_with_ldap.pm -- Silly spelling errors in perldoc

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Acquisition - Dates.pm switch

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

rename ldap test file

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bugfix: restore setting classification source by dropdown

Apparently as an inadvertant result of the patches to
move the SQL files to load the MARC frameworks, the
authorised_value of 'cn_source' was dropped for
kohafield = 'items.cn_source' and 'biblioitems.cn_source'.

This patch restores those values, thus making the
classification source set by a dropdown in the bib
and item editors.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bugfix: do not try to set items.cn_sort twice

The way this API is used by additem.pl, the $item hasref
already contains a 'items.cn_sort' key whose value is
undef.  Setting $item->{'cn_sort'} instead of $item->{'items.cn_sort'}
ends putting with items.cn_sort and cn_sort in the UPDATE
items statement, making the final value of cn_sort in the DB
dependent on the order produced by Perl's keys function.

Also added a comment explaining a subtle (perhaps too subtle)
point in the code.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Visual improvements to facets and search results; better js handling of Amazon book covers in results and detail.tmpl.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixed nozebra opac advsearch Title search problem.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for BUG 1653

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding LCCN to z2950 searches: Part 2

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Setting BiblioAddsAuthorities OFF by default as things break when enabled in MARC21 libraries

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding LCCN to z2950 searches

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Formatting dialog in additem.tmpl, markup correction in request.tmpl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

A couple of patch corrections to remove hardcoded /prog/ path (allows for alternate templates). Also upgrading jquery to version 1.2.1.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More minor style changes, and markup fix for Bug 1321.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Some reformatting in circ and members.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for bug introduced recently if due_date is null, search failed

BugFix 1640

setting QueryFuzzy, QueryStemming and QueryweightFields systempreferences to 0 if Nozebra chosen

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding hotlink to author search on details.pl page.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed shell metacharacter from filename -- source of install glitch

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Wrapping patron image javascript in check for patronimage system pref

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing typo in value_builder/dateaccessioned.pl; Adding error message output to additem.tmpl (fixes Bug 1636, Can't delete from additems.pl).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Virtual shelves: per shelf sort, multiple add in OPAC, partial bug fixes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Add multiple items to virt shelf, and bugvix virtual shelf adds.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Clean up moredetail.pl and updateitem.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

get_template_and_user returns $flags from checkauth for in-page perms.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Add 'Staff' category_type to new dropdown, add category_type to GetMemberDetails retval

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Able to call haspermission w/o $dbh, and add error msg on deletemember.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding in permission blocks for staff members as per previous commits.

Much of this is repeat of previous commits, and then some to finish off.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Allow superlibrarian to change branch via header.inc

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

memberentry.pl - add $debug to prevent continual warn's.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

basket.pl - conditionalized w/ $debug 3 warnings that would otherwise fire every time!

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Log.pm and Suggestions.pm - simple (correct) Dates.pm integration

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Search.pm -- Dates.pm (the correct way) and remove hard coded (on) DEBUG variable!

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Circulation.pm - remove Date.pm dependency.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

moremember.tmpl - minor format cleanup (spaces after colons in labels)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

koha-news.tmpl - Cancel button still referenced "opac-news" instead of "koha-news"

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bugfix: catch ZOOM exceptions in simple Search.pm

Now warns and returns error value, instead of aborting
the calling CGI.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed 'delete from' statements

Did this because marc21_framework_DEFAULT.sql was the
only install SQL that did this, and thus led to a problem
when the web installer was loading the optional MARC 21
framework SQL before the mandatory one.  Because
of the 'delete from', deleted all of the optional rows.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed order in which SQL scripts are applied by web installer

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for ModZebra() trying to delete an existing bib - that doesnt exist, during an add.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Unimarc record.abs fixes : fixed fields and some lc added

+ Physical-detail changed to Extent
+ Thesis-note removed, as it's not standard UNIMARC (it's specific to one of our library, in2p3)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for itemtype in unimarc.abs

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for ISBN search in unimarc

+ removing link, that is not in bib1.att (retult in lot of warnings in zebra log)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for pub date in unimarc

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for Place-publication in unimarc

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for subject in unimarc.abs

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix to unimarc.abs for languages

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding Compress::Zlib dependancy

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

inverting explanation and options columns to have the same order everywhere

the file used to have explanation before options in the SQL dump, except the 6 last inserted lines.

I've inverted them to be as the other lines. Not a bugfix, but to avoid having a bug in some months due to the un-noticed difference...

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bugfix: made yuipath available to login page template

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Able to call haspermission w/o $dbh, and add error msg on deletemember.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding in permission blocks for staff members as per previous commits.

Much of this is repeat of previous commits, and then some to finish off.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix so ysearch.pl uses utf-8

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more cleanup

more cleanup

cleanup of letter.pl, 'my's need to be there

cleanup of admin/ after Dates integration

cleanup of misc/ for Dates integration

cleanup for catalogue/ dir Dates integration

cleanup of acqui/ for Dates, missing format_date

cleanup for serials and members for Dates

cleanup for opac/ Dates - missing format_date, etc.

cleanup of reports/ Dates - missing format_date, etc.

cleanup of tools/ after Dates ... missing format_date, etc.

cleanup of circ/ dir changes to Dates ... missing format_date

adding format_date to 'use C4::Date'

admin subdir - Dates.pm integration and warnings fixes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

reserve and virtualshelves (leftovers) - Dates.pm integration and warnings fixes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

misc subdir - Dates.pm integration and warnings fixes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

circ subdir - Dates.pm integration and warnings fixes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

cataloge subdir (and cataloguing) - Dates.pm integration and warnings fixes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

acqui subdir - Dates.pm integration and warnings fixes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

authorities subdir - Dates.pm integration and warnings fixes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

serials subdir - Dates.pm integration and warnings fixes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

members subdir - Dates.pm integration and warnings fixes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

labels subdir - Dates.pm integration and warnings fixes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

opac subdir - Dates.pm integration and warnings fixes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

reports subdir - Dates.pm integration and warnings fixes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

tools subdir - Dates.pm integration and warnings fixes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Unrecognized escape \d passed through at misc/bulkauthimport.pl line 28.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

label-home.pl - Fix major error causing deletion on every run. Corrected variable scope to avoid warnings.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Auth.pm should have "CAN_user_updatecharges" (plural), and this change to InstallAuth.pm should catch it.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Change to patron-renewal javascript to fix issues described in Bug 1620

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing typo in value_builder/dateaccessioned.pl; Adding error message output to additem.tmpl (fixes Bug 1636, Can't delete from additems.pl).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Moving "Check Out" from the action toolbar to the view menu

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing parameters permission requirement on about.pl, minor markup change to member-flags.tmpl.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Members.pm - respond to $debug, some formatting and reduction of duplicative code.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Auth.t - running this test will fail unless Auth.pm patches get trough.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>