Galen Charlton [Fri, 2 Jul 2010 14:56:15 +0000 (10:56 -0400)]
remove a bunch of unconditional debug warns
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 2 Jul 2010 12:47:22 +0000 (08:47 -0400)]
bug 4188: add note about hiding the OrderPdfTemplate syspref
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 2 Jul 2010 12:39:46 +0000 (08:39 -0400)]
bug 4188: move PDF templates for printed purchase orders
The PDF templates for purchase orders now live in the
directory koha-tmpl/intranet-tmpl/prog/pdf to separate
them from code. As no automatic translation system for
PDF files is currently implemented, I'm keeping them out
of the language subdirectories for now.
At present, there are two choices of templates for printing
purchase orders (AKA basket groups), controlled by setting
the OrderPdfFormat syspref:
pdfformat::layout2pages (two-page layout)
pdfformat::layout3pages (three-page layout)
To customize a template or to add a new one requires two steps:
* modifying the PDF; note that OpenOffice source files
are included as a way of generating the PDF
* modifying the code in acqui/pdfformat/layout*.pm to
position the order text onto the template
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 2 Jul 2010 12:19:14 +0000 (08:19 -0400)]
remove extraneous warns
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Frédéric Demians [Sun, 18 Apr 2010 09:53:34 +0000 (11:53 +0200)]
Bug 4188 Allow acq basket group printing into PDF
Since new acquisition module workflow and specifications is not
documented, this fix is more an hypothesis than a patch.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Robin Sheat [Fri, 2 Jul 2010 00:55:46 +0000 (12:55 +1200)]
bug4929 - amended the instructions
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Thu, 1 Jul 2010 23:37:30 +0000 (19:37 -0400)]
bug 2434: set DBrev to 142
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Tue, 29 Jun 2010 10:22:29 +0000 (06:22 -0400)]
bug 2434 followup patch to remove EVENT from message_transports
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Robin Sheat [Thu, 1 Jul 2010 05:41:33 +0000 (17:41 +1200)]
bug4926 - Improves the ID fields when sending lists and carts
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Katrin Fischer [Mon, 28 Jun 2010 20:49:43 +0000 (22:49 +0200)]
Bug 4915: Remove renewalsallowed from sample_itemtypes.sql
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Katrin Fischer [Mon, 28 Jun 2010 20:11:37 +0000 (22:11 +0200)]
Correct typo in German sample news
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Fri, 25 Jun 2010 16:59:15 +0000 (12:59 -0400)]
Fix for Bug 3683 - 'Sort by' column in list interface is not translatable
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Fri, 25 Jun 2010 16:26:39 +0000 (12:26 -0400)]
Fix for Bug 3372 - OPAC Reading History sorting breaks limit
Some other cosmetic and functional changes:
- "Show all/Show 50" links had been styled as tabs at some time
in the past. A CSS change somewhere broke this. Reimplementing it.
- Moving sort control to a <select> similar to the one used on
search results. Since javascript-based table sorting from the
table header is used elsewhere in the OPAC I felt the <select>
method better reflected the behavior of this re-sort.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Fri, 25 Jun 2010 13:48:20 +0000 (09:48 -0400)]
Fix for Bug 4909 - extra > in path on contracts pages
The logic for displaying a useful title did not take all
cases into account. This patch adds the missing case.
The patch also fixes problems with the "Cancel" link
on update and delete operations.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Fri, 25 Jun 2010 09:46:51 +0000 (10:46 +0100)]
Bug 4911 Remove duplicated code
Two duplicated subroutine definitions removed
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 25 Jun 2010 09:42:15 +0000 (05:42 -0400)]
remove byte order mark (BOM) from installer SQL files
The precence of a BOM can prevent an SQL script from being
run.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 25 Jun 2010 09:32:33 +0000 (05:32 -0400)]
bug 2434: assign to DBrev 141
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Wed, 2 Jun 2010 12:19:08 +0000 (08:19 -0400)]
bug 2434 remove upcoming events for all languages
this patch removed the upcoming events messaging option
and the upcoming event message from the system for all
languages since it was never implemented and confuses
librarians and patrons alike
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Fri, 25 Jun 2010 08:59:37 +0000 (10:59 +0200)]
(MT #3651) Fix problems on search filters.
removing of useless value "no tabs" in organize by combo.
removing of useless value "Sort 1" in organize by combo.
Adding combodate for suggesteddate, manageddate, accepteddate.
Adding research on dates in query.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Fri, 25 Jun 2010 08:59:36 +0000 (10:59 +0200)]
(MT #3651) Fills "book fund" combobox with bugdets and fix some bugs of research by filter.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 25 Jun 2010 09:16:16 +0000 (05:16 -0400)]
replace references to defunct info email address
Now links to Koha project website.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 25 Jun 2010 09:03:11 +0000 (05:03 -0400)]
remove old revision history notes from a couple files
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 25 Jun 2010 00:55:49 +0000 (20:55 -0400)]
bug 4312: DBrev = 140
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Wed, 23 Jun 2010 07:50:34 +0000 (03:50 -0400)]
bug 4312 change default for tagsmoderation to 0 from NULL
resending with fixes
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Thu, 24 Jun 2010 17:26:21 +0000 (19:26 +0200)]
(BUG #4857) aqplan.pl: consideration of Planning categories with authorised values
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Thu, 24 Jun 2010 17:26:18 +0000 (19:26 +0200)]
MT3652 : Unifying the search of neworder with Search
This patch unifies the search in neworder so that the same biblios should be sent back when searching from catalogue search or from box.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Thu, 24 Jun 2010 17:26:17 +0000 (19:26 +0200)]
(BUG #4811) suggestion.pl: display borrowers name in suggestion information filters (Suggested By, Managed by, Accepted by)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Thu, 24 Jun 2010 17:26:16 +0000 (19:26 +0200)]
(BUG #4810) parcel.pl: Fix a bug with applying a filter on pending orders displaying
When we apply a filter and click on "Click here to show x items" link, there are duplicates orders which are display.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Thu, 24 Jun 2010 17:26:15 +0000 (19:26 +0200)]
(bug #4523) possibility to show / hide the filters menu
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Frédéric Demians [Thu, 24 Jun 2010 19:13:46 +0000 (21:13 +0200)]
Bug 3217 Impossible to change biblio record FW to Default
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Thu, 24 Jun 2010 17:26:11 +0000 (19:26 +0200)]
(MT2371) basket.tmpl, in basket details, change Open on => Opened on
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Thu, 24 Jun 2010 17:26:12 +0000 (19:26 +0200)]
(BUG #4356) Basket.pl: adding a link to the basketgroup
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Thu, 24 Jun 2010 17:26:14 +0000 (19:26 +0200)]
(BUG #4521) aqbudgets.pl - Transform undefined budget spent value to 0.00 value
This patch tranform the undefined value of budget spent to a money value which equals 0.00.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Jean-André Santoni [Thu, 24 Jun 2010 17:26:13 +0000 (19:26 +0200)]
Select in budget add forum
Sorted the branches select.
Modified display to "branchcode - branchname"
Fixed a bug, selection was inverted.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Thu, 24 Jun 2010 14:57:21 +0000 (15:57 +0100)]
Bug 4905 Runtime errors in about.pl
Calls to VERSION were generating errors when called on a string.
Use a bit of sleight of hand to avoid this
Added a couple of tests on Installer/PerlModules
Module needs better coverage testing (esp on newer perls)
Sorted to list of modules to make koha_perl_deps.pl more
human-friendly
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 23 Feb 2010 20:09:46 +0000 (15:09 -0500)]
fix two broken calls to _FixPriority
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Mon, 22 Feb 2010 03:22:43 +0000 (22:22 -0500)]
bug 3344: display in-transit status on holds priority list
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Mon, 22 Feb 2010 02:49:09 +0000 (21:49 -0500)]
bug 4224: explicitly mark hold requests as being handled by item in transit
This patch defines a new values of reserves.found, 'T', to indicate that
an item has been allocated to fill a hold request and is currently
in transit from one branch to another. This explicit value is meant
to filter out hold requests from processing by holds queue batch
job.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Wed, 19 May 2010 15:47:37 +0000 (11:47 -0400)]
Fix for Bug 4532, Use include file for bibliodefaultview logic
Note that this new include builds only the first half of the
anchor tag (<a>). Because title and subtitle are output differently
on some pages, rendering of the second half of the tag is left
to individual pages.
Includes fixes for staff client templates.
Change to basket.pl fixes a bug wherein the OPAC's bibliodefaultview
preference was being checked instead of the staff client's.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Thu, 27 May 2010 19:53:41 +0000 (15:53 -0400)]
Fix for Bug 4821, With multiple 5XX fields, the font display gets progressively smaller
Prevent the generation of empty label spans for various
bib details fields. A construct like
<span class="results_summary"><span class="label" />contents note</span>
is consistently misinterpreted in many web browsers, leading to
CSS oddities. See the bug for more details.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Fri, 28 May 2010 18:50:30 +0000 (14:50 -0400)]
Partial fix for Bug 4423, Staff Client XSLT is just a copy of the OPAC one
This patch improves the template logic specifying a layout
based on whether the display is XSLT or normal, and whether
Amazon Content is on or off. Previously XSLT view did not
display Amazon covers when enabled.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Wed, 2 Jun 2010 19:17:37 +0000 (15:17 -0400)]
More fixes for Bug 4423, Staff Client XSLT is just a copy of the OPAC one
- Adding material type icons from the OPAC side
- Adding OPAC View link
- Copying revised handling of MU from the OPAC
- Removing OPAC-specific markup
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Fri, 4 Jun 2010 14:53:20 +0000 (10:53 -0400)]
Followup fix for Bug 4453: Removing invalid template fragment.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Fri, 4 Jun 2010 16:49:19 +0000 (12:49 -0400)]
Fix for Bug 4278, canceling vendor add refreshes wrong
Patch corrected to follow HDL's suggestion that link check
for existing vendor id and conditionally redirect based
on that.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Tue, 8 Jun 2010 19:16:30 +0000 (15:16 -0400)]
Fix for Bug 3895 - Menu on left of Contracts is for Admin Pages
- Also adding cancel link to the add/edit view
- Also adding message when there are no contracts to list
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Thu, 10 Jun 2010 17:28:28 +0000 (13:28 -0400)]
Fix for Bug 4886, missing 404 redirection on wrong biblionumber for MARC and ISBD details
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Thu, 10 Jun 2010 17:09:14 +0000 (13:09 -0400)]
Fix for Bug 4884, opac-showmarc.pl can't find compact.xsl
This patch implements Fridolyn SOMERS' suggested change
to the .xsl file path but copies compact.xsl from the
intranet template dir and points to that instead.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Tue, 8 Jun 2010 19:43:35 +0000 (15:43 -0400)]
Fix for Bug 4859, Formatting cleanup for merge biblio record interface
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Thu, 10 Jun 2010 18:14:26 +0000 (14:14 -0400)]
Fix for Bug 4869 - Non-staff patrons logging into the OPAC don't have option to place holds from Public Lists
The template was originally designed so that form controls were
hidden from users who didn't have permission to modify a particular
shelf because the form controls were only used for deleting from
lists. Now that users can place holds and add tags via the check-
boxes, the controls must be available to all users.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Wed, 23 Jun 2010 16:15:49 +0000 (18:15 +0200)]
Bug3916 : Batch Modify tool overwrites branches fields
This was owed to the Item modification construction and the change in GetBranchesLoop behaviour which selects the user branch by default.
Adding a void branch selected
Changing default value to ""
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Katrin Fischer [Tue, 22 Jun 2010 05:22:54 +0000 (07:22 +0200)]
Bug 4474 swap options for sys pref singleBranchMode
Resend with corrected spelling.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Katrin Fischer [Mon, 21 Jun 2010 21:09:41 +0000 (23:09 +0200)]
Bug 4902: Add missing b_phone and b_email to borrower details
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nicole Engard [Mon, 21 Jun 2010 14:32:21 +0000 (10:32 -0400)]
bug 4900: add in missing value for usedaysmode pref
The usedaysmode preference was missing the option to
calculate due date by finding the next open date on the
calendar instead of ignoring all days the library is
closed.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Mon, 21 Jun 2010 01:50:50 +0000 (21:50 -0400)]
Bug 4897: Invalid XHTML in opac-userupdate.tmpl.
Removes several duplicate name tags.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sat, 19 Jun 2010 19:56:07 +0000 (15:56 -0400)]
fixes to xt/sysprefs.t test case
* use root of source tree as base directory
* ignore case when comparing system preference codes;
at present this is also case-insenstive in the database
* added German sysprefs file
* corrected paths to Russian and Ukrainian system preference files
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sat, 19 Jun 2010 19:51:25 +0000 (15:51 -0400)]
fixed permissions for item batch deletion and modification for French
Solves bug where granular permissions for batch deletion and modification
would not work correction for a fresh installation using the French
translation.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sat, 19 Jun 2010 19:48:28 +0000 (15:48 -0400)]
fixed problems in xt/permissions.t test case
* now looks for permissions SQL files in the current
source tree, not in intranetdir; tests in xt/ and
t/ are meant to be run without requiring a full Koha
installation
* added path to German
* fixed paths to permissions SQL for Russian and Ukrainian
* handles case where SQL script contains more than just
inserts into to permissions
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Katrin Fischer [Sat, 19 Jun 2010 13:20:15 +0000 (15:20 +0200)]
Bug 4895: Add missing granular permissions
Add missing granular permissions for serials to userpermissons.sql
de-DE, pl-PL
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sat, 19 Jun 2010 13:03:45 +0000 (09:03 -0400)]
set DBversion to 139
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Katrin Fischer [Thu, 17 Jun 2010 21:51:40 +0000 (23:51 +0200)]
Bug 3682: change message_attributes.message_name from varchar(20) to varchar(40)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Wed, 9 Jun 2010 18:46:37 +0000 (14:46 -0400)]
Fix for Bug 4868 - Improve controls for cloning and deleting MARC subfields
Changes "+" and "-" controls to actively linked images giving
better feedback about their clickability and an increased click
target area.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Tue, 8 Jun 2010 16:03:00 +0000 (12:03 -0400)]
Page structure correction, helps Bug 3850 (Page Need Design Work)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Ian Walls [Mon, 14 Jun 2010 14:26:09 +0000 (14:26 +0000)]
Fixes bug 3619: _send_message_by_email not respecting AutoEmailPrimaryAddress = 'OFF'
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Katrin Fischer [Thu, 17 Jun 2010 19:51:22 +0000 (21:51 +0200)]
BUG 4883: Staff - remove \n from strings for translation
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Katrin Fischer [Thu, 17 Jun 2010 19:51:21 +0000 (21:51 +0200)]
Bug 4833: OPAC - remove \n from strings for translation
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Katrin Fischer [Thu, 17 Jun 2010 20:46:47 +0000 (22:46 +0200)]
Bug 4895: Add missing granular permissions to ru-RU, uk-UA
Files are different from en files, combining userpermissions.sql and userflags.sql.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Katrin Fischer [Thu, 17 Jun 2010 20:46:46 +0000 (22:46 +0200)]
Bug 4895: Add missing granular permissions to de-DE, pl-PL
Added missing permissions, files are translations of en.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Sat, 12 Jun 2010 15:50:38 +0000 (11:50 -0400)]
But 4890: Fixes invalid XHTML in basket.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Sat, 12 Jun 2010 03:02:17 +0000 (23:02 -0400)]
Bug 4889: Fixes minor XHTML error in booksellers.tmpl.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Fri, 11 Jun 2010 01:53:56 +0000 (21:53 -0400)]
Bug 4827: Fixes library drop-down list in aqbudgets.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Sat, 19 Jun 2010 11:53:59 +0000 (07:53 -0400)]
bug 4896: granular permissions now always on (DB rev 138)
Per the following koha-devel thread, the use of
staff user subpermissions, AKA granular permissions, is
now the default behavior in Koha. This patch removes
the GranularPermissions system preference.
[1] http://lists.koha-community.org/pipermail/koha-devel/2010-February/033670.html
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Wed, 16 Jun 2010 04:42:14 +0000 (16:42 +1200)]
Follow up patch, removing missed conflict marker
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Wed, 16 Jun 2010 04:38:31 +0000 (16:38 +1200)]
Cherry-picked onto master, fixing conflicts: MT 1816: Granular permissions for the serials module
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Conflicts:
installer/data/mysql/en/mandatory/userpermissions.sql
installer/data/mysql/fr-FR/1-Obligatoire/userpermissions.sql
installer/data/mysql/updatedatabase30.pl
koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tmpl
serials/member-search.pl
serials/serials-edit.pl
serials/subscription-add.pl
serials/subscription-bib-search.pl
serials/subscription-detail.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Sat, 19 Jun 2010 08:14:22 +0000 (20:14 +1200)]
Missing indexes and a missing column
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Sat, 19 Jun 2010 08:02:29 +0000 (20:02 +1200)]
Missing tables in the kohastructure.sql table.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Liz Rea [Wed, 9 Jun 2010 18:27:35 +0000 (13:27 -0500)]
Changing <p> to <span> per gmcharlt's suggestion re: Adding <p class="noholdstext"> tag around the "No Holds Allowed" text to allow for jquery selection/replacement of the text.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Liz Rea [Wed, 26 May 2010 19:28:47 +0000 (14:28 -0500)]
Adding <p class="noholdstext"> tag around the "No Holds Allowed" text to allow for jquery selection/replacement of the text.
A later patch might come that changes the text entirely, as it does not match the OPAC, and is often confusing for staff.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Mon, 14 Jun 2010 22:01:54 +0000 (10:01 +1200)]
Bug 4472 - Missing / in img tags breaking xslt (and other img tags)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Chris Cormack [Tue, 15 Jun 2010 05:25:32 +0000 (17:25 +1200)]
Updated history file, 2 more committers
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Tue, 15 Jun 2010 17:42:18 +0000 (18:42 +0100)]
Fix depreciation warnings in acqui/z3950_search.pl
Perl generates depreciation warnings on compilation
caused by use of ambiguous syntax. Seemed that an
underlying confusion as to row's type
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Frédéric Demians [Fri, 4 Jun 2010 15:04:18 +0000 (17:04 +0200)]
Bug 2789 Fix UNIMAC leader plugin
The plugin was returning a 25 characters length leader rather than 24
characters. So leader was recreated automatically, removing user update,
before writing biblio record.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nahuel ANGELINETTI [Mon, 7 Jun 2010 09:09:19 +0000 (11:09 +0200)]
(bug #4853) change rights needed to renew loans
Use "circulate" right, instead of "borrower".
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Sat, 5 Jun 2010 22:29:40 +0000 (18:29 -0400)]
Bug 2505: Enabled warnings in patron-attr-types.pl
Fixed all resulting errors.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Andrew Elwell [Mon, 7 Jun 2010 14:12:18 +0000 (16:12 +0200)]
Final batch of POD cleanups.
Should fix any remaining warnings with 'podchecker'
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Andrew Elwell [Mon, 7 Jun 2010 10:06:44 +0000 (12:06 +0200)]
POD Cleanups
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Andrew Elwell [Sun, 6 Jun 2010 17:47:14 +0000 (19:47 +0200)]
More POD cleanups
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Andrew Elwell [Sat, 5 Jun 2010 21:17:11 +0000 (23:17 +0200)]
POD Cleanups - Few minor ones this time
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Andrew Elwell [Sat, 5 Jun 2010 21:17:10 +0000 (23:17 +0200)]
Another batch of POD cleanups
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Andrew Elwell [Sat, 5 Jun 2010 11:16:51 +0000 (13:16 +0200)]
The start of some POD cleanups in C4/*.pm
If these are acceptable I'll continue - target is to get rid of all warnings
and errors with podcheck and make sure that any man and html formatted pod
docs look 'OK'
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Wed, 9 Jun 2010 12:33:19 +0000 (08:33 -0400)]
applied paranoia
RM note: we've had our fun; next patch will be to trim
the comment to something that makes sense in context.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 8 Jun 2010 02:37:38 +0000 (14:37 +1200)]
Build with pdebuild, not debuild.
This checks build dependency declarations more thoroughly.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Fri, 4 Jun 2010 02:52:44 +0000 (14:52 +1200)]
Remove dependencies on perl-base.
perl-base is a required package, so it is always installed on a Debian
system, and Debian packages should not depend on it, unless they need
it a specific version, and I don't think we do.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Wed, 9 Jun 2010 11:14:15 +0000 (12:14 +0100)]
Bug #4864 Add SIPServer Perl Module Dependencies
SIPServer requires Net::Server and UNIVERSAL::require
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Fri, 4 Jun 2010 01:04:17 +0000 (21:04 -0400)]
set DBrev to 136 for previous patch to add edit_items
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Henri-Damien LAURENT [Thu, 27 May 2010 20:03:36 +0000 (22:03 +0200)]
MT2938 : Adds a permission for editing items
This patch adds a permission on edit_items
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Fri, 28 May 2010 14:49:46 +0000 (10:49 -0400)]
Fix for Bug 3081, Url's contain spaces
My investigation finds that the problem in Internet
Explorer was not with the spaces in the URL but
with the spaces in the "name" attribute of the pop-up
window. Converting spaces to underscores allows
the plugin links to work correctly.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Thu, 3 Jun 2010 17:54:21 +0000 (13:54 -0400)]
Fix for Bug 3770, 'Add to list' page only allows adding to private lists
This patch is a reformat of chad@pennmanor.net's submission to
the bug report on 2010-02-16.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Thu, 3 Jun 2010 17:37:33 +0000 (13:37 -0400)]
Fix for Bug 3722 - Branch deletion results in incorrect message
A fix was submitted by Nahuel on 23 Nov 2009 and pushed, but
it combined messages for existing patrons and existing items.
This patch defines separate messages for the various cases and
corrects a typo in the original fix which left existing patrons
unreported.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Thu, 3 Jun 2010 15:12:50 +0000 (11:12 -0400)]
Fix for Bug 3926, inadvertantly resurrected by me.
The template-side fix for Bug 3926 was overwritten by
another template change I submitted later. My bad.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Wed, 2 Jun 2010 18:45:18 +0000 (14:45 -0400)]
Fix for Bug 3992 - New Sys Prefs Branch - Local Use Tab not Highlighted
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>