]> git.koha-community.org Git - koha.git/log
koha.git
15 years agofollowup Amazon.pm bugfix fd4ed72988a0a00a97a9a74bd89b017453bb276b
Henri-Damien LAURENT [Thu, 17 Sep 2009 12:51:27 +0000 (14:51 +0200)]
followup Amazon.pm bugfix fd4ed72988a0a00a97a9a74bd89b017453bb276b

15 years agoBug Fixing Merge problem
Henri-Damien LAURENT [Thu, 17 Sep 2009 09:39:49 +0000 (11:39 +0200)]
Bug Fixing Merge problem

JS in moremember.tmpl was bogus

15 years agoTranslating unimarc_leader plugin in english
Henri-Damien LAURENT [Thu, 13 Aug 2009 13:07:03 +0000 (15:07 +0200)]
Translating unimarc_leader plugin in english

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoLanguage updates
Chris Cormack [Thu, 17 Sep 2009 07:30:42 +0000 (19:30 +1200)]
Language updates

15 years agoBug Fixing updatedatabase
Henri-Damien LAURENT [Thu, 17 Sep 2009 07:16:51 +0000 (09:16 +0200)]
Bug Fixing updatedatabase

15 years agoBug Fixing Amazon.pm would not compile
Henri-Damien LAURENT [Wed, 16 Sep 2009 16:36:40 +0000 (18:36 +0200)]
Bug Fixing Amazon.pm would not compile

missing call of C4::External::Amazon in opac-ISBDdetail.pl
@aws was not defined

15 years agoThe rest of the staff interface updated
Chris Cormack [Tue, 15 Sep 2009 07:12:45 +0000 (19:12 +1200)]
The rest of the staff interface updated

15 years agoArmenian staff updates
Chris Cormack [Tue, 15 Sep 2009 04:59:32 +0000 (16:59 +1200)]
Armenian staff updates

15 years agoMalaysian and Portuguese staff updates
Chris Cormack [Tue, 15 Sep 2009 04:58:22 +0000 (16:58 +1200)]
Malaysian and Portuguese staff updates

15 years agoStaff language updates
Chris Cormack [Tue, 15 Sep 2009 04:57:01 +0000 (16:57 +1200)]
Staff language updates

15 years agoValencian staff
Chris Cormack [Tue, 15 Sep 2009 04:55:44 +0000 (16:55 +1200)]
Valencian staff

15 years agoSerbian staff update
Chris Cormack [Tue, 15 Sep 2009 04:53:11 +0000 (16:53 +1200)]
Serbian staff update

15 years agoCzech staff updates
Chris Cormack [Tue, 15 Sep 2009 04:52:35 +0000 (16:52 +1200)]
Czech staff updates

15 years agoLast of the opac updates
Chris Cormack [Tue, 15 Sep 2009 02:48:52 +0000 (14:48 +1200)]
Last of the opac updates

15 years agoMore language updates
Chris Cormack [Tue, 15 Sep 2009 02:47:55 +0000 (14:47 +1200)]
More language updates

15 years agoMore language updates
Chris Cormack [Tue, 15 Sep 2009 02:41:20 +0000 (14:41 +1200)]
More language updates

15 years agoHindi, Tetun, Thai, Tagalog, Turkish, Urdu and Ukranian opac updates
Chris Cormack [Tue, 15 Sep 2009 02:37:49 +0000 (14:37 +1200)]
Hindi, Tetun, Thai, Tagalog, Turkish, Urdu and Ukranian opac updates

15 years agoSpanish, Persian and Galician opac updates
Chris Cormack [Tue, 15 Sep 2009 02:35:09 +0000 (14:35 +1200)]
Spanish, Persian and Galician opac updates

15 years agoFrench (France), French (Canada) and Hebrew opac updates
Chris Cormack [Tue, 15 Sep 2009 02:29:49 +0000 (14:29 +1200)]
French (France), French (Canada) and Hebrew opac updates

15 years agoAmharic, German and English NZ opac updates
Chris Cormack [Tue, 15 Sep 2009 02:28:40 +0000 (14:28 +1200)]
Amharic, German and English NZ opac updates

15 years agoDanish and Bulgarian opac updates
Chris Cormack [Tue, 15 Sep 2009 02:26:34 +0000 (14:26 +1200)]
Danish and Bulgarian opac updates

15 years agoBengali, Arabic and Azerbaijanian opac updates
Chris Cormack [Tue, 15 Sep 2009 02:24:16 +0000 (14:24 +1200)]
Bengali, Arabic and Azerbaijanian opac updates

15 years agoIndonesian opac updates
Chris Cormack [Tue, 15 Sep 2009 02:17:24 +0000 (14:17 +1200)]
Indonesian opac updates

15 years agoGreek Opac updates
Chris Cormack [Tue, 15 Sep 2009 02:16:24 +0000 (14:16 +1200)]
Greek Opac updates

15 years agoCzech and Catalan opac updates
Chris Cormack [Tue, 15 Sep 2009 02:14:19 +0000 (14:14 +1200)]
Czech and Catalan opac updates

15 years agoFinnish and Chinese updates
Chris Cormack [Tue, 15 Sep 2009 02:11:10 +0000 (14:11 +1200)]
Finnish and Chinese updates

15 years agoFixing some leftover conflict
Chris Cormack [Tue, 15 Sep 2009 02:09:01 +0000 (14:09 +1200)]
Fixing some leftover conflict

15 years agoFixing mess leftover from conflict
Chris Cormack [Tue, 15 Sep 2009 01:55:19 +0000 (13:55 +1200)]
Fixing mess leftover from conflict

15 years agoStarting work updating translations
Chris Cormack [Tue, 15 Sep 2009 01:49:44 +0000 (13:49 +1200)]
Starting work updating translations

15 years agoFixing record.abs for authorities and MARC21
Chris Cormack [Mon, 14 Sep 2009 21:32:18 +0000 (09:32 +1200)]
Fixing record.abs for authorities and MARC21

15 years agoMore fixes to the shelves test
Chris Cormack [Mon, 14 Sep 2009 08:17:43 +0000 (20:17 +1200)]
More fixes to the shelves test

15 years agoFixing the tests for VirtualShelves, still a bit more to do
Chris Cormack [Sun, 13 Sep 2009 17:52:19 +0000 (05:52 +1200)]
Fixing the tests for VirtualShelves, still a bit more to do

15 years agoGet rid of a few warnings in the bulkmarcimport script: C4/Biblio.pm, hunks #1, ...
Sébastien Hinderer [Thu, 3 Sep 2009 18:11:09 +0000 (20:11 +0200)]
Get rid of a few warnings in the bulkmarcimport script: C4/Biblio.pm, hunks #1, #2: a warning occurring in NoZebra configurations. C4/Biblio.pm hunk #3: warning occurring in Unimarc MARC flavour. misc/migration_tools/bulkmarcimport.pl hunk #1: warning occurring when no default format is specified on command-line with -m switch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2505: remove additional warning messages
Galen Charlton [Sat, 5 Sep 2009 23:50:51 +0000 (19:50 -0400)]
bug 2505: remove additional warning messages

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoenable warnings in overduerules.pl Call GetBranchesLoop instead of duplicating code...
Colin Campbell [Fri, 4 Sep 2009 13:14:01 +0000 (14:14 +0100)]
enable warnings in overduerules.pl Call GetBranchesLoop instead of duplicating code make countletters a count as it says check for definedness before doing string comparisons do as not to generate warnings

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobugfix breeding results of cataloging search has wrong id
Michael Hafen [Tue, 1 Sep 2009 16:03:37 +0000 (10:03 -0600)]
bugfix breeding results of cataloging search has wrong id

The breeding id, rather than coming from the database, was set by a counter.
Not so good links in the search results that way.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug Fixing 3568 : Untranslated strings
Henri-Damien LAURENT [Tue, 1 Sep 2009 08:34:08 +0000 (10:34 +0200)]
Bug Fixing 3568 : Untranslated strings

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoSquashing Merge Fix and followup: renamed _GetCirculationBranch
Henri-Damien LAURENT [Thu, 10 Sep 2009 14:59:14 +0000 (16:59 +0200)]
Squashing Merge Fix and followup: renamed _GetCirculationBranch

Merge Fix Followup to 7e2bf9e

15 years agobug 3204: tweaks to AWS request signing
Galen Charlton [Thu, 13 Aug 2009 13:25:34 +0000 (09:25 -0400)]
bug 3204: tweaks to AWS request signing

* Add AWSPrivateKey system preference to the
  Enhanced Content tab in the syspref editor
* Now warns to log if attempting to use
  the Amazon API without setting AWSPrivateKey

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3204: add AWSPrivateKey syspref (DBrev 04.15)
Henri-Damien LAURENT [Thu, 10 Sep 2009 14:34:30 +0000 (16:34 +0200)]
bug 3204: add AWSPrivateKey syspref (DBrev 04.15)

The AWSPrivateKey syspref is describe more fully
in a previous commit, but to summarize, it should
contain the Amazon Web Services Secret Access Key
required by Amazon to sign requests to their
Product Advertising API.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 3204: followup to fix AWS request signing
Galen Charlton [Thu, 13 Aug 2009 12:55:25 +0000 (08:55 -0400)]
bug 3204: followup to fix AWS request signing

[1] There were some ersataz spaces in the string
    being signed.
[2] AWS expects a trailing '=' in the Base64 signature

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agobug 3204: implement request signing for Amazon Web Services
Henri-Damien LAURENT [Tue, 7 Jul 2009 13:44:26 +0000 (15:44 +0200)]
bug 3204: implement request signing for Amazon Web Services

After 2009-08-15, Amazon Web Services will expect that
all requests to the Product Advertising API, which is what
Koha uses for retrieving reviews and other enhanced content
from Amazon, include signatures.  This patch and
subsequenct patches implement this functionality.

What this means in practice (assuming the user has elected
to use any enhanced content from Amazon) is that

[1] The user must get a Amazon Secret Access Key.  This can
    be done by logging in to the user's AWS account
    at (e.g.) http://aws.amazon.com/, going to the 'Access Identifiers'
    page, and from there retrieving and/or creating a new Secret
    Access Key.

[2] The contents of the Secret Access Key should then be
    entered into the new AWSPrivateKey system preference.

Once that is done, grabbing reviews and table of contents from Amazon
should work as normal.  If the user doesn't do this before 2009-08-15,
reviews and TOCs will no longer be supplied from Amazon, although there
should be no crashes - the content will simply not show up.

Note that the requirement to sign requests does *NOT* appear to apply
to simply displaying book covers from Amazon.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCorrecting some selectors to conform with upgraded jQuery syntax (see Bug 3297).
Henri-Damien LAURENT [Wed, 9 Sep 2009 21:46:31 +0000 (23:46 +0200)]
Correcting some selectors to conform with upgraded jQuery syntax (see Bug 3297).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3532 show lost, damaged statuses on patron record
Henri-Damien LAURENT [Wed, 9 Sep 2009 21:42:58 +0000 (23:42 +0200)]
Bug 3532 show lost, damaged statuses on patron record

The patron record Details tab list of checkouts does not show lost, long overdue, claims returned, or damaged status, only that an item is overdue.  Added a check for lost and damaged statuses and a display of any matching statuses to the patron Details tab.

(revised version to drop unneeded lines from moremember.tmpl file)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago[replaceprevious](bug #3562) fix returning document in another branch
Henri-Damien LAURENT [Wed, 9 Sep 2009 21:23:06 +0000 (23:23 +0200)]
[replaceprevious](bug #3562) fix returning document in another branch

there is no transfert alert if you make a return in another branch than the homebranch.

15 years agoFixing merge on moremember.pl (Deletion when IndependantBranches)
Henri-Damien LAURENT [Wed, 9 Sep 2009 07:10:48 +0000 (09:10 +0200)]
Fixing merge on moremember.pl (Deletion when IndependantBranches)

15 years ago(bug #3459) fix opac-topissue to take care of ccode
Nahuel ANGELINETTI [Fri, 31 Jul 2009 15:05:27 +0000 (17:05 +0200)]
(bug #3459) fix opac-topissue to take care of ccode

This bugfix, add a conditionnal sql request, that get the "ccode" document type if AdvancedSearchTypes is positionned to ccode.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years ago(bug #2829) fix some mistakes extracting editor segment
Nahuel ANGELINETTI [Wed, 19 Aug 2009 13:22:24 +0000 (15:22 +0200)]
(bug #2829) fix some mistakes extracting editor segment

This patch fix how to extract the editor segment, and improve ISBN10/13 support.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoRemoving memberofinstitution management
Henri-Damien LAURENT [Mon, 31 Aug 2009 08:58:11 +0000 (10:58 +0200)]
Removing memberofinstitution management

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoBug Fixing 3542 : searching for authority in cataloguing
Henri-Damien LAURENT [Thu, 20 Aug 2009 15:18:24 +0000 (17:18 +0200)]
Bug Fixing 3542 : searching for authority in cataloguing

There was a problem in the query building
and PERL is quite picky with empty data in arrays so setting empty elements to undef

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoBug 2505: Enabled warnings in opac-topissues.pl
Garry Collum [Fri, 14 Aug 2009 00:31:39 +0000 (20:31 -0400)]
Bug 2505: Enabled warnings in opac-topissues.pl

Fixed resulting warnings and fixed a small bug with the timeLimit drop-down box.  It would not retain its value on subsequent pages if 'no Limit' was selected as an option.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoCleanup after conflicted merge
Chris Cormack [Tue, 8 Sep 2009 21:34:53 +0000 (09:34 +1200)]
Cleanup after conflicted merge

15 years agoFixing syntax error in C4/Circulation.pm
Chris Cormack [Tue, 8 Sep 2009 21:32:46 +0000 (09:32 +1200)]
Fixing syntax error in C4/Circulation.pm

15 years agoShowing "more searches" menu options when JavaScript is disabled (Bug 3517)
Owen Leonard [Mon, 10 Aug 2009 18:54:48 +0000 (13:54 -0500)]
Showing "more searches" menu options when JavaScript is disabled (Bug 3517)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoCleanup docs, typos, style etc.
Joe Atzberger [Fri, 7 Aug 2009 18:54:10 +0000 (13:54 -0500)]
Cleanup docs, typos, style etc.

Unused variable removed.  Weirdness with empty position in
assignment list also removed.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoFix Maintenance page.
Joe Atzberger [Fri, 7 Aug 2009 18:40:54 +0000 (13:40 -0500)]
Fix Maintenance page.

Without this, the mainenance page would not display because of:
Cannot use undefined value as a HASH reference in C4/Auth.pm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCorrecting validation errors.
Henri-Damien LAURENT [Tue, 8 Sep 2009 20:51:58 +0000 (22:51 +0200)]
Correcting validation errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofixed table row highlighting CSS class
Galen Charlton [Wed, 24 Jun 2009 14:09:27 +0000 (09:09 -0500)]
fixed table row highlighting CSS class

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix the previous patch to add a syspref that permit to choose the renewal period...
Nahuel Angelinetti [Fri, 6 Mar 2009 10:38:04 +0000 (11:38 +0100)]
fix the previous patch to add a syspref that permit to choose the renewal period(day or date_due).

This patch just check the syspref and use it as base date of renew.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3173 Place Hold link visible in OPAC even if syspref turned off
Henri-Damien LAURENT [Tue, 8 Sep 2009 20:30:35 +0000 (22:30 +0200)]
Bug 3173 Place Hold link visible in OPAC even if syspref turned off

If the syspref RequestOnOpac is turned off, the link to place a hold does not
show in the detail page.  However, the link is still present in the results
list as well as in the basket and in lists.  Modified templates to check
for the syspref and to obey it.

NOTE:  This does not turn off the display of the Holds tab in the OPAC
user account.  I think there are situations where library staff may be
allowed to place holds but users are not allowed to do so through the
OPAC.  Leaving the Holds tab visible shows users what they have on hold,
but does not allow them to place holds.  It does allow users to cancel
holds.  If there is a need to hide this tab, that would probably be
best accomplished by a separate syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2770 follwup : force AddRenewal obey circControl system preference [revised]
Ryan Higgins [Thu, 2 Jul 2009 01:37:42 +0000 (20:37 -0500)]
Bug 2770 follwup : force AddRenewal obey circControl system preference [revised]

Also prevents infinite-length renewals by returning undef
if passed an invalid date instead of renewing with no due date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFixing syntax error
Chris Cormack [Tue, 8 Sep 2009 07:41:26 +0000 (19:41 +1200)]
Fixing syntax error

15 years agoFixing circulation template
Chris Cormack [Tue, 8 Sep 2009 07:34:26 +0000 (19:34 +1200)]
Fixing circulation template

15 years agoFixing syntax error
Chris Cormack [Tue, 8 Sep 2009 07:16:43 +0000 (19:16 +1200)]
Fixing syntax error

15 years agoFixing merge error in opac-detail.pl
Chris Cormack [Tue, 8 Sep 2009 06:59:15 +0000 (18:59 +1200)]
Fixing merge error in opac-detail.pl

15 years agoFixing bug introduced by a cherry-pick conflict
Chris Cormack [Tue, 8 Sep 2009 06:48:54 +0000 (18:48 +1200)]
Fixing bug introduced by a cherry-pick conflict

15 years agoBug 2553: Additional patch for the branch drop-down in Existing Holds.
Garry Collum [Thu, 23 Jul 2009 01:07:16 +0000 (21:07 -0400)]
Bug 2553: Additional patch for the branch drop-down in Existing Holds.

Improves previous patch through the use of GetBranchesLoop. Also adds highlighting to the Existing holds table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
15 years agoBug 3056 - replace span hacking for terms in C4::Search
Joe Atzberger [Tue, 28 Jul 2009 01:47:50 +0000 (20:47 -0500)]
Bug 3056 - replace span hacking for terms in C4::Search

Reimplemented using jquery, added OSS plugin to both interfaces.  This is
another case where having a /common directory used by both OPAC and STAFF
would increase runtime efficiency and cut development time.

Removed unused variables.

I changed the OPAC .term color to match the staff interface, rather than being a
second shade of blue.  The highlight/unhighlight link is currently a bit bolder
than its neighbors, but my styling choices are provisional.  I expect the final
tweaking of CSS to come from another more capable designer, like Owen.

Note this patch may rely on previously submitted "Search.pm minor cleanup" patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBugfix 2339 - Place hold button display with AllowOnShelfHolds OFF
Kyle M Hall [Wed, 29 Jul 2009 13:05:52 +0000 (13:05 +0000)]
Bugfix 2339 - Place hold button display with AllowOnShelfHolds OFF

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug#: 3230 Penny fine, needs fixed, just a round off. Please
Darrell Ulm [Wed, 22 Jul 2009 14:06:53 +0000 (10:06 -0400)]
Bug#: 3230 Penny fine, needs fixed, just a round off. Please

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agocheck $debug to print debug info only when wanted
Galen Charlton [Wed, 22 Jul 2009 14:08:39 +0000 (09:08 -0500)]
check $debug to print debug info only when wanted

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup to AddReturn patch - fix test
Galen Charlton [Wed, 22 Jul 2009 14:06:06 +0000 (09:06 -0500)]
followup to AddReturn patch - fix test

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago3M SIP2 Extensions groundwork and Patron Info popoulation
Joe Atzberger [Wed, 22 Jul 2009 14:08:38 +0000 (09:08 -0500)]
3M SIP2 Extensions groundwork and Patron Info popoulation

This includes some initial work for the 3M SIP2 extensions.
It also better populates the Patron object with methods for
a fuller Patron Information Reponse.  This is positively affect
EnvisionWare software, as used by NEKLS.

This work was sponsored by the Northeast Kansas Library System.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3428: Alphabetizes the collection codes in the Advanced Search.
Garry Collum [Sun, 19 Jul 2009 00:02:24 +0000 (20:02 -0400)]
Bug 3428: Alphabetizes the collection codes in the Advanced Search.

If the advancedSearchTypes = CCODE, the code descriptions are not alphabetized, as opposed to itemtypes, which are alphabetized.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug fix reconciliation of circulation compilation error
Henri-Damien LAURENT [Thu, 16 Jul 2009 22:11:59 +0000 (00:11 +0200)]
Bug fix reconciliation of circulation compilation error

reconciliation in circulation.pl introduced a compilation error

15 years agoBug 2770 follwup : force AddRenewal obey circControl system preference [revised]
Ryan Higgins [Thu, 2 Jul 2009 01:37:42 +0000 (20:37 -0500)]
Bug 2770 follwup : force AddRenewal obey circControl system preference [revised]

Also prevents infinite-length renewals by returning undef
if passed an invalid date instead of renewing with no due date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix crash introduced in previous patch
Galen Charlton [Wed, 15 Jul 2009 02:00:36 +0000 (22:00 -0400)]
fix crash introduced in previous patch

In the previous patch,

-    my @subf = $field->subfields;
-    (defined @subf) or @subf = ();

is not equivalent to

+    my @subf = $field->subfields || ();

as, the results of $field->subields is interpeted in scalar
context, not list context, resutling in @subf containing
the number of subfields, not the subfield data itself, which
engenders the error

Can't use string ("1") as an ARRAY ref while "strict refs" in use

later on.  Changing the operator to 'or' instead of '||'
fixes this.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBranch auto-selection in additem
Joe Atzberger [Wed, 8 Jul 2009 21:52:18 +0000 (16:52 -0500)]
Branch auto-selection in additem

Adding a new item should pre-select the library you are logged in at, where possible.
Use GetBranchesLoop.  This solves indy branches filtering, and sort order problems.
Set default off of ->{selected}, to establish pre-selected branch.
Fix flags check in onlymine sub, so superlibrarian + other flags still gets everything.
Removed defined(@array) check, since perl -wc warns it is deprecated.
Note new FIXME for botched date processing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2539. Remove unintegrated "spsuggest" code from search scripts.
Joe Atzberger [Thu, 2 Jul 2009 03:47:35 +0000 (22:47 -0500)]
Bug 2539. Remove unintegrated "spsuggest" code from search scripts.

The intent of kohaspsuggest is very confused.  It wanted to simultaneously
log every search query, and get spelling suggestions from a totally different
database_host:db_user:db_password:database.  The implementation seems
never have really made it into 3.0, however, since the only trace of the
tables it wants to query are in misc/migration_tools/22_to_30/phrase_log.sql

The job misc/spellcheck_suggest/make_spellcheck_suggest.pl does not even
target the same remote DB as the syspref tells the search code to do.  Instead, it hits the
local DB and, not finding the tables that have no way of existing in a 3.0
install, it CREATES its own tables spontaneously, using MyISAM storage, no less.
This script should be drastically overhauled, or more likely just removed.

Other fixes:
Commented out unconditional warn!
Also reduced bizarre whitespace amounts in catalogue/search.pl and
fixed warning as recommended by perl -wc:
    Scalar value @newresults[0] better written as $newresults[0]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agonew icon included in OPAC details page rework
Galen Charlton [Wed, 15 Jul 2009 01:14:18 +0000 (21:14 -0400)]
new icon included in OPAC details page rework

Picked up icon from earlier version of Owen's patch
for bug 2713.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup opac-search.pl
Joe Atzberger [Thu, 2 Jul 2009 03:12:29 +0000 (22:12 -0500)]
Cleanup opac-search.pl

Use GetBranchesLoop.  Use elsif.  Use $format w/ a fallback "" value.

More to come.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMinor Fixes for jQuery 1.3.2 Upgrade
John Beppu [Thu, 9 Jul 2009 01:09:00 +0000 (20:09 -0500)]
Minor Fixes for jQuery 1.3.2 Upgrade

I looked through all the relevant Javascript on this site
to find spots that would break in the upgrade from jQuery 1.2
to jQuery 1.3, and I fixed them.

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMore changes to implement jQuery upgrade.
Owen Leonard [Thu, 9 Jul 2009 01:09:01 +0000 (20:09 -0500)]
More changes to implement jQuery upgrade.

- Upgrading jquery checkboxes plugin
- Correcting references to checkboxes plugin
- Upgrading jquery hotkeys plugin
- Upgrading syntax for calls to hotkeys plugin
- Removing jquery dimensions plugin (functionality rolled into jQuery)

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpgraded from jQuery 1.2.3 to 1.3.2
John Beppu [Wed, 8 Jul 2009 18:12:15 +0000 (13:12 -0500)]
Upgraded from jQuery 1.2.3 to 1.3.2

http://docs.jquery.com/Release:jQuery_1.3
http://www.learningjquery.com/2009/03/3-quick-steps-for-a-painless-upgrade-to-jquery-13

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3390 Enabling ZIP compression in pdf generation to reduce file size
Chris Nighswonger [Sat, 4 Jul 2009 04:14:50 +0000 (00:14 -0400)]
Bug 3390 Enabling ZIP compression in pdf generation to reduce file size

Enabling compression gives a ~26% *reduction* over non-compressed Type 3 font embedding.
ie. 4.5 K/pg (compressed graphic) vs. 17.5 K/pg (uncompressed Type 3 font) vs 111 K/pg
(uncompressed graphic).

It also appears that most other applications that export in pdf use compression by
default. (OO Writer, etc.) So this approach appears justified. One could always add code
to allow the user to select embedding mode and compression.

Also correcting mode parameter value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3284) fix superlibrarian check
Nahuel ANGELINETTI [Fri, 26 Jun 2009 09:25:01 +0000 (11:25 +0200)]
(bug #3284) fix superlibrarian check

This fix the superlibrarian check in the previous fix.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3284) fix borrower deletion in independantbranches mode
Nahuel ANGELINETTI [Thu, 25 Jun 2009 10:57:35 +0000 (12:57 +0200)]
(bug #3284) fix borrower deletion in independantbranches mode

This patch fix the checks deleting a borrower in independantbranches mode.
Now, we check the user and the librarian are from the same branch, else we deny the deletion(and disable the link to delete).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSpelling correction per convention: cataloguing -> cataloging (Bug 3277)
Owen Leonard [Sat, 27 Jun 2009 15:43:17 +0000 (10:43 -0500)]
Spelling correction per convention: cataloguing -> cataloging (Bug 3277)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoReturns reworking to handle empty GetItemIssue
Joe Atzberger [Thu, 18 Jun 2009 16:31:33 +0000 (11:31 -0500)]
Returns reworking to handle empty GetItemIssue

Code cannot rely on issueinformation being populated.

Note there is room for better efficiency to have AddReturn also provide the
itemnumber (where existing) so that GetItemnumberFromBarcode is not called
at both levels.  Unfortunately there is discrepancy between this idea (for
efficiency) and the stated purpose of the $iteminformation object returned,
since $iteminformation is specifically the info from the issues table and
MUST be empty when the item was not in fact issued.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoEnable warnings in addbooks.pl Fix code generating undef and mis-matched op warnings...
Colin Campbell [Tue, 23 Jun 2009 08:14:31 +0000 (09:14 +0100)]
Enable warnings in addbooks.pl Fix code generating undef and mis-matched op warnings Remove toggle variable

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2893: extend conditions handled by AllowNotForLoanOverride
Galen Charlton [Wed, 17 Jun 2009 13:00:57 +0000 (08:00 -0500)]
bug 2893: extend conditions handled by AllowNotForLoanOverride

Prior to this patch, turning AllowNotForLoanOverride on
allowed the circ operator to permit the loan of an
item who's individual not-for-loan flag was set, but did
not allow the loan of an item whose item type's not-for-loan
flag was set.  This patch extends the definition of the
system preference so that both cases are covered.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRevision to my earlier patch for displaying the user name on checked-out items
Jane Wagner [Tue, 16 Jun 2009 16:28:06 +0000 (12:28 -0400)]
Revision to my earlier patch for displaying the user name on checked-out items

My earlier patch (using the new syspref OPACShowCheckoutName mistakenly
displayed the Koha borrower number instead of the patron barcode number
in the OPAC display; this revises the script/template to use barcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3317: Author displaying inconsistently or not at all. Revision to previous patch.
Garry Collum [Wed, 17 Jun 2009 00:37:51 +0000 (20:37 -0400)]
Bug 3317: Author displaying inconsistently or not at all. Revision to previous patch.

Revision to previous patch for bug 3317.  Removes the EXPR command from opac-basket.tmpl, which was polluting the apache logs.

NTS: Don't use EXPR.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd +(" ")+ to make few strings translatable (with Paul & Galen fix)
Frédéric Demians [Tue, 9 Jun 2009 14:24:37 +0000 (16:24 +0200)]
Add +(" ")+ to make few strings translatable (with Paul & Galen fix)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFixing toggle
Chris Cormack [Mon, 7 Sep 2009 23:48:57 +0000 (11:48 +1200)]
Fixing toggle

15 years agoBug 2889: Removed toggle variable from categorie.pl and categorie.tmpl.
Garry Collum [Tue, 9 Jun 2009 22:34:55 +0000 (18:34 -0400)]
Bug 2889: Removed toggle variable from categorie.pl and categorie.tmpl.

Removed toggle variable from categorie.pl and categorie.tmpl.  Used template __odd__variable in categorie.tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2889: Added highlighting to smart-rules.tmpl
Garry Collum [Thu, 11 Jun 2009 00:23:52 +0000 (20:23 -0400)]
Bug 2889: Added highlighting to smart-rules.tmpl

Removed unused toggle variable form smart-rules.pl and added highlighting to smart-rules.tmpl through template __odd__.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPull the last OPAC-specific tmpl vars out of gettemplate.
Joe Atzberger [Thu, 4 Jun 2009 17:43:52 +0000 (12:43 -0500)]
Pull the last OPAC-specific tmpl vars out of gettemplate.

These don't belong every template, only on OPAC:
~ opacstylesheet
~ opaccolorstylesheet
~ opacsmallimage

The latter 2 were already being populated in C4::Auth anyway.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3271 : Added tooltip when adding to a list with no item selected (same as for...
Matthias Meusburger [Fri, 29 May 2009 12:43:55 +0000 (14:43 +0200)]
bug 3271 : Added tooltip when adding to a list with no item selected (same as for cart)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3263: fixed ersatz references to AmazonContent
Galen Charlton [Wed, 27 May 2009 18:10:45 +0000 (13:10 -0500)]
bug 3263: fixed ersatz references to AmazonContent

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>