Owen Leonard [Fri, 29 Aug 2008 14:06:11 +0000 (09:06 -0500)]
More markup corrections for better validation.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Fri, 29 Aug 2008 14:05:52 +0000 (09:05 -0500)]
Putting icon sets into tabs. Makes the interface more compact, and much better when editing authorized values for which icons are inappropriate.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Danny Bouman [Thu, 28 Aug 2008 19:22:39 +0000 (15:22 -0400)]
bug 2569: added the zipcode to display along with the patron address
Added the zipcode to display along with the patron address when you are viewing a Patron from the intranet.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 2 Sep 2008 21:34:41 +0000 (16:34 -0500)]
fixing permission
Michael Hafen [Fri, 22 Aug 2008 23:26:17 +0000 (17:26 -0600)]
change link to moredetail.pl. In other places it's called with itemnumber=
Change the link to moredetail.pl from item= to itemnumber=
I saw the link on boraccount.pl as itemnumber= and thought it should be that way here too.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Fri, 22 Aug 2008 23:24:43 +0000 (17:24 -0600)]
Add/Change link to item details (catalogue/moredetail.pl) for circulation and patron details
This adds the link to item details to circulation.pl
and changes the link on member details to include the itemnumber and #item... in the link.
Forgot the returns.pl. Will do that in the next patch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Fri, 22 Aug 2008 23:24:44 +0000 (17:24 -0600)]
Added link to catalogue/moredetail.pl on the returns page for each returned item
Had to add itemnumber to the hash of returned item information.
Links to moredetail.pl with itemnumber and #item in the url.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Thu, 28 Aug 2008 15:48:13 +0000 (17:48 +0200)]
modification to show the library and not the username of the person at OPAC.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 28 Aug 2008 13:46:04 +0000 (08:46 -0500)]
bug 2568: set default value of intranetuserjs to blank
The intranetuserjs syspref allows a Koha administrator
to insert arbitrary JavaScript into the staff page header.
Now that this syspref is functional again, this patch
changes the installation scripts so that the default
value is blank - any JavaScript we ship with Koha should
be in the templates, not in a syspref.
Documentation changes: none per se. However, I do want to
point out that the intranetuserjs syspref is a bit of a
dangerous one - enter a value with incorrect syntax, and
you could make it difficult to access the staff interface -
and should probably be marked as an advanced option.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 26 Aug 2008 19:06:02 +0000 (14:06 -0500)]
Fix for Bug 2557, "Guarantor information - error messaee when clicking borrower# link." Also correcting a couple of minor markup errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Mon, 25 Aug 2008 16:14:36 +0000 (11:14 -0500)]
Fixing tablesorter, display of renew links
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Mon, 25 Aug 2008 18:38:56 +0000 (13:38 -0500)]
Spelling corrections: organisation->organization, authorise->authorize, catalogue->catalog
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Fri, 29 Aug 2008 19:36:51 +0000 (13:36 -0600)]
If itemnumber is sent to catalogue/moredetail.pl use it
If itemnumber is part of the url for catalogue/moredetail.pl
put it to use.
This happens in members/boraccount.pl if a fine is attached to a
barcode.
This patch makes moredetail.pl show only the item specified by
itemnumber.
Implements some changes to the patch suggested on
patches@koha.org
give visual cue on UI and a link out.
More friendly pruning of the other items.
Thanks to Galen Charlton and Joe Atzberger
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 2 Sep 2008 20:36:02 +0000 (15:36 -0500)]
Revert "If itemnumber is sent to catalogue/moredetail.pl use it"
Applied wrong version of patch. Oops.
This reverts commit
9eb1465b2874a8a65195065bed083d26614ca287.
Joe Atzberger [Tue, 26 Aug 2008 03:57:01 +0000 (22:57 -0500)]
Fines fixes: apparent problems with fines prevent processing.
CalcFine returned values that mismatched expectations in fines.pl.
fines.pl refactored: added debugging, prevent needless recreation of
Calendar objects by storing them in hash by branch.
Still outstanding problems with fines, including the output of a field
that has no other references in Koha (so is always undef) and the
incorrect description of FinesMode.
Calendar exported "new" erroneously. I also cleaned up the queries to
avoid needlessly compiling additional statement handles.
Please test and consider application to 3.0 maintenance.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Thu, 21 Aug 2008 21:55:27 +0000 (15:55 -0600)]
If itemnumber is sent to catalogue/moredetail.pl use it
If itemnumber is part of the url for catalogue/moredetail.pl put it to use.
This happens in members/boraccount.pl if a fine is attached to a barcode.
This patch makes moredetail.pl show only the item specified by itemnumber.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 26 Aug 2008 15:33:00 +0000 (10:33 -0500)]
bug 2466: fix clearing item field
When editing an item in the cataloging and serials
item editors, clearing a field now works.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 26 Aug 2008 15:32:59 +0000 (10:32 -0500)]
bug 2466: regression test
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Wed, 27 Aug 2008 18:32:31 +0000 (13:32 -0500)]
Usage option correction (-h not -n)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Wed, 27 Aug 2008 14:44:28 +0000 (09:44 -0500)]
Minor SIP cleanup, conditionalize warnings.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Wed, 27 Aug 2008 14:32:26 +0000 (09:32 -0500)]
Bug 2419: require Exporter
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Mon, 25 Aug 2008 17:13:38 +0000 (12:13 -0500)]
bug 2552: correct issue history display
The loan history for a bib can be incorrect if the bib's
biblioitemnumber is not the same as its biblionumber.
This was due to a bad join in GetBiblioIssues().
Credit to Michael Hafen for patching a similar bug,
which inspired me to check for other bad joins.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
MJ Ray [Tue, 26 Aug 2008 23:22:14 +0000 (00:22 +0100)]
Update INSTALL.debian to mention a2dissite default
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Fri, 22 Aug 2008 20:41:33 +0000 (15:41 -0500)]
Style correction in member entry form; Enabling intranetuserjs in doc-head-close.inc.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jesse Weaver [Mon, 25 Aug 2008 16:51:25 +0000 (11:51 -0500)]
fix number two for bug 1204: Lists of issues and overdues on opac-user.pl
This makes opac-user.pl sort the output from GetPendingIssues itself, by descend
ing due date.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Fri, 22 Aug 2008 17:12:47 +0000 (11:12 -0600)]
bug: bookcount.pl pulls wrong title. Problem is sql joins on wrong columns
the sql seems to assume that biblionumber and biblioitemnumber are always the same, which in my case they aren't.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 30 Jul 2008 13:24:20 +0000 (08:24 -0500)]
Fix for Bug 2424: Altering layout of advanced search screen to make it compatible with Internet Explorer 6. Documentarians: this will require an updated screenshot.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Mon, 25 Aug 2008 16:14:27 +0000 (11:14 -0500)]
Fix for Bug 2548, "Links to Reports that No Longer Exist in Side Menu." Some links were left behind after removal from reports-home.tmpl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Mon, 25 Aug 2008 16:14:45 +0000 (11:14 -0500)]
Spelling correction. Fixes Bug 2501.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 22 Aug 2008 00:59:45 +0000 (19:59 -0500)]
bug 2545: fix XSLTDetailsDisplay
Corrected so that when XSLTDetailsDisplay is ON but
XSLTResultsDisplay is OFF, the portion of the OPAC bib
details page that's derived from the MARC bib record
is no longer missing.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jesse Weaver [Fri, 22 Aug 2008 15:54:31 +0000 (10:54 -0500)]
Fix itemtype image problem in moremember.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 21 Aug 2008 21:39:45 +0000 (16:39 -0500)]
bug 2509: fix file permissions
Following suggestion by Vincent Danjean for Debian
packaging, 0755 -> 0644 for non-executable
files.
Also removed shebang from a few modules in C4.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 21 Aug 2008 15:48:31 +0000 (10:48 -0500)]
bug 2540: allow download of report
$error return C4::Reports::execute_query is
always defined.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jesse Weaver [Thu, 21 Aug 2008 16:52:11 +0000 (11:52 -0500)]
fix for bug 1101: Renew All for the OPAC
This adds a Renew All form to the OPAC, and updates opac-renew.pl to take multiple item= parameters.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Wed, 20 Aug 2008 20:40:44 +0000 (15:40 -0500)]
issues_stats returns empty results if row/column = items.ccode/datetime
Also added ESCAPE="HTML" to column/row headers because users may define
collections that include ampersands, like:
B&T Rental--Fiction
The Tidy error associated would be:
line 574 column 29 - Error: general entity "T" not defined and no default entity
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jesse Weaver [Wed, 20 Aug 2008 18:21:50 +0000 (13:21 -0500)]
fix for bug 1771: Template errors with remote itemtype image
This adds a new function, getitemtypeimagelocation, that returns the image
unmodified for absolute urls and returns the proper intranet or opac path
otherwise. It also updates all of the relevant files to use that function.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jesse Weaver [Tue, 19 Aug 2008 22:11:20 +0000 (17:11 -0500)]
fix for bug 2488: OPACItemsResultsDisplay/singlebranchmode
This patch changes the template slighly so that these two system preferences do not conflict.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jesse Weaver [Tue, 19 Aug 2008 22:11:21 +0000 (17:11 -0500)]
Fix for minor error in shelfbrowser queries
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jesse Weaver [Tue, 19 Aug 2008 19:01:23 +0000 (14:01 -0500)]
fix for bug 2477: Improve Speed of the Shelf Browser
This patch updates the queries for the shelf browser in opac-detail.pl for a
slight performance gain. It also adds a param for dateformat to C4::Auth to
fix a warning.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Vincent Danjean [Fri, 15 Aug 2008 19:19:01 +0000 (21:19 +0200)]
Removing strange dot file
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Vincent Danjean [Fri, 15 Aug 2008 20:49:36 +0000 (22:49 +0200)]
Still fixing permission and first line of scripts
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Vincent Danjean [Fri, 15 Aug 2008 19:06:19 +0000 (21:06 +0200)]
No 'BOM' marker for a script file
'#!' must be the first characters
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Vincent Danjean [Fri, 15 Aug 2008 19:03:04 +0000 (21:03 +0200)]
Shebang line must be the first of the file
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Vincent Danjean [Fri, 15 Aug 2008 18:29:55 +0000 (20:29 +0200)]
Add support for DESTDIR
Distributions (such as Debian) needs a staging area when building the package
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 21 Aug 2008 00:26:59 +0000 (19:26 -0500)]
bug 2503: fix minor XHTML errors
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 21 Aug 2008 00:23:46 +0000 (19:23 -0500)]
bug 2503: comment out unneeded warns
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 21 Aug 2008 00:21:08 +0000 (19:21 -0500)]
bug 2503: fix call to AddIssue()
The due date parameter must be a C4::Dates object,
not a date string.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Wed, 20 Aug 2008 16:21:52 +0000 (11:21 -0500)]
bug 2503: refactoring and bugfixing on create_koc_db.pl
This is the script that generates the patron and holdings database for the offline circ module. I
touched up a few parts of it:
* fixed the database syntax to squash a bug or two
* extracted some methods for readability and reuse
* added some documentation
* added a --file and --force command line argument
* made it die if DBD::SQLite is not present. That module is required for this feature.
Here's an example crontab line that will generate the borrowers.db file each midnight.
0 0 * * * create_koc_db.pl --file /tmp/borrowers.db
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Wed, 20 Aug 2008 16:21:51 +0000 (11:21 -0500)]
bug 2503: moving offline circulation db generator to misc/cronjobs directory
This script generates a sqlite database of patron and holdings data for the offline circulation tool.
It's a cronjob, so it should go into misc/cronjobs
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Kyle Hall [Wed, 20 Aug 2008 16:21:50 +0000 (11:21 -0500)]
Added offline circ sqlite database generator.
Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Wed, 20 Aug 2008 16:21:49 +0000 (11:21 -0500)]
bug 2503: updating process_koc.pl to interpret new versions of import file
The file format for the .koc files has changed a few times, and this patch brings
us up to date with the current version.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Wed, 20 Aug 2008 16:21:48 +0000 (11:21 -0500)]
bug 2503: tests for C4::Circulation
I'm adding some tests for C4::Circulation methods that I'm altering
to allow the offline circulation tool to use C4::Circulation to upload
its data. These test a bit of the old functionality and try to show
that the new functionality does what I think it does.
C4::Circ::Addissue to tests issuedate
these also test AddRenewal.
tests for C4::Circ::MarkIssueReturned
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Wed, 20 Aug 2008 16:21:47 +0000 (11:21 -0500)]
bug 2503: removing Force* subs and replacing them with calls to C4::Circulation subs
The offline circulation file processor originally used its own methods to
insert circulation data. This patch takes advantage of the updated
C4::Circulation methods that allow us to specify dates in the past.
This makes the offline circulation file processor use C4::Circulation
functions instead of its own and removes the deprecated subs.
moving from ForceIssue to AddIssue
replacing ForceRenewal with AddRenewal
moving from ForceReturn to MarkIssueReturned
removing deprecated Force* subs
fixing a few bugs in process_koc.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Wed, 20 Aug 2008 16:21:46 +0000 (11:21 -0500)]
bug 2503: adding dates to some C4:Circulation methods to allow offline circulation tool to specify dates other than today
When uploading an offline circulation file, some actions may need to take place
in the past. This patch adds date parameters to some C4::Circulation methods
to allow us to set dates on them
added issuedate to C4::Circulation::AddIssue
adding issuedate to C4::Circulation::AddRenewal
adding returdate to C4::Circulation::MarkIssueReturned
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Wed, 20 Aug 2008 16:21:45 +0000 (11:21 -0500)]
bug 2503: documentation improvements in C4::Circulation
These are some documentation changes that I made to C4::Circulation as
I was writing tests for it.
moved around the docs for CanBookBeIssued. It was in the wrong spot in the file.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Kyle Hall [Wed, 20 Aug 2008 16:21:44 +0000 (11:21 -0500)]
Integrated version of the Koha Offline Circulation file uploader. It needs some testing and cleanup, but it works.
Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Tue, 19 Aug 2008 18:51:09 +0000 (13:51 -0500)]
bug 2530 : create new date object in javascript function instead of modifying passed-in reference.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jesse Weaver [Mon, 18 Aug 2008 17:37:55 +0000 (12:37 -0500)]
fix for bug 2528: installation fails with confusing error message
This makes the dns check happen earlier, and fail humanely if there is a problem.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Mon, 18 Aug 2008 17:11:56 +0000 (12:11 -0500)]
Bug #2429, bad HTML from unclosed <head>.
Also some cleanup of opac-showmarc script including removing bogus
dependencies (DBI, CGI methods). Should consider using C4::XSLT if
applicable.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 19 Aug 2008 15:08:13 +0000 (10:08 -0500)]
Fixing a couple of minor markup issues.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 15 Aug 2008 21:38:22 +0000 (16:38 -0500)]
bug 2527: avoid targeting of items on hold shelf
SQL fix to properly ensure that if an item is on
the hold shelf, it will not be used for request
targeting, which applies only to items that are
not already on the hold shelf.
Prior to this fix, when checking out an item on the
hold shelf that fills patron A's hold request, it
was possible for that request to not be marked as
filled if another patron had an item-level request
on the item; the second patron's request was
incorrectly targeted by that item.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Fri, 15 Aug 2008 18:17:14 +0000 (13:17 -0500)]
Bug 2524: improving the submitted test reports
switching from 'prove' to 'perl' to run the test scripts when we're preparing
them to be submitted to smolder. Prove adds an additional summary at the end
of the test run which confuses the TAP parser in smolder. It thinks that an
additional test has been run, and it fails it.
Then, I added a '-' before the command in the Makefile. THat's so that even
if 'perl' returns a failing code (because some tess failed), the rest of the
rules are run and a report gets submitted. Othewise, only passing reports
get sent.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Fri, 15 Aug 2008 16:40:05 +0000 (11:40 -0500)]
bug 2525: fixing tests for misc/cronjobs/longoverdue.pl
This patch fixes the tests so that they include the new required parameters for longoverdues.pl.
This patch also doesn't include a test script that accidently got in the last one.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Fri, 15 Aug 2008 13:41:28 +0000 (08:41 -0500)]
Bug 2524: Adding script to submit test reports to smolder server
This patch adds a target in the t/Makefile and a script in t/smolder_smoke_signal
to submit the results of test runs to a smolder server. It will allow users to submit
their own test results to a central location by running "make submit" from the t/
directory.
Smolder is a web-based application that aggregates and presents the output of
tests. We have an instance running at:
http://arwen.metavore.com:8000/app/public_projects/smoke_reports/1
More information about using smolder for Koha is available at:
http://wiki.koha.org/doku.php?id=en:development:smoke_reports
I intend to have the test suite run each night automatically and the results
sent to the smolder server. This will help us keep track of the current state
of the the code and possibly catch bugs introduced by changes. I encourge others
to submit their own test results if they want, especially if they are on an unusual
platform or are with a non-standard configuration.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Fri, 15 Aug 2008 16:19:06 +0000 (11:19 -0500)]
bug 2526: removing DEBUG flag from C4::Search
The DEBUG flag was left turned on.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 15 Aug 2008 01:59:49 +0000 (20:59 -0500)]
bug 2522 [1/3]: DB rev 3.1/001 - hold request targetting
For bug 2522, add a new table called hold_fill_targets to
implement hold request targeting. This table
has the following columns:
borrowernumber - identify request
biblionumber - ditto
itemnumber - item targeted to fill request
source_branchcode - current location of item
item_level_request - if 1, request is item-level
For bug 2331, adds a column called item_level_request
to tmp_holdsqueue.
Note: both of the item_level_request columns can
go away once reserves is modified so that
it is clear whether a request is item-level or
bib-level.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 15 Aug 2008 01:59:52 +0000 (20:59 -0500)]
bug 2523: add columns to holds queue report
* added author, ccode, location, and item enumchron
* sorted by collection, locatoin, call number, author, title
As part of this patch, commented out the JavaScript tablesorter,
which could cause the browerer to lock up if the picklist
contains more than a couple hundred items to pull.
Some sort of pagination is clearly required, but since
it is necessary for customers to be able to print out
the picklist, there still needs to be an option to
see the complete list for a branch.
This patch includes the final component of the fix
for bug 2331.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 15 Aug 2008 01:59:50 +0000 (20:59 -0500)]
bug 2522 [2/3]: C4::Reserves support for request targeting
_Findgroupreserve, which identifies which hold request an
item should fill, is modified to check to see if
that item is targeted to fill a specific hold request.
It first checks for a targeted match with an item-level hold request,
then a targeted match with a title-level request. If no
such targeted match exists, it then checks for the top entries
in the holds queue.
The hold targeting map (i.e., the hold_fill_targets table) is
populated by the build_holds_queue.pl batch job. If that
job is not used, the behavior of _Findgroupreserve
is not changed.
This patch also
* adjusts ModReserveMinusPriority so that it calls
_FixPriority().
* adjusts circ/returns.pl so that it
correctly detects transfers.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 15 Aug 2008 01:59:51 +0000 (20:59 -0500)]
bug 2522 [3/3]: populate hold_fill_targets
This batch job now automatically populates the
holds request targeting table hold_fill_targets.
This patch is essentially a revamp of the job,
and includes fixes for the following bugs:
2281 (holds queue report including unavailable items)
2331 (holds queue report not working with item-level
holds)
2332 (holds queue script should attempt to fill
many requests as possible).
Several functions in this batch job are candidates
for being moved to C4::Reserves:
GetBibsWithPendingHoldRequests()
GetPendingHoldRequestsForBib()
GetItemsAvailableToFillHoldRequestsForBib()
MapItemsToHoldRequests()
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jesse Weaver [Thu, 14 Aug 2008 18:08:47 +0000 (13:08 -0500)]
Fix for bug 2155: duplicate checkin box on returns screen
This changes some css and markup to make the return box at the top not show when one is on the checkin screen. It also moves the markup for the autocompleting search box to its own file.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Thu, 14 Aug 2008 18:52:39 +0000 (13:52 -0500)]
Prevent compilation errors from complex C4 import/export.
SIP code uses UNIVERSAL modules that do not tolerate the circular deps in
C4, specifically, in Auth.pm. Changing the order so that UNIVERSAL follows
the other imports is important to avoiding failures like:
perl -w -e 'use UNIVERSAL qw(can); use C4::Auth;'
"MarkIssueReturned" is not exported by the C4::Circulation module
This patch should resolve the problem earlier seen with Shelves too.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 14 Aug 2008 16:48:41 +0000 (11:48 -0500)]
bug 2341: OPAC title-level holds permitted when items are on-order
Changed so that the presence of an on-order item (items.notforloan =- -1)
permits a title-level hold request to be made. Prior to this patch,
if all of the items linked to the bib were on-order, no title-level
request was permitted.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 14 Aug 2008 16:13:50 +0000 (11:13 -0500)]
bug 2502: correctly check patron account expiration
When placing a hold request from the staff interface,
now correctly indicate if the patron account has expired.
Prior to this patch, would warn that the account
had expired even when the expiry date is in the future,
and vice versa.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 14 Aug 2008 15:43:08 +0000 (10:43 -0500)]
bug 2520: don't change item-level requests to bib-level
Prior to this fix, changing the priority of any hold requests
in the queue of requests for a bib would convert
all item-level requests to title-level requests.
As part of this fix, improved display of the holds queue
so that item-level and bib-level requests can be more
clearly distinguished.
Documentation note: new screenshot of list of requests for
a bib in the staff interface.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 14 Aug 2008 15:43:09 +0000 (10:43 -0500)]
bug 2521: distinguish types of hold requests
Title-level and item-level requests are now more
clearly distinguished in the patron details page
and the patron checkout page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 14 Aug 2008 15:43:06 +0000 (10:43 -0500)]
bug 2518: remove useless patron and branch lookups
AddIssue does not use the results of the lookup
of the patron whose hold request was preempted
by the issue. This patch now leaves a no-op in
the '$restype eq "Waiting"' test, but I'm not going to
refactor the hold cancellation logic now.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 14 Aug 2008 15:43:07 +0000 (10:43 -0500)]
bug 2519: clear waitingdate if request is moved off waiting status
* Changed C4::Reserves::ModReserve so that if using it to take an
item off the hold shelf, reserves.waitingdate is cleared.
* Improved POD.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Wed, 13 Aug 2008 18:43:52 +0000 (12:43 -0600)]
Have zebrasrv log less
Better to fill the hard drive with biblio than with zebra logs ;)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Nighswonger [Wed, 13 Aug 2008 14:38:25 +0000 (09:38 -0500)]
kohabug 2507 Fixing labels search to indicate keyword rather than title search
Documentation may require an updated screen shot
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Tue, 12 Aug 2008 20:56:28 +0000 (15:56 -0500)]
masthead - realign terminology for Tag Cloud
Tag Cloud should link to user-generated tags, in a cloud display.
What used to be called "Tag Cloud" (ISBD subject links for UNIMARC libraries)
should be called a "Subject ...". AFAICT it doesn't currently use a "cloudy"
display, so some other term might be more appropriate.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Sun, 10 Aug 2008 06:50:47 +0000 (18:50 +1200)]
Fixing a couple of bugs in the package
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Sat, 9 Aug 2008 23:35:58 +0000 (11:35 +1200)]
Working on preconfiguring for the package
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Tue, 5 Aug 2008 21:07:13 +0000 (09:07 +1200)]
Bumping patch number, new package release
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Tue, 5 Aug 2008 10:05:23 +0000 (22:05 +1200)]
Starting work on the postinst file
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Mon, 4 Aug 2008 23:05:40 +0000 (11:05 +1200)]
More work on packaging
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Mon, 4 Aug 2008 22:35:49 +0000 (10:35 +1200)]
Fixing some bugs in the package, updating dependencies
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Mon, 4 Aug 2008 22:22:36 +0000 (10:22 +1200)]
Bumping patch number
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Sun, 3 Aug 2008 10:12:54 +0000 (22:12 +1200)]
Still working
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Sun, 3 Aug 2008 09:49:05 +0000 (21:49 +1200)]
Keeping on working on the packaging
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Sun, 3 Aug 2008 09:26:49 +0000 (21:26 +1200)]
More packaging work
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Chris Cormack [Sun, 3 Aug 2008 09:20:33 +0000 (21:20 +1200)]
Files needed for packaging
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Tue, 12 Aug 2008 15:11:53 +0000 (10:11 -0500)]
Bug 2400 [18/18]: fixing pod syntax in C4/SIP/Sip/MsgType.pm
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Tue, 12 Aug 2008 15:11:52 +0000 (10:11 -0500)]
Bug 2400 [17/18]: fixing pod syntax in C4/SIP/ILS/Item.pm
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Tue, 12 Aug 2008 15:11:51 +0000 (10:11 -0500)]
Bug 2400 [16/18]: fixing pod syntax in C4/SIP/ILS/Patron.pm
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Tue, 12 Aug 2008 15:11:50 +0000 (10:11 -0500)]
Bug 2400 [15/18]: fixing pod syntax in C4/External/BakerTaylor.pm
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Tue, 12 Aug 2008 15:11:49 +0000 (10:11 -0500)]
Bug 2400 [14/18]: fixing pod syntax in C4/Barcodes/incremental.pm
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Tue, 12 Aug 2008 15:11:48 +0000 (10:11 -0500)]
Bug 2400 [13/18]: fixing pod syntax in C4/Barcodes/hbyymincr.pm
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Tue, 12 Aug 2008 15:11:47 +0000 (10:11 -0500)]
Bug 2400 [12/18]: fixing pod syntax in C4/NewsChannels.pm
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Tue, 12 Aug 2008 15:11:46 +0000 (10:11 -0500)]
Bug 2400 [11/18]: fixing pod syntax in C4/Labels.pm
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Tue, 12 Aug 2008 15:11:45 +0000 (10:11 -0500)]
Bug 2400 [10/18]: fixing pod syntax in C4/ImportBatch.pm
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>