If more than one translation is installed but only one is active, a blank div
is displayed at the bottom of all pages in the intranet (and in the OPAC if the
opacchangelanguages system preference is ON), taking a bit of vertical real
estate needlessly.
Changed so that <div> for the language chooser is output
only if there is more than one enabled language.
This patch removes the system preference from new installations.
No db revision is supplied to remove the system pref from existing installations.
It is recommended for administrators to use the scripts provided in the misc/ directory
to ensure that their system preferences are in sync with those used in code.
Admins should remove this preference from existing installations manually.
bug 3159: allow editing child patron that has no valid guarantor
If a patron with a child patron category is not linked
to a guarantor (or a valid one), it was not possible to edit
the child patron's record. When attempt, no changes were saved
and the following error is recorded in the Apache error log:
memberentry.pl: DBD::mysql::st execute failed: Cannot add or
update a child row: a foreign key constraint
fails (`gmc_koha/borrowers`, CONSTRAINT `borrowers_ibfk_2`
FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) ...
This patch fixes this bug, allowing a child patron record to be
edited even if it has no guarantor.
Brian Harrington [Fri, 24 Apr 2009 18:39:54 +0000 (14:39 -0400)]
Revisions to auto-generated authorities patch
It turns out that the "blank" record created by MARC::Record->new()
has a leader, so now I explicitly create one in addbiblio.pl. I
also realized I can't count. :-)
Joe Atzberger [Fri, 19 Sep 2008 00:02:46 +0000 (19:02 -0500)]
Cleanup and tighten Letters module.
Subroutine arguments enforced w/ with more checks, explicit return undef where warranted.
Placeholders used in SQL where applicable.
One logical error corrected :
- next MESSAGE if ( lc( $message->{'message_transport_type'} eq 'rss' ) );
+ next MESSAGE if ( lc($message->{'message_transport_type'}) eq 'rss' );
Andrew Moore [Wed, 17 Dec 2008 22:32:25 +0000 (16:32 -0600)]
Bug 2505: adding warnings to opac-detail.pl
Before starting to edit opac/opac-detail.pl, I added 'use warnings' and
eliminated all of the warnings that I could get it to produce. I also
extracted two lines that prepared an amazon ISBN into a function. They
were causing a few warnings and might as well be extracted. They should
probably be moved to a module somewhere since these two lines are copied
all over our code.
Frederic Demians [Wed, 21 Jan 2009 12:28:34 +0000 (13:28 +0100)]
Modify GoogleJacket display
On detail page, when GoogleJacket is enabled,
book cover is retrieved from Google. This image
is a link to GoogleBook services: full text,
book localisation in a bookstore, etc.
This patch removes the link on book cover and
add underneath a text 'Source Google' with a
link to GoogleBook services.
Joe Atzberger [Wed, 22 Apr 2009 20:22:38 +0000 (15:22 -0500)]
Bug 3118: Remove comment that perturbs IE
Formatting bugs not fixed. Class added to relevant labels.
Both CSS and jquery setting of width do not "take" in IE7.
The background-color, however, can be affected. Go figure.
Brian Harrington [Tue, 21 Apr 2009 16:13:22 +0000 (12:13 -0400)]
Patch to improve auto-generated MARC21 authorities
This patch makes sure that MARC21 authorities have a minimal
Leader, 008, and 040. If an authority record is created through
BiblioAddsAuthority it generates a 670 based on information in
the bib record.
Bug 2847 - Fix html escaping in categorie.tmpl (more needed)
Added escape="html" to several TMPL_VAR tags which need it in order
to deal with quotes and other special chars in user supplied data.
Many other templates still need to have escaping added to fields which
allow free form entry.
Paul Poulain [Sat, 18 Apr 2009 23:37:32 +0000 (01:37 +0200)]
fir for #2338
When I go to serials/claims.pl, "All Suppliers (2)" is selected in the supplier
dropdown list, and no missing issues are listed. When I choose another supplier
from that list ("Supplier 1 (2)"), then two missing issues are listed. Should
"All Suppliers" instead read "Choose a Supplier" ?
chris: I think it might be safe to remove the all suppliers option all together as its
doing nothing
paul: agreed, this patch removes the All Supplier line, that is useless, confusing & untranslatable
Paul Poulain [Sat, 18 Apr 2009 23:24:05 +0000 (01:24 +0200)]
fix for 2336
When you put a library in a group it doesn't show on the details list. The
details list has a properties column that maybe is supposed to be used for this
since there doesn't appear to be any other use for it.
Paul Poulain [Sat, 18 Apr 2009 21:46:24 +0000 (23:46 +0200)]
Fix for 2363
There is a comma at the beginning that shouldn't be there and then there are
commas in the vol, no combo making it hard to read. it should be something
like this:
Change typo Localisation to Localization for Bug # 3102
[RM note: I think there are a few people who wouldn't
call "localisation" a typo - such as our UK, NZ,
Australian, etc. contributors ;-) ]. That said,
I'm pushing this patch to consistent with the
general trend of the English varient used on the
/prog/ templates. There's no implication that en_US
is the "correct" version of the language.]
Paul Poulain [Sat, 18 Apr 2009 19:32:43 +0000 (21:32 +0200)]
fix for #908
In an list of autorised values (Parameters >autotised values), if you delete an
autorised value after confirm, you go back to the first page of the list, and
you must return manually to the page you left before.
Paul Poulain [Sat, 18 Apr 2009 19:34:40 +0000 (21:34 +0200)]
fix for #918
In authorities, you can create frameworks like for biblio.
But in these it's impossible to delete useless fields, because when you click on
delete button, you go back to the default framework.
SO if you confirm your deletion, it delete your field in the default framework
and so in all the framwork (I think...).
Owen Leonard [Sat, 18 Apr 2009 19:42:10 +0000 (14:42 -0500)]
Bug 3132: Reformatting guarantor entry based on C vs. P patron types
Professional patrons might have Organizations as guarantors, so display the guarantor entry form with a single line labelled appropriately. For Child patrons display the form fields as before.
The alternative postal code input on the patron
editing form was only permitted 5 characters of
input. Increase this to 10 to match the
primary zipcode.
Joe Atzberger [Thu, 9 Apr 2009 16:50:47 +0000 (11:50 -0500)]
Multi-bug fix - SetMarcUnicodeFlag for records coming from Koha
This has bearing on bugs 2905, 2665, 2514 and other "wide character" crashes
related to diacritics and Unicode. This should help open the door for reliable
input of diacriticals via acquisitions.
MARC21_utf8_flag_fix.pl diagnoses and fixes existing problems with MARC data
affected by the bug.
Adding SetMarcUnicodeFlag to TransformKohaToMarc prevents the bug from corrupting
further data.
Joe Atzberger [Fri, 3 Apr 2009 20:42:20 +0000 (15:42 -0500)]
Script to repair MARC21 leader/09.
Acquisitions process seems to be adding records with incorrect
representation of the MARC encoding in leader/09. It should be
'a' meaning UTF-8, for all Koha's internalized records, but in
many cases it appears blank (for MARC-8). This script diagnoses
and repairs the value in the leader, depending on runtime options.
The symptom of this problem is that high-value UNICODE characters
in the record will cause Koha to crash whenever it tries to parse
the MARCXML, giving a "Wide character" fatal. While we work on
fixing the input, this script will fix the existing data.
Joe Atzberger [Mon, 13 Apr 2009 22:05:49 +0000 (17:05 -0500)]
Re-insert useldapserver into koha-conf.xml
This doesn't insert the large and typically unused <ldapserver> block,
just the switch with a comment pointing to C4::Auth_with_ldap. This otherwise
was undocumented requirement, making LDAP config a bit of a shot in the dark.
John Beppu [Tue, 14 Apr 2009 19:45:15 +0000 (14:45 -0500)]
bug 3110 - Move Serial Preferences to Serials Tab
- Moved the following system preferences to the Serials tab:
OPACDisplayExtendedSubInfo
OPACSubscriptionDisplay
RenewSerialAddsSuggestion
SubscriptionHistory
* Use of uninitialized value in pattern match (m//) at C4/Biblio.pm line 1305
(displaying MARC21 856s that don't have $3)
* Use of uninitialized value in multiplication (*) at catalogue/detail.pl line 243.
(attemping to calculate average Amazon rating if no Amazon info
is available)
* opac-detail.pl: Use of uninitialized value in length at C4/External/Amazon.pm line 90
(attempting to calculate length of $isbn if it happens to be undef)
* Use of uninitialized value in pattern match (m//) at C4/Biblio.pm line 1305
(displaying MARC21 856s that don't have $3)
* Use of uninitialized value in multiplication (*) at catalogue/detail.pl line 243.
(attemping to calculate average Amazon rating if no Amazon info
is available)
* opac-detail.pl: Use of uninitialized value in length at C4/External/Amazon.pm line 90
(attempting to calculate length of $isbn if it happens to be undef)
bug 3049: display correct due date of renewed loans
The intranet item display provided by moredetail.pl
would display the original due date of the item, and
would thus be incorrect if the item had been renewed
and got a different due date.
The incorrect date was coming from items.onloan,
which AddIssue() sets to the due date. This patch
fixes the bug in two ways:
[1] AddRenewal() now updates items.onloan with the
correct due date.
[2] Two templates were updated to display the
due date from (indirectly) issues.date_due
instead of items.onloan, thus making it less
likely that the wrong value will be displayed.
This patch does *not* update items.onloan to reflect
the correct due date.
Joe Atzberger [Thu, 5 Feb 2009 19:04:20 +0000 (13:04 -0600)]
Bug 2919 -- fix value_builder plugins for dateaccessioned, barcode
This patch depends on my previous one "Begin cleanup on additem" and
fixes one bug introduced in that patch.
Overhaul of additem sections to factor out common pieces especially attributes.
Plugin js vastly simplified and reimplemented in jquery. Performance improved.
Note that a particularly busy cataloging department should still leave
barcode blank for server-side autopopulation to avoid collision.
Joe Atzberger [Wed, 21 Jan 2009 01:18:21 +0000 (19:18 -0600)]
Begin cleanup on additem.
REFACTOR logic out of conditional branches when the assignment ($nextop) is the same.
Be sure to EXIT after printing a redirect, instead of wasting clock filling in the
template for a process the user will never see. Remove the now inapplicable logic for
differentiation between "/cgi-bin" and "non /cgi-bin" installations. There is no
longer any /cgi-bin in the actual directory file path.
This does not fix the value_builder js errors like "Blurbarcode52251 is not defined",
but it does not cause them either (see Bug 2919).
Joe Atzberger [Fri, 27 Mar 2009 15:34:34 +0000 (10:34 -0500)]
Introduce sth caching to Letters.pm
The re-creation of statement handles for the same queries, repeatedly,
seriously degrades the performance of notices. This introduces new
class-level caching to avoid that problem.
Note: initial provisions
to do the same with caching of COLUMNS information about tables is
also included, but this would probably be most usefully implemented
in C4::Context (or a separate more central module). The benefits of
caching that info would probably be even greater. Note that this
proposed implementation might be obsoleted by ORM integration, where
DB structure info would already be cached.
Owen Leonard [Mon, 6 Apr 2009 13:50:51 +0000 (08:50 -0500)]
Partial fix for Bug 2655, "Items waiting on the hold shelf display as 'Available' in OPAC"
GetItemsInfo() returns a count_reserves variable which may be "Waiting" or "Reserved," but opac-detail.pl didn't include a check for these possibilities. This patch has opac-detail.tmpl output "On hold" in either case.
Joe Atzberger [Tue, 7 Apr 2009 22:37:49 +0000 (17:37 -0500)]
orderreceive cleanup
Convert to GetBranchesLoop, remove unused variables.
Pull out params that are assigned the same value in each loop and just assign them once.
Pull out params that are assigned the same value in each half of the conditional, and just assign them unconditionally.
Remove useless call of $template->param($count).
Per discussion I had with Henri, removing experimental
bulk editing from the staff search results code, as
feature is incomplete and can be dangerous if
one tries to use it on a large search result
set.
If series title was previously taken as collectiontitle
then you should launch
misc/maintenance/UNIMARC_fix_collectiontitle.pl
misc/batchRebuildBiblioTables.pl
[RM note: applies only to UNIMARC users - MARC21
users should not run the batch jobs.]
Owen Leonard [Sat, 4 Apr 2009 15:19:33 +0000 (10:19 -0500)]
Another try at fixing Bug 2949.
This fix is in circulation.tmpl instead of the search box include. That eliminates the clash with returns.pl. Focus works correctly when checking out, when circulation.pl is at its "empty" state, and when patron selection form is displayed.
Joe Atzberger [Tue, 31 Mar 2009 20:08:10 +0000 (15:08 -0500)]
Bug 3066 - Overhaul guided reports
execute_query now refactored, returns reliable results, does
zero presentation-layer crap. Arguments reduced, client scripts
adapted to new API and performance improved. Text::CSV now used
to generate CSV output, ensuring portability, encoding and accuracy.
Joe Atzberger [Fri, 27 Mar 2009 15:34:33 +0000 (10:34 -0500)]
runreport.pl and prep work on Guided.pm
The old location of runreport.pl was under tools, leaving it exposed
to web requests. This is a security flaw since it does NOT check any
Auth and allows the user to request any Saved Report be run. This is
not a problem under misc/crontab/ and it suggests the more appropriate use.
Guided.pm is not fixed here (see bug 3066), but it is prepared to be fixed
and made compatible with runreport as detailed in the perldoc.
* On Amazon book cover, 'search inside' text is not displayed
anymore because it's not translatable.
* Link the image to local Amazon web site 'search inside' service.
Based on AmazonLocale syspref.
These changes tidy up ISBN and ISSN indexing, per Michele Maenpaa. It's being
set up manually on many new installations, and probably ought to become part of the default
Koha installation.
-idmap <filename> - optional output file of
map of source record ID numbers
to Koha biblionumber
-x - if idmap is supplied, MARC tag
to get source record ID from
-y - if idmap is supplied, MARC subfield
to get source record ID from
Modifications to C4/Matcher for colon and ending punctuation
Recommended by Michele Maenpaa, this adds handling colon and end-punctuation stripping
in subroutine _normalize, and fixes length testing in subroutine _get_match_keys
projects / koha.git / log