Bug 29554: Do not hide display of itemtypes on neworderempty
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 22 Nov 2021 13:00:57 +0000 (13:00 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Thu, 13 Oct 2022 14:24:26 +0000 (11:24 -0300)
commit2e650fdd0cb48c8120b66a4c5c6318f674d2801b
tree174ea9cced27eaae93e3a7d2bec7d6b25caeab41
parent938a76e62646cae9acc964ad8c8574df27f689d8
Bug 29554: Do not hide display of itemtypes on neworderempty

Hiding the list may lead to biblioitems.itemtype being NULL.
We do not want that, since 942$c is mandatory.

Test plan:
Create basket and set 'create items when' to receiving or
cataloging.
Create order from new empty record.
Check biblioitems.itemtype of created biblio.
Without this patch, it would have been NULL like this:
    select biblionumber,title from biblio;
    |            7 | Test 3                |
    select biblionumber,itemtype from biblioitems;
    |            7 | NULL     |

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
acqui/neworderempty.pl