From 07d8edefd9a477e65ba183afcd1a93274f0cec43 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Wed, 24 Aug 2022 11:23:25 +0100 Subject: [PATCH] Bug 29987: (follow-up) Fix missing payment type The payment type include has changed since the patch was first written, we now require a 'type' is passed to properly set the field name. This should fix the 'bankable' issue raised. Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit a0593924906b74f41c8b347469a3eaa558e400a1) Signed-off-by: Lucas Gass (cherry picked from commit 6d0af803146c7c1163ce518b8001312be40336f9) Signed-off-by: Arthur Suzuki --- .../prog/en/modules/members/mancredit.tt | 2 +- members/mancredit.pl | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt index 56db3becff..69f6820893 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/mancredit.tt @@ -69,7 +69,7 @@
  • Example: 5.00
  • - [% INCLUDE 'transaction_types.inc' %] + [% INCLUDE 'transaction_types.inc' type="credit" %] [% IF Koha.Preference('UseCashRegisters') %]
  • [% IF Koha.Preference('RequireCashRegister') %] diff --git a/members/mancredit.pl b/members/mancredit.pl index acc273eb77..2ba107a281 100755 --- a/members/mancredit.pl +++ b/members/mancredit.pl @@ -85,11 +85,11 @@ if ($add) { my $item = Koha::Items->find( { barcode => $barcode } ); $item_id = $item->itemnumber if $item; } - my $description = $input->param('desc'); - my $note = $input->param('note'); - my $amount = $input->param('amount') || 0; - my $type = $input->param('type'); - my $payment_type = $input->param('payment_type'); + my $description = $input->param('desc'); + my $note = $input->param('note'); + my $amount = $input->param('amount') || 0; + my $type = $input->param('type'); + my $credit_type = $input->param('credit_type'); my $cash_register_id = $input->param('cash_register'); $patron->account->add_credit( @@ -102,7 +102,7 @@ if ($add) { type => $type, user_id => $logged_in_user->id, interface => C4::Context->interface, - payment_type => $payment_type, + payment_type => $credit_type, cash_register => $cash_register_id } ); -- 2.39.5