From 0a41d247b57abe4a4eac25b40516653c3453bc6f Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fr=C3=A9d=C3=A9ric=20Demians?= Date: Sat, 15 Nov 2014 13:23:06 +0100 Subject: [PATCH] Bug 13242: Fix DateUtils for 'infinite' dates (ie year 9999) MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit TEST PLAN: - Method 1--with UT - Use the UT associated to this bug, without applying this patch, and then after applying this patch - Method 2--using Koha - Without this patch - Find a borrower with several checkouts that are not overdue. - Debarred the borrower - Go on circ/circulation-home.pl page - Select Check in tab, and do a check in - It required more than 20s to display the return.pl page - Apply the patch, and repeat previous steps => return.pl is immediately displayed. Followed method 2. Time problem no longer exists. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi --- Koha/DateUtils.pm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Koha/DateUtils.pm b/Koha/DateUtils.pm index 1de4000148..6c0a68e5ba 100644 --- a/Koha/DateUtils.pm +++ b/Koha/DateUtils.pm @@ -53,6 +53,11 @@ to the system preferences. If the date string is empty DateTime->now is returned sub dt_from_string { my ( $date_string, $date_format, $tz ) = @_; + + # FIXME: see bug 13242 => no TZ for dates 'infinite' + return DateTime::Format::DateParse->parse_datetime($date_string) + if $date_string =~ /^9999-/; + if ( !$tz ) { $tz = C4::Context->tz; } @@ -123,7 +128,8 @@ sub output_pref { return unless defined $dt; - $dt->set_time_zone( C4::Context->tz ); + # FIXME: see bug 13242 => no TZ for dates 'infinite' + $dt->set_time_zone( C4::Context->tz ) if $dt->ymd !~ /^9999/; my $pref = defined $force_pref ? $force_pref : C4::Context->preference('dateformat'); -- 2.39.5