From 112e2788c52e8d805735ae9eee7c606755994815 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 20 Aug 2020 11:49:08 +0200 Subject: [PATCH] Bug 18501: Fix QA issues FAIL Koha/Item.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). FAIL spelling Retreive ==> Retrieve appropriatly ==> appropriately somehwere ==> somewhere Signed-off-by: Jonathan Druart --- Koha/Item.pm | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/Koha/Item.pm b/Koha/Item.pm index 78c23dbab0..84ba2da33c 100644 --- a/Koha/Item.pm +++ b/Koha/Item.pm @@ -124,11 +124,12 @@ sub store { my %updated_columns = $self->_result->get_dirty_columns; return $self->SUPER::store unless %updated_columns; - # Retreive the item for comparison if we need to - my $pre_mod_item = $self->get_from_storage - if ( exists $updated_columns{itemlost} - or exists $updated_columns{withdrawn} - or exists $updated_columns{damaged} ); + # Retrieve the item for comparison if we need to + my $pre_mod_item = ( + exists $updated_columns{itemlost} + or exists $updated_columns{withdrawn} + or exists $updated_columns{damaged} + ) ? $self->get_from_storage : undef; # Update *_on fields if needed # FIXME: Why not for AddItem as well? @@ -785,7 +786,7 @@ sub renewal_branchcode { $self->_set_found_trigger Finds the most recent lost item charge for this item and refunds the patron -appropriatly, taking into account any payments or writeoffs already applied +appropriately, taking into account any payments or writeoffs already applied against the charge. Internal function, not exported, called only by Koha::Item->store. @@ -837,7 +838,7 @@ sub _set_found_trigger { my $patron = Koha::Patrons->find( $accountline->borrowernumber ); return $self unless $patron; # Patron has been deleted, nobody to credit the return to - # FIXME Should not we notify this somehwere + # FIXME Should not we notify this somewhere my $account = $patron->account; -- 2.39.5