From 297dbf4a5935931cdb8ebf6b9f00f60e291699df Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Tue, 30 Mar 2021 12:15:22 +0100 Subject: [PATCH] Bug 28053: Squash warning in C4::Members MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This patch sets guarantess_non_issues_charges to '0' upon creation of the variable and thus prevents 'Use of uninitialized value $guarantees_non_issues_charges in numeric gt (>) at /home/martin/kohaclone/C4/Members.pm line 183.' being thrown when the patron has guaruntees without any charges. Test plan 1. Run t/db_dependant/SIP/SIPServer.t and note the warning above is thrown at least once. 2. Apply the patch 3. Run the test again and note the warning has gone. Signed-off-by: Petro Vashchuk Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart --- C4/Members.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Members.pm b/C4/Members.pm index 72f9cbda81..f98ddecd43 100644 --- a/C4/Members.pm +++ b/C4/Members.pm @@ -175,7 +175,7 @@ sub patronflags { if ( defined $no_issues_charge_guarantees ) { my $p = Koha::Patrons->find( $patroninformation->{borrowernumber} ); my @guarantees = map { $_->guarantee } $p->guarantee_relationships; - my $guarantees_non_issues_charges; + my $guarantees_non_issues_charges = 0; foreach my $g ( @guarantees ) { $guarantees_non_issues_charges += $g->account->non_issues_charges; } -- 2.39.5