From 8084a70a3b13a87a516844ee7b7f3665aa8c1e95 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Thu, 25 Apr 2013 14:48:03 +0200 Subject: [PATCH] Bug 10110 Followup for Acquisition.pm Adding a FIXE at a line that uses $sth->{NAME} for possible utf8 problems. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Adds a comment, no danger from that. Signed-off-by: Jared Camins-Esakov --- C4/Acquisition.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm index b78a51e967..77010c5d5a 100644 --- a/C4/Acquisition.pm +++ b/C4/Acquisition.pm @@ -1192,6 +1192,9 @@ sub ModOrder { my $sth = $dbh->prepare("SELECT * FROM aqorders LIMIT 1;"); $sth->execute; my $colnames = $sth->{NAME}; + #FIXME Be careful. If aqorders would have columns with diacritics, + #you should need to decode what you get back from NAME. + #See report 10110 and guided_reports.pl my $query = "UPDATE aqorders SET "; foreach my $orderinfokey (grep(!/ordernumber/, keys %$orderinfo)){ -- 2.39.5