From 8343b56ab1f93dce3f3d58d7d10907e442be3125 Mon Sep 17 00:00:00 2001 From: Bernardo Gonzalez Kriegel Date: Wed, 27 Apr 2016 22:28:08 -0300 Subject: [PATCH] Bug 15451: (followup) fix filename extension for csv file This patch does the same as basket/downloadcart.pl to set '.csv' as filename extension for downloadshelf.pl To test: 1) Define a CSV MARC profile 2) On staff download a list, extension is '.NN' with 'NN' the CSV profile id. 3) Apply the patch 4) Download again, check extension is now '.csv' Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy --- virtualshelves/downloadshelf.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/virtualshelves/downloadshelf.pl b/virtualshelves/downloadshelf.pl index 4d1bde2854..d9881612b9 100755 --- a/virtualshelves/downloadshelf.pl +++ b/virtualshelves/downloadshelf.pl @@ -83,6 +83,10 @@ if ($shelfid && $format) { } } } + + # If it was a CSV export we change the format after the export so the file extension is fine + $format = "csv" if ($format =~ m/^\d+$/); + print $query->header( -type => 'application/octet-stream', -'Content-Transfer-Encoding' => 'binary', @@ -95,9 +99,6 @@ if ($shelfid && $format) { } else { push @messages, { type => 'error', code => 'does_not_exist' }; } - - # If it was a CSV export we change the format after the export so the file extension is fine - $format = "csv" if ($format =~ m/^\d+$/); } else { $template->param(csv_profiles => [ Koha::CsvProfiles->search({ type => 'marc' }) ]); -- 2.39.5