From 8cd6017020b4a9e4b4252b95e5055b37cf2a5be0 Mon Sep 17 00:00:00 2001
From: Tomas Cohen Arazi <tomascohen@theke.io>
Date: Mon, 4 Jan 2021 10:35:37 -0300
Subject: [PATCH] Bug 27327: Get rid of indirect object notation in
 Koha::Club::Hold

This patch makes the code follow the PERL29 coding guideline. Period.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 17a3476d7e45fae092fdd20ce78df8b0945d1fb1)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 6f3f1366d7ec18c8990a1577e87a6bf0da8bfa40)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
---
 Koha/Club/Hold.pm | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/Koha/Club/Hold.pm b/Koha/Club/Hold.pm
index 39a58dc7d4..df8be67de2 100644
--- a/Koha/Club/Hold.pm
+++ b/Koha/Club/Hold.pm
@@ -54,17 +54,21 @@ Class (static) method that returns a new Koha::Club::Hold instance
 sub add {
     my ( $params ) = @_;
 
-    throw Koha::Exceptions::ClubHold unless $params->{club_id} && $params->{biblio_id};
+    Koha::Exceptions::ClubHold->throw()
+        unless $params->{club_id} && $params->{biblio_id};
+
     my $club = Koha::Clubs->find($params->{club_id});
     my @enrollments = $club->club_enrollments->as_list;
-    throw Koha::Exceptions::ClubHold::NoPatrons() unless scalar @enrollments;
+
+    Koha::Exceptions::ClubHold::NoPatrons->throw()
+        unless scalar @enrollments;
 
     my $biblio = Koha::Biblios->find($params->{biblio_id});
 
     my $club_params = {
-        club_id => $params->{club_id},
+        club_id   => $params->{club_id},
         biblio_id => $params->{biblio_id},
-        item_id => $params->{item_id}
+        item_id   => $params->{item_id}
     };
 
     my $club_hold = Koha::Club::Hold->new($club_params)->store();
-- 
2.39.5