From a3082158e46cf643c99721052268e762e7050868 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Thu, 5 May 2016 15:25:50 +0100
Subject: [PATCH] Bug 16449: Remove "no method selected" warning from
 unimarc_field_4XX

Because of bug 14828, the unimarc_field_4XX now raises a warning:
"No method selected!"

There are no need to select an item type on this page, the default (all)
is always selected.

Test plan:
Link the unimarc_field_4XX value builder with on of the subfield
Edit a record, click on the value builder icon
Note the warning without the patch and that it's gone with the patch
applied

NOTE: Code fix that I derived was identical. Ran
 prove t/db_dependent/FrameworkPlugin.t
to confirm it works.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
---
 .../en/modules/cataloguing/value_builder/unimarc_field_4XX.tt | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt
index 458c199db2..b784c3adb4 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt
@@ -129,11 +129,7 @@
 				<select name="itype" id="itypeloop">
                 <option value="">All item types</option>
 				[% FOREACH itypeloo IN itypeloop %]
-				[% IF ( itypeloo.selected ) %]
-                <option value="[% itypeloo.itemtype %]" selected="selected">[% itypeloo.description |html %]</option>
-				[% ELSE %]
                 <option value="[% itypeloo.itemtype %]">[% itypeloo.description |html %]</option>
-				[% END %]
 				[% END %]
 				</select>
 			</p>
-- 
2.39.2