From d847b1d92a9df6db2bb5321f032f3ec13d6ba55d Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@biblibre.com>
Date: Wed, 22 Apr 2015 12:14:24 +0200
Subject: [PATCH] Bug 10866: Hide patron's history if intranetreadinghistory is
 set to not allow
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

If set to "not allow", the intranetreadinghistory pref prevent staff
members to access patron's checkout history.
But:
1/ The page is still accessible if you know the url
2/ The history can be consulted on the item history page

Test plan:
0/ Don't apply this patch
1/ Set the intranetreadinghistory to allow
2/ Go on a patron's checkout history page
3/ Open a new tab and go on a item's checkout history page
4/ Set the intranetreadinghistory to not allow
5/ Refresh both pages => no change
6/ Apply this patch
7/ Refresh both page.
On the first page, you should see a warning
On the other one, you should see that the patron column is not displayed
anymore.

Followed test plan, results were as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

http://bugs.koha-community.org/show_bug.cgi?id=10886
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Nice addition!
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
---
 .../prog/en/modules/catalogue/issuehistory.tt | 26 +++++++++++--------
 .../prog/en/modules/members/readingrec.tt     |  4 ++-
 2 files changed, 18 insertions(+), 12 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt
index 7b6483c9bf..89531f438e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt
@@ -1,3 +1,4 @@
+[% USE Koha %]
 [% USE KohaDates %]
 [% INCLUDE 'doc-head-open.inc' %]
 <title>Koha &rsaquo; Catalog &rsaquo; Checkout history for [% title |html %]</title>
@@ -7,13 +8,12 @@
 <script type="text/javascript" id="js">
 $(document).ready(function() {
     $("#table_issues").dataTable($.extend(true, {}, dataTablesDefaults, {
-            "aoColumns": [
-                null,null,null,null,{ "sType": "title-string" },{ "sType": "title-string" },{ "sType": "title-string" }
-            ],
-            "aaSorting": [[ 4, "desc" ]],
-            "sPaginationType": "full_numbers"
-        })
-    );
+        "aoColumnDefs": [
+            { "sType": "title-string", "aTargets" : [ "title-string" ] }
+        ],
+        "aaSorting": [[ 4, "desc" ]],
+        "sPaginationType": "full_numbers"
+    }));
 }); </script>
 
 </head>
@@ -38,18 +38,22 @@ $(document).ready(function() {
         <h4>Checked out [% total %] times</h4>
         <table id="table_issues">
             <thead><tr>
+            [% IF Koha.Preference('intranetreadinghistory') %]
             <th>Patron</th>
+            [% END %]
             <th>Barcode</th>
             <th>Checked out from</th>
             <th>Renewed</th>
-            <th>Checkout on</th>
-            <th>Due date</th>
-            <th>Checkin on</th>
+            <th class='title-string'>Checkout on</th>
+            <th class='title-string'>Due date</th>
+            <th class='title-string'>Checkin on</th>
             </tr></thead>
             <tbody>
         [% FOREACH issue IN issues %]
-        [% UNLESS ( loop.odd ) %]<tr class="highlight">[% ELSE %]<tr>[% END %]
+            <tr>
+                [% IF Koha.Preference('intranetreadinghistory') %]
                 <td><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% issue.borrowernumber %]">[% IF HidePatronName %][% issue.cardnumber %][% ELSE %][% issue.surname %][% IF ( issue.firstname ) %], [% issue.firstname %][% END %][% END %]</a></td>
+                [% END %]
                 <td>[% IF ( issue.barcode ) %]
                         <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% issue.biblionumber %]&amp;itemnumber=[% issue.itemnumber %]">[% issue.barcode %]</a>
                     [% ELSE %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
index e24ff7c42f..6fb109e3de 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
@@ -48,7 +48,9 @@
 [% INCLUDE 'members-toolbar.inc' %]
 <h1>Circulation history</h1>
 
-[% IF is_anonymous %]
+[% UNLESS Koha.Preference('intranetreadinghistory') %]
+    <div class="dialog alert">Staff members are not allowed to access patron's checkout history</div>
+[% ELSIF is_anonymous %]
     <div class="dialog alert">This is the anonymous patron, so no circulation history is displayed. To get a list of anonymized loans, please run a report.</div>
 [% ELSIF ( !loop_reading ) %]
     <div class="dialog message">This patron has no circulation history.</div>
-- 
2.39.5