From df301bff9dc23863e6c9d0e1941f64c176e906f7 Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Mon, 11 Jun 2018 15:28:19 +0000
Subject: [PATCH] Bug 20911: Use 'POST' to submit search history forms

To test:
1 - Enable EnableOpacSearchHistory and EnableSearchHistory
2 - Do some searches
3 - View your search history in staff/opac
4 - Confirm you can delete single or multiple rows
5 - Confirm other page functionality has not changed

Signed-off-by: Ed Veal <eveal@mckinneytexas.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit e4c26c44d3c70cf62225361a4cce94e1f5aa16c8)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 .../prog/en/modules/catalogue/search-history.tt           | 8 ++++----
 .../opac-tmpl/bootstrap/en/modules/opac-search-history.tt | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt
index a1bcd46258..75201337b8 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt
@@ -30,7 +30,7 @@
         <div id="biblio_tab">
           [% IF ( current_biblio_searches ) %]
             <h2>Current session</h2>
-            <form action="/cgi-bin/koha/catalogue/search-history.pl" method="get">
+            <form action="/cgi-bin/koha/catalogue/search-history.pl" method="post">
               <div class="selections-toolbar">
                 <a class="CheckAll" href="#"><i class="fa fa-check"></i> Select all visible rows</a>
                 <span class="sep">|</span>
@@ -67,7 +67,7 @@
 
           [% IF ( previous_biblio_searches ) %]
             <h2>Previous sessions</h2>
-            <form action="/cgi-bin/koha/catalogue/search-history.pl" method="get">
+            <form action="/cgi-bin/koha/catalogue/search-history.pl" method="post">
               <div class="selections-toolbar">
                 <a class="CheckAll" href="#"><i class="fa fa-check"></i> Select all visible rows</a>
                 <span class="sep">|</span>
@@ -110,7 +110,7 @@
         <div id="authority_tab">
           [% IF ( current_authority_searches ) %]
             <h2>Current session</h2>
-            <form action="/cgi-bin/koha/catalogue/search-history.pl" method="get">
+            <form action="/cgi-bin/koha/catalogue/search-history.pl" method="post">
               <div class="selections-toolbar">
                 <a class="CheckAll" href="#"><i class="fa fa-check"></i> Select all visible rows</a>
                 <span class="sep">|</span>
@@ -147,7 +147,7 @@
 
           [% IF ( previous_authority_searches ) %]
             <h2>Previous sessions</h2>
-            <form action="/cgi-bin/koha/catalogue/search-history.pl" method="get">
+            <form action="/cgi-bin/koha/catalogue/search-history.pl" method="post">
               <div class="selections-toolbar">
                 <a class="CheckAll" href="#"><i class="fa fa-check"></i> Select all visible rows</a>
                 <span class="sep">|</span>
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
index d8d6c579b3..f1bc446f3e 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
@@ -43,7 +43,7 @@
                             <div id="current_biblio">
                                 [% IF ( current_biblio_searches ) %]
                                     <h2>Current session</h2>
-                                    <form action="/cgi-bin/koha/opac-search-history.pl" method="get">
+                                    <form action="/cgi-bin/koha/opac-search-history.pl" method="post">
                                         <div class="selections-toolbar toolbar">
                                             <a class="CheckAll" href="#">Select all</a>
                                             <a class="CheckNone" href="#">Clear all</a>
@@ -82,7 +82,7 @@
                             <div id="previous_biblio">
                                 [% IF ( previous_biblio_searches ) %]
                                     <h2>Previous sessions</h2>
-                                    <form action="/cgi-bin/koha/opac-search-history.pl" method="get">
+                                    <form action="/cgi-bin/koha/opac-search-history.pl" method="post">
                                         <div class="selections-toolbar toolbar">
                                             <a class="CheckAll" href="#">Select all</a>
                                             <a class="CheckNone" href="#">Clear all</a>
@@ -128,7 +128,7 @@
                             <div id="authority_tab">
                                 [% IF ( current_authority_searches ) %]
                                     <h2>Current session</h2>
-                                    <form action="/cgi-bin/koha/opac-search-history.pl" method="get">
+                                    <form action="/cgi-bin/koha/opac-search-history.pl" method="post">
                                         <div class="selections-toolbar toolbar">
                                             <a class="CheckAll" href="#">Select all</a>
                                             <a class="CheckNone" href="#">Clear all</a>
@@ -165,7 +165,7 @@
 
                                 [% IF ( previous_authority_searches ) %]
                                     <h2>Previous sessions</h2>
-                                    <form action="/cgi-bin/koha/opac-search-history.pl" method="get">
+                                    <form action="/cgi-bin/koha/opac-search-history.pl" method="post">
                                         <div class="selections-toolbar toolbar">
                                             <a class="CheckAll" href="#">Select all</a>
                                             <a class="CheckNone" href="#">Clear all</a>
-- 
2.20.1