From e7d202cbd3508839233cdd841759292fa589b8bd Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 4 Dec 2012 15:32:28 -0300 Subject: [PATCH] Bug 9211 - days_between wrong behaviour MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit As noted in comments #15, #16 and #17 of bug 8486, and its API, Koha::Calendar->days_between should always returns a positive number irrespective of the relative order of the parameters. This is still an open bug, which arised when rewriting the Calendar.t file (Bug 9209). Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Added Paul's sign-off line, as despite it showing up in Bugzilla, it wasn't on the patch. --- Koha/Calendar.pm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Koha/Calendar.pm b/Koha/Calendar.pm index 45841beeb9..6a1253013b 100644 --- a/Koha/Calendar.pm +++ b/Koha/Calendar.pm @@ -247,6 +247,13 @@ sub days_between { my $start_dt = shift; my $end_dt = shift; + if ( $start_dt->compare($end_dt) > 0 ) { + # swap dates + my $int_dt = $end_dt; + $end_dt = $start_dt; + $start_dt = $int_dt; + } + # start and end should not be closed days my $days = $start_dt->delta_days($end_dt)->delta_days; -- 2.39.5