From e81756b317da848a6e6346a7c0db8f3b986f7058 Mon Sep 17 00:00:00 2001 From: Colin Campbell Date: Thu, 27 Sep 2018 12:25:28 +0100 Subject: [PATCH] Bug 21425: Display basketno correctly in Order error msg carp will display the hash value instead of the desired basketno in the error message unless we change its behaviour Use the simpler but effective option of concatenating the errormessage with the basketno. Error is shown if no sender or receipient ean is passed in instantiating an Koha::Edifact::Order object Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens --- Koha/Edifact/Order.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Koha/Edifact/Order.pm b/Koha/Edifact/Order.pm index dcab51dede..9822526a3b 100644 --- a/Koha/Edifact/Order.pm +++ b/Koha/Edifact/Order.pm @@ -60,13 +60,13 @@ sub new { return; } if ( !$self->{recipient} ) { - carp -"No vendor passed to order creation: basket = $self->{basket}->basketno()"; + carp 'No vendor passed to order creation: basket = ' + . $self->{basket}->basketno; return; } if ( !$self->{sender} ) { - carp -"No sender ean passed to order creation: basket = $self->{basket}->basketno()"; + carp 'No sender ean passed to order creation: basket = ' + . $self->{basket}->basketno; return; } -- 2.39.5