label-home.pl - Fix major error causing deletion on every run. Corrected variable scope to avoid warnings.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Auth.pm should have "CAN_user_updatecharges" (plural), and this change to InstallAuth.pm should catch it.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Change to patron-renewal javascript to fix issues described in Bug 1620

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing typo in value_builder/dateaccessioned.pl; Adding error message output to additem.tmpl (fixes Bug 1636, Can't delete from additems.pl).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Moving "Check Out" from the action toolbar to the view menu

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing parameters permission requirement on about.pl, minor markup change to member-flags.tmpl.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Members.pm - respond to $debug, some formatting and reduction of duplicative code.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Auth.t - running this test will fail unless Auth.pm patches get trough.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Auth_with_ldap : module and test final touches.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

moremember.pl - Dates.pm "syspref" made explicit. Scripts should not call C4::Context->preference('dateformat').

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

LDAP - further integration

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Dates.pm - ongoing integration, acqui/histsearch.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Log.pm: reduce duplicative code in conditional

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Auth.pm -- just the start of trying to make Auth intelligible and extensible

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Dates.pm -- Comment and perldoc cleanup.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Big LDAP changes, module test for Context.pm, still more yet to come.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding back CDATA for validation

Context.pm: obvious code consolidation, perldoc corrections.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing virtual shelves (unfinished)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Letters.pm: Minor change. Unsure if this is "the right" move, but pretty sure the line does not make sense as is.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changes to address Bug 774 (z3950 search results window not resizable)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changes to fix Bug 1335 (Min password length is hardcoded in template error message). Script now checks for passes to the template the value of minPasswordLength system preference so the user knows beforehand what the requirements are, and so that the error message can contain the correct value.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Passing "adultborrower" variable to the template so that "Add Child" button can be displayed in the toolbar when appropriate. Fixes Bug 1510.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Corrections to page title, breadcrumbs, heading

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changes to image-load check (used for patron images and amazon book covers) to tweak when the script checked for loaded images (now window.load() instead of document.ready())

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Finishing changes to sidebar menu (change to boraccount.pl, as with moremember.pl, is to add flag so that menu can highlight current page).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing some menu formatting

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Minor corrections to form layouts

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Trying again for layout fixes and template corrections for opac-advsearch.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding "clearfix" class, used to add clearning to element without use of break or other additional markup.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix to get this working with the modules in 3.0

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bib_profile web svc: report biblioitems.itemtype subfield as non-mandatory

Per discussion with Chris Catalfo, biblios will optionally
supply this subfield (942$c) but is not required to do so,
as Koha automatically creates the biblioitem anyway.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing dateaccessioned plugin

Bug 1620

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing debugging from javascript, accidentally comitted.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Some fixes for "delete" menu items in toolbars to ensure that redirects are handled properly. Adding borrowernumber hidden field to some templates in order to enable delete button on all member-related pages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changes to CSS to allow for bug 1357 fix. Trying again after previous patch wouldn't apply

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Trying again on some changes that wouldn't patch earlier

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1632

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Uncommenting delete code as deleting now works fine

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix minor XHTML validation issues

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for re-enrollment not working

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for renewing

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for missing toolbar on member pages

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1575

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

disable actions in moremember based on staff_access permission

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Add Staff member type. Add permissions checks for bug# 1269

and related permissions on memberentry and mods.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding userflag to allow modification of staff borrowers.

will add Staff category type in subsequent commit

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Slight mod to getuserflags and haspermission in prep for perms bugfix

Also adding some pod

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding Staff Borrower to handle Bug 1269

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

warn on attempts to add duplicate item barcodes during batch import

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1615: AddItem() now sets issues, renewals, and reserves

When an item was created,  the renewals, issues, and reserves columns
were not set from the MARC data.  This was noticed particularly
in the context of batch loads, where a user might supply
data for those fields.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bumped up MARC Perl module requirements

MARC::File::XML => 0.88 as part of fixing bug 1504
in turn MARC::Charset => 0.98 and MARC::Record => 2.00.

Previous required version of MARC::Record was 1.38, but
since that is three years old, assuming that most Koha
3.0 dev and testing has been done with version 2.0.0.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1570: return to same tab if cancelling preference edit

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Shouldn't opac-advsearch use masthead as other templates ?

Anyway, masthead-basic is badly broken atm

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing layout of guarantor display/search and correcting javascript handling of those form fields.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

A few corrections, reformatting display slightly

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Some changes to unimarc record.abs

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bug fixing : infinite loop when repeated operator + distinguishing operators

limits would provide with unnecessary repeated "and"
Thus causing wild loop
So removing them.
aud was transformed into author when it qualified audience.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

small fix in README.txt

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bug Fixing : NZsearch

parenthesis introduce a priority.
yr:XXXX-YYYY is now processed correctly.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

changing haspermission() to require that user has ALL requiredflags, not ANYOF requiredflags

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

UNIMARC specific : itemtype is now known as itype

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

it appears that hidelostitems can be true here and not set to 1 in syspref

in syspref it appears as "OFF", but in opac-search it's considered as true.
Changing the test to be sure syspref & opac-search consider the same thing

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

HTML::Template => HTML::Template::Pro

HTML::Template is no more used, some were remaining,
fixing the "use ...;" to H::T::Pro only

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

merging in changes to staff css

adding yellow style for search term

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

when the result has an author as search term, the link contained the <span style="term"> in it

this fix add a author_nospan, that contains the author in it's native form

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

material type is mc, not mt, synch'ing opac with staff

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1613 making sure the zebraqueue is updated when an item is

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed extraneous warns

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bugfix: do not store item tags when saving old copy of bib

If a MARC batch was imported, then reverted, the 952s
from the saved copied of the bib were added back
when the bib was replaced, leading to duplication

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Change from kados to XISBN.pm ("handle no response from ThingISBN"), and change to similar items markup in detail.tmpl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Trying new format for OPAC resident search bar and menus. Also making correction to opac-detail similar items markup, although it's probably still not working yet.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

If LibraryName was not specified, the opac layout was broken. Adding a default ("Koha Online Catalog") to the template in case LibraryName is empty.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Minor style tweaks here and there.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More work on returns messages.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Focusing Check-In tab on returns.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing problem with adv search on staff client

Issue was that language limit was being set with a
relation (=) but no operand

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1614: revise GetMarcItem so that info dervies from items table

This should help make the items table more authoritative, and ensures
that the items editor does not blank circulation fields such as
issues.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Continuing reformatting of returns.tmpl; Correcting javascript error in request.tmpl.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Attempting to pretty up confirmations and messages in returns; Adding some variables to the template output; Fixing layout in circulation.tmpl for patrons without messages; Minor correction to OPAC css.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Tweaking display of MARC records in the OPAC

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Correcting breadcrumbs

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding auto-fill links for variable types

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Minor changes to systempreferences markup, including re-adding edit link on system pref variable, very helpful if the display runs off the right side of the screen.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Moving holdings, description, editions, and related into tabs, enabling AmazonSimilarItems global preference for the staff client (but not working?)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Incremental changes to reviews, similar items

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

improved terminology for WITHDRAWN authorized value

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bugfix: handle subfield $0 in MARC for an item

Note: C4::Biblio::GetMarcFromKohaField returns (0, 0) if
the kohafield is not defined in the MARC framework, but
in may places the return value is not checked correctly
and does not recognize a subfield $0 (zero).  It
would be better if GetMarcFromKohaField returned (undef, undef)
in that circumstance, but because of the number of places
where that function is used, the changed is deferred for
post 3.0.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1616: handle NULL in damaged, wthdrawn, or itemlost columns

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

MARC21 framework: changed 'items.withdrawn' to 'items.wthdrawn'

The correct field is 'items.wthdrawn', not 'items.withdrawn'.
Spelling may be corrected in post-3.0 version.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1616: update bib MARC and zebraqueue on item update

Fixed so that when using updateitem.pl to change an
item's lost, damaged, or withdrawn status, the
bib's MARC XML is updated and an entry is added
to zebraqueue.

As part of the fix, C4::Biblio::ModItemInMarconefield
now works correctly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding template code for AmazonSimilarItems et al

Test this by having the following ISBNs in your system:

0152018484
0152053530

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing langauge limit indexes were removed

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

MARC import: part 6 of large file support

Added background job and AJAX progress updates
to MARC commit job.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

MARC import: part 5 of large file support

Staging job now gets moved to background so that
it does not get killed if it takes longer
than the Apache timeout.

Added AJAX monitoring of job status.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

C4::UploadedFile -- simplified serialization

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

MARC import: part 4 of large file support

* Added C4::BackgroundJob to monitor tracking of
  background jobs
* start modifying stage-marc-import to use it

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More work on editions in the OPAC; Need both a staff client and OPAC system pref for turning on and off XISBN stuff.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>