fix for bug 1688

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

expandtab, retab, tabstop=4

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Revert "Merging hdl's Search.pm changes"

This reverts commit 51ec728f7b358b8ca4ef8f3cdd44cb976d907b90.

That commit basically reverted 95% of the status handling I'd done
last week ...

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

retab with tabstop=4 and expandtab on

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Warning: Big Commit. Fixing Virtual Shelves

  * prior to this commit, virtual shelvesn't did not function in
    the OPAC! Now they do, except for deletion from virtual shelves
    in list form
  * I've re-named 'Virtual Shelves' to 'Lists' as per our agreed
    upon convention

  * while vshelves aren't perfect yet, they're in enough of a working
    state for the RC1 now

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding ports information

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Minor correction to template markup and change to script to allow for more clickable <label>s.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

allow use of older version of File::Temp

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more updates to README.debain

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed invocation of zebraqueue_daemon.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

circ: do not crash when 'returning' item that was not issued

When attempting to return an item that was not actually
on loan, would crash because GetItemIssue did not return
biblionumber in hash.  Add call to get biblionumber
directly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixes to README.debian

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding a note on how to remove zebra daemons from startup

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed extra KOHA_CONF line

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

various installer changes

[1] Map new directory misc/bin to SCRIPT_DIR
    instead of SCRIPT_DIR/bin.
[2] rewrite-config.PL no longer removes execute mode
[3] Add new Zebra startup script to rewrite-config.PL
    list.
[4] Added KOHA_USER and KOHA_GROUP to rewrite-config.PL

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Several important commits:

  * adding zebra daemons for managing server and queue processes
  * improvements to the README.debian file
  * Fixes to Search.pm since last series of commits broke zebra-based
    searching (again)
  * moving some files to new misc/bin and misc/cronjobs

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding debian-specific installation guide

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

nomenclature improvements, updating README.txt

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

missing < in about page

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updating versions for debian etch packages

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing version numbers in Makefile.PL, adding a

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for Bug 1685, if patronimages syspref is off, tabs disappear from moremember.pl. Renegade TMPL_IF taken out.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

In response to paul's comment: "one user that just tested is confused by the green & red signs, and think it would be better to remove them (they thought "green" was = OK, confirm creation and "red" = oops, I made a mistake, it's a duplicate)"

I've taken out the check and the X and replaced them with "edit" and "save" icons from the toolbars. Less confusing?

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Merging hdl's Search.pm changes

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding some image files missing from yesterday's commit; Correcting patron image javascript in circ and moremember; Adding cardnumber to moremember display.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Revert "Adding cardnumber to page display"

This reverts commit c71fcc2dc501c57b7348ec6a349c3929cfa33174.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Rolling back changes made to NZ search elements

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

s/Civility/Salutation/

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

french translation updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

in addbooks, after searching, let a user view a biblio (before editing)

the edit button is still here, just adding a MARCdetail.pl one

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

textmessaging field has been renamed to opacnotes in v3

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding tab management for auth-subfield, like the one we have for biblio_subfield

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

breadcrumb is better when keeping track of the tag

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

staff french translation updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

some changes in blue.css for marc editor

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

2 questions in 2 lines, confusing for users.

+ one user that just tested is confused by the green & red signs, and think it would be better to remove them
(they thought "green" was = OK, confirm creation and "red" = oops, I made a mistake, it's a duplicate)

I didn't remove the pictures, but let me know your opinion on this.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

s/borrowernumber/cardnumber/ : we are showing the cardnumber here

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

s/title/civility/

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

french staff translation updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more _() strings

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding some missing _()

In fact, it WORKS for translator. ignore my previous comment about it not working.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

the term "framework" here is useless + it causes some trouble for translation

(should we have it after or before the framework name ?)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

merging title & author column for a better look

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

changing a text we already had the same string in a different context

translating was impossible in the 2 contexts

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

changing some strings for a better translation

(no change for english ppl)

+ removing an orphan <h2>

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding _() to strings for translator

Note that it DOES not work as expected. It seem that the translator misses the _() string inside expandable button
(it does not miss them in simple button)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding a color to approve and deny button to avoid white on white

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updating perl mod version

fixing zebra searching after recent commits

Fixing a problem that was causing double conversion of dates

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Online help for label printing and serials

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

import_borrowers.pl - convert dates BEFORE AddMember or ModMember

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

borrowers_details - needs format_date

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing link under active settings to add items to batch

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Initial fix for NoZebra advanced search problems when searching with no query and only limits (ie. itemtype)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

installer: improvements to fix-path-perl.PL on Win32

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1664: added specific dep on Algorithm::CheckDigits::M43_001

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1661: rebuild_zebra.pl changes

[1] Use File::Temp to create and manage
    export directory if -d is not specified.
[2] Added usage message.
[3] Code that attempts to fix up Zebra
    configuration files changed so that it
    is invoked only if --munge-config option
    is supplied; this code will ultimately
    either be removed or moved to a separate
    script -- the sorts of errors that it
    tries to fix should no longer be appearing
    in a standard install.
[4] Fixed Win32 portability problem when removing
    temporary directory.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Members overhaul for Dates.pm - Stop double converts and disappearing expiration mods.

Allow errors displayed by memberentrygen.  Please confirm with add'l tests, feedback.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Online Help for adding a new subscription - taken from KohaDocs.org

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Change to breadcrumb to point Serials home to correct page

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding online help for Staff Client homepage - how to edit online help

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Copying in online help for virtual shelves from the Documentation

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding online help for Reports Home

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Online Help for Serials Home

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

C4::Dates - carp if passed semantically invalid date

When creating a new C4::Dates object, now carps
if the supplied date and/or time is semantically
invalid, i.e., 2007-01-32 will pass the regex
check but is not a valid date (there being no
32nd of January).

As the C4::Dates API is nailed down, these may
be converted to croaks in the future.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Buttons. Toolbar icons and generic "submit" style.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding auto-submit to filter form.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

autocomplete.css - unclosed comment error removed

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

use syspref date format for manual due date

NOTE: will fail if user manages to enter date
in wrong format.  This is not a change from before
this patch, but is pointed out.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

use standard template var for DHTML date format

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix to update onloan to 0 even if the item isnt out to a borrower

Bug 1681

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Dates.pm - IMPORTANT fix for dmy_array (part of obejct, not class)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

members.js - purely whitespace edit (I was debugging the conditionals).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Members.pm - checkuniquemember minor refactor and perldoc correction.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding rebuild field 100$a for Unimarc

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding cardnumber to page display

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BUG Fixing : NoZebra search

Bug fixing search on alphanumeral string such as EN0 couldnot work.
Bug fixing AND would be too much restrictive on results (required count of occurence of search criteria to be the same).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

SearchNZ : multiple words AND was an OR

my $biblionumbers was badly placed
renaming operand into operator

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Translation end.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Generating index for authorities on AUTHtypecode from table auth_header

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Some more translations.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adapting things to new API

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding 100$a coded field for UNIMARCAUTH and 152$b for any add

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix new installer on macosx.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixes to search results list, ccl.properties tweak

patch updateitem.pl (was failing ... missing 'my')
update OPAC results
fix limit by availability

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed superfluous and unclosed TMPL_IF

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

2nd try:Fixed buggy NoZebra cataloguing search when search term does not exist in any record.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixed buggy NoZebra cataloguing search when search term does not exist in any record.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Even more applying standard dialog styles to confirmation messages. Also fixing alternating table row colors in stopwords.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More applying standard dialog styles to confirmation messages

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1427

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix bad behaviour of Label Batches table when Generate PDF link is clicked in staff client.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing white spaces from directory and filenames as they restrict portability across OS platforms.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removed hardcoded paths to yui libs

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BugFix : authorities resultlist display was missing one item on end of list.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BUG Fixing : invalid dates would make Serials die ungracefully

GetNextSeq calls to Date::Calc is now caught in evals so that invalid dates would not make it die.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

viewlog.tmpl + calendar.inc: builds Date_from_syspref javascript function.

This is likely the durable fix to bridge the gap between syspref on the server
and client side validation scripts.  It may be useful to separate Date_from_syspref
from the calendar js, but at this time their applicability is 1-to-1.
Note also js debug variable and CGI param('debug') responsiveness.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

viewlog.pl - fixes bug 1657, passes DHTMLcalendar_dateformat

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

memberentry.pl - fixes inappropriate use of map in void context, tweaks debug for CGI

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>