]> git.koha-community.org Git - koha.git/log
koha.git
15 years agobug 2682: followup - only do lc() on $op once
Galen Charlton [Thu, 23 Oct 2008 21:07:19 +0000 (16:07 -0500)]
bug 2682: followup - only do lc() on $op once

Per suggestion by Joe Atzberger.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 2682 ("Approving Multiple Tags - Doesn't Work"). Processing based on...
Owen Leonard [Wed, 15 Oct 2008 15:36:32 +0000 (10:36 -0500)]
Fix for Bug 2682 ("Approving Multiple Tags - Doesn't Work"). Processing based on value of submit buttons didn't take into account capitalization.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUnravelling links in masthead. Regularize logic and improve readability.
Joe Atzberger [Fri, 19 Sep 2008 21:24:22 +0000 (16:24 -0500)]
Unravelling links in masthead. Regularize logic and improve readability.

Link to Tag Cloud displayed on Adv. Search page even when TagsEnabled was OFF.
This was due to unnecessary duplicative code for Adv. Search vs. other pages.
Note: with this revision, the link to "Advanced Search" will display on all pages,
even on the Advanced Search page itself.  This is in fact desirable, rather than
the set of links collapsing and changing position depending on page being viewed.
If the old premise were to be followed (that Adv. Search link should not display on its
own page), then the same interface sensibility should apply to ALL links in the
masthead: i.e., Tag Cloud link should not display on its own page, same for Browse
by Subject, Most Popular, etc.  I would argue even this is undesirable.  At most,
give the links in moresearches some IDs and let each page unlink/restyle the
"current" link with jquery.  IMHO, masthead itself should not be engage in such trifling
interface polishes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug #2709 Cannot add from Search to New list
Allen Reinmeyer [Thu, 23 Oct 2008 19:16:18 +0000 (14:16 -0500)]
Bug #2709 Cannot add from Search to New list

While a new list was created, no subsequent call to add the biblio number was made,
thus a new empty list would be created every time.
Under the existing list add, the same code to add items would also apply to a new list,
so I refactored out the logic to add items and made a new subroutine.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup to Calendar overhaul
Galen Charlton [Thu, 23 Oct 2008 17:34:05 +0000 (12:34 -0500)]
followup to Calendar overhaul

correct an errant "SELECT FROM" that slipped in

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBegin Calendar overhaul, turn on warnings.
Joe Atzberger [Fri, 19 Sep 2008 00:02:47 +0000 (19:02 -0500)]
Begin Calendar overhaul, turn on warnings.

Reuse SQL with placeholders where possible.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2543: follow-up patch
Galen Charlton [Thu, 23 Oct 2008 17:05:56 +0000 (12:05 -0500)]
bug 2543: follow-up patch

Add 'use C4::Reports' lines that original patch
omitted.

Note that original patch prevented these two reports
from even compiling.  Not good.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for bug 2543: report output by tabulation a bit too literal
Jesse Weaver [Wed, 10 Sep 2008 00:31:31 +0000 (19:31 -0500)]
fix for bug 2543: report output by tabulation a bit too literal

This repurposes the Reports module for general reports, and moves its functionality to a different module, Reports::Guided. It also updates all of the reports that can export to correctly treat the 'tabulation' value of the 'delimiter' syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPatch security hole in vestigial report.
Joe Atzberger [Thu, 23 Oct 2008 16:01:03 +0000 (11:01 -0500)]
Patch security hole in vestigial report.

IMHO, this report should be removed in entirity because of its faulty
construction and total inability to distinguish between register "tills".
That is, it appears to be a valid accounting measure but isn't.
In any case, it let's not let just anybody run it!

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSteamlining javascript for cloning additem block and tweaking style.
Henri-Damien LAURENT [Wed, 12 Nov 2008 14:04:57 +0000 (15:04 +0100)]
Steamlining javascript for cloning additem block and tweaking style.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding some body IDs to OPAC pages to enable finer per-page control via CSS.
Owen Leonard [Fri, 17 Oct 2008 14:19:12 +0000 (09:19 -0500)]
Adding some body IDs to OPAC pages to enable finer per-page control via CSS.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoChanging checkboxes to radio buttons (as it is in the OPAC), since you can't place...
Owen Leonard [Mon, 20 Oct 2008 15:42:59 +0000 (10:42 -0500)]
Changing checkboxes to radio buttons (as it is in the OPAC), since you can't place a hold on more than one specific item. Also includes some markup cleanup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoShow card number (non-editable) on opac-userupdate.pl. Also correctly formatting...
Owen Leonard [Fri, 17 Oct 2008 14:19:24 +0000 (09:19 -0500)]
Show card number (non-editable) on opac-userupdate.pl. Also correctly formatting expiration date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago1571
John Beppu [Wed, 22 Oct 2008 20:34:06 +0000 (15:34 -0500)]
1571

made the description show up by running the query w/ the required number of params

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug #2030 z3950 search function does not filter
Allen Reinmeyer [Wed, 22 Oct 2008 17:20:49 +0000 (12:20 -0500)]
Bug #2030 z3950 search function does not filter

Entering a term in the z3950 search box does not filter the results.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2692: remove escape="url" from opac-facets.inc
Galen Charlton [Wed, 22 Oct 2008 20:22:46 +0000 (15:22 -0500)]
bug 2692: remove escape="url" from opac-facets.inc

Based on Owen Leonard's patch, but redone to exclude
a dependency on an earlier unapplied patch.

For future enhancement, limit_cgi and the like should
probably not be constructed directly in C4::Search.
Instead, it should pass back a representation of the search
that the template can use to construct the appropriate URLs.
Done right, that would also make it easier to implement
things like search history.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoOPAC-side ISBN display fix (Bug 2592)
Owen Leonard [Wed, 15 Oct 2008 14:04:54 +0000 (09:04 -0500)]
OPAC-side ISBN display fix (Bug 2592)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoTwo template bug-fixes: removing debugging output from opac-detail.tmpl, and turning...
Owen Leonard [Tue, 14 Oct 2008 18:50:47 +0000 (13:50 -0500)]
Two template bug-fixes: removing debugging output from opac-detail.tmpl, and turning off html-escaping in addbooks.tmpl to prevent incorrect HTML output. Need to figure out how to allow HTML tags in titles /and/ do search term highlighting.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMarkup corrections, style fixes, and other minor bugs, including fix for Bug 2679...
Owen Leonard [Wed, 15 Oct 2008 15:18:14 +0000 (10:18 -0500)]
Markup corrections, style fixes, and other minor bugs, including fix for Bug 2679 ("Dates Changing on Funds When Editing")

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2660: Add command-line options to overdue notice script.
Ryan Higgins [Fri, 17 Oct 2008 03:25:27 +0000 (22:25 -0500)]
Bug 2660: Add command-line options to overdue notice script.

This commit adds two options to the overdue_notices.pl script.
The notices are now generated in one of two modes: default or triggered.
In default mode, every time the script runs, a notice is generated if an item
is overdue within a notice date range.  This mode is suitable for a weekly cron
(or manual run), but the notice triggers should be syncronized with the cron script such that
the script is run once per notice date range.  Otherwise, duplicate messages will
be generated ( or no notice generated if a notice date range passes without the script being run).
Triggered mode is suitable for a nightly cron job: a notice is generated only on those
days that an overdue item enters a notice date range.  This mode is susceptible to message
loss when the cron script fails to run, or when notice triggers are edited.

A second flag is added: --list-all, which causes items.content to list all currently overdue items.
Without this flag, only items that are overdue within the given notice's date range are listed on
that notice.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoReport to user the connections errors to z39.50 server, like timeout(10007), and...
Nahuel Angelinetti [Fri, 17 Oct 2008 07:38:13 +0000 (09:38 +0200)]
Report to user the connections errors to z39.50 server, like timeout(10007), and refused(10000).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup - use &amp; in place of &
Galen Charlton [Thu, 16 Oct 2008 20:45:41 +0000 (15:45 -0500)]
followup - use &amp; in place of &

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2627: Allow Unicode data in import_borrowers, expand feedback on errors.
Joe Atzberger [Fri, 19 Sep 2008 00:02:45 +0000 (19:02 -0500)]
Bug 2627: Allow Unicode data in import_borrowers, expand feedback on errors.

Date fields are now checked against syspref and iso regexps before attempting
to convert or insert them.  The problem characters were non-ASCII diacriticals.
Note: this may rely on improvements in the current 0.54 version of Text::CSV and
Text::CSV_XS, rather than the Koha minimum of 0.01 and 0.32, respectively.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix calls to get_template_and_user in label-item-search.pl
Michael Hafen [Thu, 16 Oct 2008 19:59:44 +0000 (13:59 -0600)]
fix calls to get_template_and_user in label-item-search.pl

remove extra flagsrequired line.
move call in first branch to the top.
  This will be important is IndepenantBranches code is later added to,
for example, C4::Items::get_itemnumbers_of()

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug in 'Add/Change link to item details...' I missed Previous checkouts area
Michael Hafen [Tue, 7 Oct 2008 17:30:27 +0000 (11:30 -0600)]
bug in 'Add/Change link to item details...' I missed Previous checkouts area

This turns the barcode into a link to moredetail.pl in the Previous
checkouts area of the circulation page, so it matches the Todays
checkouts area.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2622 & 2623 : tools permissions for edit notice triggers and picture upload overl...
Ryan Higgins [Thu, 9 Oct 2008 21:15:56 +0000 (16:15 -0500)]
Bug 2622 & 2623 : tools permissions for edit notice triggers and picture upload overly restrictive

removing requirements for parameters &  management respectively for these two tools.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding a few columns to members/readingrec.pl
Michael Hafen [Tue, 7 Oct 2008 21:58:07 +0000 (15:58 -0600)]
Adding a few columns to members/readingrec.pl

Add barcode and issues.renewals to members/readingrec.pl
Had to change the query in C4/Members, items.renewals was squashing
issues.renewals.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoIn members/readingrec.pl use itemcallnumber is classification isn't set
Michael Hafen [Tue, 7 Oct 2008 22:04:14 +0000 (16:04 -0600)]
In members/readingrec.pl use itemcallnumber is classification isn't set

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2659: fix crash in OAI-PMH interface
Galen Charlton [Mon, 6 Oct 2008 01:40:24 +0000 (20:40 -0500)]
bug 2659: fix crash in OAI-PMH interface

When retrieving a record via the OAI-PMH interface, if one of the fields used
to prepare the DC metadata is not defined in the MARC framework (e.g.,
biblioitems.publicationyear in the default MARC21 framework), an OAI GetRecord
can fail with the following error:

> Can't call method "as_string" on an undefined value at
> /usr/share/koha/opac/cgi-bin/opac/oai.pl line 59.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobugfix: Sort previous borrowers descending in Items.pm for moredetail.pl
Michael Hafen [Wed, 1 Oct 2008 20:14:56 +0000 (14:14 -0600)]
bugfix: Sort previous borrowers descending in Items.pm for moredetail.pl

The list of previous borrowers on moredetail.pl shows the three oldest
rather than the three most recent as I expected.  This changes the sql
to order descending so we get the three most recent.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobugfix: reenable listing suggestions by anyone
Galen Charlton [Thu, 16 Oct 2008 19:27:16 +0000 (14:27 -0500)]
bugfix: reenable listing suggestions by anyone

Change in parameter name in template not reflected
in script.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDisplaying branchnames rather than branchcodes
Henri-Damien LAURENT [Tue, 2 Sep 2008 22:03:15 +0000 (00:03 +0200)]
Displaying branchnames rather than branchcodes

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDon't pull all of biblioitems in GetItemsInfo
Michael Hafen [Tue, 9 Sep 2008 20:33:32 +0000 (14:33 -0600)]
Don't pull all of biblioitems in GetItemsInfo

Pulling marc and marcxml for some 1200 copies takes a lot of RAM.  Lets
not do that.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix the CSV export, provide it in UTF-8
Nahuel Angelinetti [Thu, 16 Oct 2008 12:48:14 +0000 (14:48 +0200)]
Fix the CSV export, provide it in UTF-8

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agodebugify a warn
Galen Charlton [Thu, 16 Oct 2008 15:44:56 +0000 (10:44 -0500)]
debugify a warn

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobugfix: fixed reference to sort2 column in query
Galen Charlton [Thu, 16 Oct 2008 15:24:32 +0000 (10:24 -0500)]
bugfix: fixed reference to sort2 column in query

Fixes following error when using the patron statistics report:

DBD::mysql::st execute failed: Unknown column 'sort' in 'where clause' at /home/gmc/koha/dev/reports/borrowers_stats.pl line 127

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSome changes to improve display on Internet Explorer.
Owen Leonard [Wed, 15 Oct 2008 14:05:11 +0000 (09:05 -0500)]
Some changes to improve display on Internet Explorer.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoChanges to prevent javascript errors in Internet Explorer
Owen Leonard [Wed, 15 Oct 2008 14:05:23 +0000 (09:05 -0500)]
Changes to prevent javascript errors in Internet Explorer

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup on Owen's patron attributes patch
Galen Charlton [Thu, 16 Oct 2008 15:10:09 +0000 (10:10 -0500)]
followup on Owen's patron attributes patch

Hide the display of the patron attributes only if
no types are defined; the patron attributes section
(and more importantly, the edit link), should still
be displayed if an attribute type is defined, even
if the patron has no attributes currently set.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd the feature to create reports with borrower's sex information(Men/Women) (bug...
Nahuel Angelinetti [Wed, 15 Oct 2008 07:38:47 +0000 (09:38 +0200)]
Add the feature to create reports with borrower's sex information(Men/Women) (bug #2671)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSpelling correction (catalogue -> catalog)
Owen Leonard [Wed, 15 Oct 2008 14:24:58 +0000 (09:24 -0500)]
Spelling correction (catalogue -> catalog)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoHiding patron attributes entry if not configured.
Owen Leonard [Wed, 15 Oct 2008 14:04:10 +0000 (09:04 -0500)]
Hiding patron attributes entry if not configured.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMore corrections to fix Bug 2649, "minPasswordLength Sys Pref does nothing." Previous...
Owen Leonard [Tue, 7 Oct 2008 14:21:01 +0000 (09:21 -0500)]
More corrections to fix Bug 2649, "minPasswordLength Sys Pref does nothing." Previous patch included typo copied from member-password.pl. Both are corrected now.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago2663 fix
Marc Chantreux [Wed, 8 Oct 2008 11:05:01 +0000 (13:05 +0200)]
2663 fix

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup - make barcode_to_borrowernumber() work as named
Galen Charlton [Tue, 14 Oct 2008 18:10:28 +0000 (13:10 -0500)]
followup - make barcode_to_borrowernumber() work as named

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSIP Holds processing on checkout
Henri-Damien LAURENT [Wed, 12 Nov 2008 13:47:05 +0000 (14:47 +0100)]
SIP Holds processing on checkout

Allow valid comparison of hold_queue to current user barcode and
permit checkout if the current user is at the front of the queue.
Effectively, this allows a user to checkout a book he has held.
Here are the example checkout (11) and checkout response (12)
statements in a SIP telnet session, showing failure (120) previously
and success (121) after patch application.
Before:
11YN20060329    203000                  AOCPL|AA1|AB502326000820|ACterm1
120NUN20081009    140222AOCPL|AA1|AB502326000820|AJKidnapped :|AH|AF2008-10-09 : Koha Admin (1)|BLY|
After:
11YN20060329    203000                  AOCPL|AA1|AB502326000820|ACterm1
121NNY20081009    150204AOCPL|AA1|AB502326000820|AJKidnapped :|AH2008-10-10|AFItem was reserved for you.|

This patch also resolves security/privacy issues related to the display
of "needsconfirmation" values that identify, for example, the user
currently issued an item, or with a hold on the item.  These messages
should not be passed to an end-user interface.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFully qualify function call.
Joe Atzberger (siptest [Thu, 9 Oct 2008 22:53:36 +0000 (17:53 -0500)]
Fully qualify function call.

This is a pre-requisite to continued SIP processing, dealing with some
arcana related to recursive dependencies and UNIVERSAL.  The reason this
is separate from other SIP patches is that it is expected patched in other
submissions already.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAnother correction to eliminate left column from print view.
Owen Leonard [Fri, 3 Oct 2008 16:16:10 +0000 (11:16 -0500)]
Another correction to eliminate left column from print view.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2555 : label batch_id not properly incremented after batch num 10.
Ryan Higgins [Sat, 27 Sep 2008 17:57:08 +0000 (12:57 -0500)]
Bug 2555 : label batch_id not properly incremented after batch num 10.

This is a stop-gap fix intended for 3.0 maintenance release.
3.2 should include a label_batches table which will allow named
batches to be associated with a template & layout, and fix the
column definition of batch_id here to be an auto_incr int.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMore Consistant terminoligy in stage-marc-import.tmpl
Michael Hafen [Wed, 1 Oct 2008 19:29:50 +0000 (13:29 -0600)]
More Consistant terminoligy in stage-marc-import.tmpl

Changes 'Notes about this file' to 'Comments about this file'.  It's
'Comments' in the manage-marc-import.tmpl file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoHiding minimum password hint if there is no minimum password length set.
Owen Leonard [Thu, 2 Oct 2008 16:24:04 +0000 (11:24 -0500)]
Hiding minimum password hint if there is no minimum password length set.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 2649, "minPasswordLength Sys Pref does nothing." Adds note specifying...
Owen Leonard [Wed, 1 Oct 2008 17:39:17 +0000 (12:39 -0500)]
Fix for Bug 2649, "minPasswordLength Sys Pref does nothing." Adds note specifying minimum password length to patron entry form, and generates warning if submitted password is not long enough.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug: query squashes issues.timestamp which circulation.pl needs to sort todaysissues
Michael Hafen [Wed, 10 Sep 2008 19:12:56 +0000 (13:12 -0600)]
bug: query squashes issues.timestamp which circulation.pl needs to sort todaysissues

Little change to the query so we get the right timestamp to sort on.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug: chargelostitem() didn't unset onloan on the item record.
Michael Hafen [Tue, 2 Sep 2008 19:57:09 +0000 (13:57 -0600)]
bug: chargelostitem() didn't unset onloan on the item record.

I don't think this is left set intentionally.

If an item is set lost and it's on loan it's marked returned, but it
wasn't set as not on loan.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug: sticky due date isn't stick if there is a question about an issue
Michael Hafen [Tue, 2 Sep 2008 22:13:16 +0000 (16:13 -0600)]
bug: sticky due date isn't stick if there is a question about an issue

the stickyduedate input isn't sent on from the question dialogs.  This
causes it to un-stick if there is a question.

Also removed month, day, and year as there seems to be no use for them.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobugfix: Add a message to circulation.pl if item is restricted
Michael Hafen [Wed, 1 Oct 2008 15:48:18 +0000 (09:48 -0600)]
bugfix: Add a message to circulation.pl if item is restricted

Don't know how this was missed.  If an item is restricted it isn't
allowed to be issued, but there is no message about why it can't be
issued, just the yellow box.

This adds a message saying "item is restricted".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMarkup and formatting improvements to Manage Staged Records interface.
Henri-Damien LAURENT [Wed, 12 Nov 2008 13:34:04 +0000 (14:34 +0100)]
Markup and formatting improvements to Manage Staged Records interface.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2587 followup, updated test.
Joe Atzberger [Tue, 23 Sep 2008 17:15:11 +0000 (12:15 -0500)]
Bug 2587 followup, updated test.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoConvert to C4::Debug, comment out unused Data::Dumper.
Joe Atzberger [Tue, 23 Sep 2008 17:01:48 +0000 (12:01 -0500)]
Convert to C4::Debug, comment out unused Data::Dumper.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2628: fixing test script to deal with DESTDIR in Makefile.PL
Andrew Moore [Fri, 19 Sep 2008 15:42:54 +0000 (10:42 -0500)]
bug 2628: fixing test script to deal with DESTDIR in Makefile.PL

Recently, there were changes to the Makefile.PL to make it install in a
DESTDIR that the OS (debian) may choose. This broke the test suite.
Since we're not installing the stuff in the t/ directory, we need to
ignore the DESTDIR specifiation before we write the test-config.txt.
So, this patch adds a call to the _strip_destdir function for all
directories written to the t/test-config.txt file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRevising the stub for ILS/Transaction/FeePayment.pm
Joe Atzberger [Fri, 19 Sep 2008 00:02:49 +0000 (19:02 -0500)]
Revising the stub for ILS/Transaction/FeePayment.pm

Obviously more implementation is needed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2625: finish fix by converting another array to hash
Galen Charlton [Fri, 19 Sep 2008 00:09:02 +0000 (19:09 -0500)]
bug 2625: finish fix by converting another array to hash

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2625
Clay Fouts [Thu, 18 Sep 2008 19:40:05 +0000 (14:40 -0500)]
bug 2625

Using the barcode as an index for assigning values to an array creates problems if
the numeric value of the barcode is sufficiently large to consume enough memory to
starve other processes. This patch changes return_failed from an indexed array into
an associative one, using the barcode as the key.

Signed-off-by: Ryan Higgins <rch@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAltering system log search form to conform with other similar forms; escaping output...
Henri-Damien LAURENT [Wed, 12 Nov 2008 11:08:41 +0000 (12:08 +0100)]
Altering system log search form to conform with other similar forms; escaping output of "info" variable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Conflicts:

koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tmpl

15 years agoDHTMLcalendar should not be imported.
Joe Atzberger [Fri, 12 Sep 2008 16:25:01 +0000 (11:25 -0500)]
DHTMLcalendar should not be imported.

Changing these scripts as precursor to removing it from C4::Dates @EXPORT_OK

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2600 : escaping information in returns.tmpl
Henri-Damien LAURENT [Wed, 12 Nov 2008 10:30:46 +0000 (11:30 +0100)]
Bug 2600 : escaping information in returns.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Conflicts:

koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tmpl

15 years agoA few more en-US spelling corrections; Markup corrections; Standardizing on "email...
Henri-Damien LAURENT [Tue, 4 Nov 2008 18:21:14 +0000 (19:21 +0100)]
A few more en-US spelling corrections; Markup corrections; Standardizing on "email" instead of "e-mail"; Copying isbn-formatting from opac-detail.pl to detail.pl;

and keep ability to hyperlink URL fields in MARC detail display

15 years agoBug Fixing : 2581 Problem With HomeBranchOrHoldingBranch (count items management)
Henri-Damien LAURENT [Thu, 4 Sep 2008 14:34:41 +0000 (16:34 +0200)]
Bug Fixing : 2581 Problem With HomeBranchOrHoldingBranch (count items management)

Using $item->{$hbranch} rather than $item->{homebranch}

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobugfix: need to return something if an itemtype doesn't have an image
Michael Hafen [Thu, 28 Aug 2008 20:58:21 +0000 (14:58 -0600)]
bugfix: need to return something if an itemtype doesn't have an image

I noticed that on the search pages if an itemtype doesn't have an image it's information doesn't make it out the the template.  I don't understand why, but this fixes it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2582 [1/2]: don't set issuedate during renewal
Galen Charlton [Thu, 4 Sep 2008 17:23:46 +0000 (12:23 -0500)]
bug 2582 [1/2]: don't set issuedate during renewal

Changed so that issues.issuedate is never modified
during a renewal, since that column records the original
date of the loan.  Changed the name and interpretation
of the $issuedate parameter of AddRenewal() to
$lastreneweddate, allowing (e.g.) offline circulation
to set the date of the renewal without changing the
issue date.

As a result of the original bug, issues.issuedate can be
set to NULL for loans that were renewed via the OPAC,
self checkout, or the staff interface when explicitly
renewing a loan.  Loans that were renewed by checking
the item out to the same patron will have the issue date
changed to the date of the last renewal.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofixing permission
Galen Charlton [Tue, 2 Sep 2008 21:34:41 +0000 (16:34 -0500)]
fixing permission

15 years agoAdd/Change link to item details (catalogue/moredetail.pl) for circulation and patron...
Henri-Damien LAURENT [Tue, 4 Nov 2008 18:11:38 +0000 (19:11 +0100)]
Add/Change link to item details (catalogue/moredetail.pl) for circulation and patron details

This adds the link to item details to circulation.pl
and changes the link on member details to include the itemnumber and #item... in the link.

Forgot the returns.pl.  Will do that in the next patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdded link to catalogue/moredetail.pl on the returns page for each returned item
Henri-Damien LAURENT [Tue, 4 Nov 2008 18:08:23 +0000 (19:08 +0100)]
Added link to catalogue/moredetail.pl on the returns page for each returned item

Had to add itemnumber to the hash of returned item information.

Links to moredetail.pl with itemnumber and #item in the url.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 2557, "Guarantor information - error messaee when clicking borrower#...
Owen Leonard [Tue, 26 Aug 2008 19:06:02 +0000 (14:06 -0500)]
Fix for Bug 2557, "Guarantor information - error messaee when clicking borrower# link." Also correcting a couple of minor markup errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSpelling corrections: organisation->organization, authorise->authorize, catalogue...
Henri-Damien LAURENT [Tue, 4 Nov 2008 18:04:07 +0000 (19:04 +0100)]
Spelling corrections: organisation->organization, authorise->authorize, catalogue->catalog

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoIf itemnumber is sent to catalogue/moredetail.pl use it
Henri-Damien LAURENT [Tue, 4 Nov 2008 18:01:52 +0000 (19:01 +0100)]
If itemnumber is sent to catalogue/moredetail.pl use it

If itemnumber is part of the url for catalogue/moredetail.pl
put it to use.
This happens in members/boraccount.pl if a fine is attached to a
barcode.

This patch makes moredetail.pl show only the item specified by
itemnumber.

Implements some changes to the patch suggested on
patches@koha.org
give visual cue on UI and a link out.
More friendly pruning of the other items.

Thanks to Galen Charlton and Joe Atzberger

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMinor SIP cleanup, conditionalize warnings.
Joe Atzberger [Wed, 27 Aug 2008 14:44:28 +0000 (09:44 -0500)]
Minor SIP cleanup, conditionalize warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 2424: Altering layout of advanced search screen to make it compatible...
Henri-Damien LAURENT [Tue, 4 Nov 2008 17:51:45 +0000 (18:51 +0100)]
Fix for Bug 2424: Altering layout of advanced search screen to make it compatible with Internet Explorer 6. Documentarians: this will require an updated screenshot.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix itemtype image problem in moremember.pl
Jesse Weaver [Fri, 22 Aug 2008 15:54:31 +0000 (10:54 -0500)]
Fix itemtype image problem in moremember.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoissues_stats returns empty results if row/column = items.ccode/datetime
Joe Atzberger [Wed, 20 Aug 2008 20:40:44 +0000 (15:40 -0500)]
issues_stats returns empty results if row/column = items.ccode/datetime

Also added ESCAPE="HTML" to column/row headers because users may define
collections that include ampersands, like:
    B&T Rental--Fiction
The Tidy error associated would be:
    line 574 column 29 - Error: general entity "T" not defined and no default entity

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for bug 1771: Template errors with remote itemtype image
Henri-Damien LAURENT [Tue, 4 Nov 2008 17:44:35 +0000 (18:44 +0100)]
fix for bug 1771: Template errors with remote itemtype image

This adds a new function, getitemtypeimagelocation, that returns the image
unmodified for absolute urls and returns the proper intranet or opac path
otherwise. It also updates all of the relevant files to use that function.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Conflicts:

C4/Koha.pm
catalogue/search.pl
opac/opac-search.pl

15 years agoRemoving strange dot file
Vincent Danjean [Fri, 15 Aug 2008 19:19:01 +0000 (21:19 +0200)]
Removing strange dot file

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2503: tests for C4::Circulation
Andrew Moore [Wed, 20 Aug 2008 16:21:48 +0000 (11:21 -0500)]
bug 2503: tests for C4::Circulation

I'm adding some tests for C4::Circulation methods that I'm altering
to allow the offline circulation tool to use C4::Circulation to upload
its data. These test a bit of the old functionality and try to show
that the new functionality does what I think it does.

C4::Circ::Addissue to tests issuedate
 these also test AddRenewal.
tests for C4::Circ::MarkIssueReturned

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2503: adding dates to some C4:Circulation methods to allow offline circulation...
Andrew Moore [Wed, 20 Aug 2008 16:21:46 +0000 (11:21 -0500)]
bug 2503: adding dates to some C4:Circulation methods to allow offline circulation tool to specify dates other than today

When uploading an offline circulation file, some actions may need to take place
in the past. This patch adds date parameters to some C4::Circulation methods
to allow us to set dates on them

added issuedate to C4::Circulation::AddIssue
adding issuedate to C4::Circulation::AddRenewal
adding returdate to C4::Circulation::MarkIssueReturned

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2530 : create new date object in javascript function instead of modifying passed...
Ryan Higgins [Tue, 19 Aug 2008 18:51:09 +0000 (13:51 -0500)]
bug 2530 : create new date object in javascript function instead of modifying passed-in reference.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2526: removing DEBUG flag from C4::Search
Andrew Moore [Fri, 15 Aug 2008 16:19:06 +0000 (11:19 -0500)]
bug 2526: removing DEBUG flag from C4::Search

The DEBUG flag was left turned on.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for bug 2155: duplicate checkin box on returns screen
Henri-Damien LAURENT [Tue, 4 Nov 2008 16:38:16 +0000 (17:38 +0100)]
Fix for bug 2155: duplicate checkin box on returns screen

This changes some css and markup to make the return box at the top not show when one is on the checkin screen. It also moves the markup for the autocompleting search box to its own file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2523: add columns to holds queue report
Galen Charlton [Fri, 15 Aug 2008 01:59:52 +0000 (20:59 -0500)]
bug 2523: add columns to holds queue report

* added author, ccode, location, and item enumchron
* sorted by collection, locatoin, call number, author, title

As part of this patch, commented out the JavaScript tablesorter,
which could cause the browerer to lock up if the picklist
contains more than a couple hundred items to pull.
Some sort of pagination is clearly required, but since
it is necessary for customers to be able to print out
the picklist, there still needs to be an option to
see the complete list for a branch.

This patch includes the final component of the fix
for bug 2331.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoCorrections to manage marc import interface, including fix for inaccurate progress...
Henri-Damien LAURENT [Tue, 28 Oct 2008 22:29:37 +0000 (23:29 +0100)]
Corrections to manage marc import interface, including fix for inaccurate progress bar.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2341: OPAC title-level holds permitted when items are on-order
Galen Charlton [Thu, 14 Aug 2008 16:48:41 +0000 (11:48 -0500)]
bug 2341: OPAC title-level holds permitted when items are on-order

Changed so that the presence of an on-order item (items.notforloan =- -1)
permits a title-level hold request to be made.  Prior to this patch,
if all of the items linked to the bib were on-order, no title-level
request was permitted.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2520: don't change item-level requests to bib-level
Galen Charlton [Thu, 14 Aug 2008 15:43:08 +0000 (10:43 -0500)]
bug 2520: don't change item-level requests to bib-level

Prior to this fix, changing the priority of any hold requests
in the queue of requests for a bib would convert
all item-level requests to title-level requests.

As part of this fix, improved display of the holds queue
so that item-level and bib-level requests can be more
clearly distinguished.

Documentation note: new screenshot of list of requests for
a bib in the staff interface.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2521: distinguish types of hold requests
Galen Charlton [Thu, 14 Aug 2008 15:43:09 +0000 (10:43 -0500)]
bug 2521: distinguish types of hold requests

Title-level and item-level requests are now more
clearly distinguished in the patron details page
and the patron checkout page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2518: remove useless patron and branch lookups
Galen Charlton [Thu, 14 Aug 2008 15:43:06 +0000 (10:43 -0500)]
bug 2518: remove useless patron and branch lookups

AddIssue does not use the results of the lookup
of the patron whose hold request was preempted
by the issue.  This patch now leaves a no-op in
the '$restype eq "Waiting"' test, but I'm not going to
refactor the hold cancellation logic now.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agobug 2519: clear waitingdate if request is moved off waiting status
Galen Charlton [Thu, 14 Aug 2008 15:43:07 +0000 (10:43 -0500)]
bug 2519: clear waitingdate if request is moved off waiting status

* Changed C4::Reserves::ModReserve so that if using it to take an
  item off the hold shelf, reserves.waitingdate is cleared.
* Improved POD.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoAdding javascript to prevent premature submission of forms when using a barcode scann...
Owen Leonard [Mon, 15 Sep 2008 16:33:32 +0000 (11:33 -0500)]
Adding javascript to prevent premature submission of forms when using a barcode scanner (or by hitting the enter key). Addresses Bug 2591

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoReduce logging from rebuild_zebra.pl with a command line option
Michael Hafen [Wed, 1 Oct 2008 18:04:16 +0000 (12:04 -0600)]
Reduce logging from rebuild_zebra.pl with a command line option

This reduces the output of the script and zebraidx, and creates a -v
command line switch which will increase the logging to their former
states.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoEliminate left-column margin on print view
Owen Leonard [Wed, 24 Sep 2008 16:26:33 +0000 (11:26 -0500)]
Eliminate left-column margin on print view

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoBUGFIX missing div
paul [Mon, 22 Sep 2008 16:31:54 +0000 (18:31 +0200)]
BUGFIX missing div

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agofix date formatting in overdue_notices.pl
Pianohacker [Fri, 26 Sep 2008 19:57:25 +0000 (14:57 -0500)]
fix date formatting in overdue_notices.pl

This makes overdue_notices.pl format dates in fields that both start and end with 'date'.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
16 years agoBugfix #2630 2nd attempt
Frederic Demians [Fri, 26 Sep 2008 17:25:58 +0000 (19:25 +0200)]
Bugfix #2630 2nd attempt

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>