Bug Fix : 1898 Replaces the previous commit : More fixes.

A) Fixing queries which were mysql old style
B) Fixing output.

+ Fixing queries the same way for bor_issues_top catalogue_out and issues_avg_stats

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing item-level_itype =ON imageurl in opac-detail.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

refactor C4::Log::logaction

This fix should resolve in whole or in part several bugs
characterized by the error message 'Can't use string ("0")
as a HASH ref while "strict refs" in use', including
bugs 1101, 1899, and 1910.

There are some possibilities for future work:

[1] Dealing with an operator override, e.g., where
    a circ operator needs to get a supervisor
    to enter a login and password and escalate
    the original operator's privileges for a
    transaction, e.g., to forgive a fine.  This
    is an enhancement, of course.
[2] Creating a dummy operator to represent
    batch job runs; or alternatively, give
    each batch job an option to log its work
    under a specified user ID.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Cleanup of z39.50 search form, addition of checkall js. Addition of tablesorter js to z39.50 results.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed create table statement for patroncards

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding tablesorter

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bugfix for table sorting

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding tablesorter

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Partial fix for Bug 1949, Bibliographic Address isn't properly displayed on OPAC result page. Changes will have to be made to script to prevent display of pipes between subfield repeitions.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for Bug 1951, OPACURLOpenInNewWindow doesn't do anything.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Formatting and adding additional info to display of editions in the OPAC and the staff client.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Tweak to table-sorter css.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bugfix to correct date format in query used in GetLogs()

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Correcting Logging on ModMember function so that the query is logged in the 'info' field.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changing default value for yuipath to local rather than http

Setting this as a Choice parameter.
This may raise not a performance issue.
Since we were told that loading it local could be longer than getting it from yahoo.
But for poor internet connectivity, it would be a better.
For mobile computer, it is a better choice.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

don't include the item itself as an edition

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding a <meta> field to make Koha's OPAC discoverable

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing where the 505 subfields are indexed (before the field) in record.abs

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing bug 1801

adding some parameters to the call to opac-auth.tmpl in C4::Auth::checkauth
This displays the additional navigational links in the masthead on the login page to unauthenticated users.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixes bug 1924: Language selection lists English only and that several times.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

partial fix for bug 1873: virtualshelfcontents dateadded column empty

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

partial fix for bug 1891

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for bug 1625: Pass title, subtitle, and author variables to MARC views

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for bug 1781 for NOZebra=OFF

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

only show item-leve_itypes if syspref is set

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing itemtype image where item-level_itypes is OFF

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

remove warnings from Languages.pm

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Mod C4::Labels::add_batch to accept an array of items.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Partial commit to add Create-Label-Batch-from-Import-Batch

Import batch portion herein. Still need to touch Labels.pm .

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing bug 1754: Hide language chooser if only one translation is available

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

repairing faulty updatedatabase syntax

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bumping DB ver to 065

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Eighth installment Patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Seventh installment Patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Sixth installment Patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fifth installment Patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fourth installment Patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Third installment Patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Second Installment: Patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

First installment: Patron card generation feature

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for 1610: Redirect to result when opac search returns only one item

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing nomenclature of vshelves

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing display of itemtypes and itemtype icons in virtual shelves

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for bug 1855: Language in News

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for bug 1925: 505 Field Indexing

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Add MARC preview to Z39.50 search.

Also, add title string to MARC editor.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Remove Z3950 mandatory fields from MARC editor.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Add z39.50 search form distinct from MARC editor

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

wrapping dates in amazon ratings with format_date()

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1593: Fix item type image handling in OPAC

Also cleans up dates in a couple places

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More tweaks to shelf browse and similar items.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Working on styling browse features, similar items.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for Bug 1939, OpacMainUserBlock not displaying with news.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Link correction in similar items block.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

More js-based table sorting

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Refining table sort

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Testing jquery table sorting plugin

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Displaying borrowernumber under 'Library Use' heading with label 'Patron ID.' Partial fix for Bug 1944, Borrownumber needs to display for librarians.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing second instance of deleteditems.copynumber

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for Bug 1927

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing itemtype icon display for item-level_itype = OFF

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for syntax error with experimental shelf browser

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding experimental OPACShelfBrowser feature -- to try, create a new syspref called OPACShelfBrowser, and set it to 1

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

IMPORTANT: Upgrading to Amazon.com Associates Web Service 4.0

As announced this past February, Amazon.com will no longer be
accepting web services requests to Amazon E-Commerce Service
(Amazon ECS) version 3.0 beginning on March 31, 2008.

This patch upgrades to Amazon.com's Associates Web Service 4.0
for the following components:

1. Amazon.com Locale support for: Canada, Germany, France, Japan,
   UK, and US (see the new syspref called AmazonLocale)
2. Jacket Covers
3. Editorial Reviews
4. Customer Reviews
5. Amazon.com Similar Items

The following changes MUST be made to continue using Amazon.com
content:

1. Delete the system preference: AmazonDevKey (AmazonDevKeys used
   with AmazonECS 3.0 are no longer valid)
2. Add the system preferences: AmazonLocale, AWSAccessKeyID
   NOTE: steps 1, 2 are done by the web installer
3. Verify your AWSAccessKeyID:
   You may already have an Access Key ID. You can access your Access
   Key ID by going to http://aws.amazon.com, pointing to Your Web
   Services Account, then clicking View Access Key Identifiers.
   Depending on when you signed up for ECS 3.0, you may need to
   re-register for an AWS account, which includes an Access Key ID.
4. Enter your AWSAccessKeyID in the Koha syspref called
AWSAccessKeyID

For complete details on the changes in Amazon.com Associates Web
Service 4.0, and the migration process, please see: http://tinyurl.com/ysorqy

Other changes with this patch:
 * added $tabsysprefs{PatronsPerPage}="Patrons";
 * Moved OPAC Features to OPAC in sysprefs
 * removed experimental OPACXISBNAmazonSimilarItems and XISBNAmazonSimilarItems features

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

IMPORTANT: Upgrading to Amazon.com Associates Web Service 4.0

As announced this past February, Amazon.com will no longer be
accepting web services requests to Amazon E-Commerce Service
(Amazon ECS) version 3.0 beginning on March 31, 2008.

This patch upgrades to Amazon.com's Associates Web Service 4.0
for the following components:

1. Amazon.com Locale support for: Canada, Germany, France, Japan,
   UK, and US (see the new syspref called AmazonLocale)
2. Jacket Covers
3. Editorial Reviews
4. Customer Reviews
5. Amazon.com Similar Items

The following changes MUST be made to continue using Amazon.com
content:

1. Delete the system preference: AmazonDevKey (AmazonDevKeys used
   with AmazonECS 3.0 are no longer valid)
2. Add the system preferences: AmazonLocale, AWSAccessKeyID
   NOTE: steps 1, 2 are done by the web installer
3. Verify your AWSAccessKeyID:
   You may already have an Access Key ID. You can access your Access
   Key ID by going to http://aws.amazon.com, pointing to Your Web
   Services Account, then clicking View Access Key Identifiers.
   Depending on when you signed up for ECS 3.0, you may need to
   re-register for an AWS account, which includes an Access Key ID.
4. Enter your AWSAccessKeyID in the Koha syspref called
AWSAccessKeyID

For complete details on the changes in Amazon.com Associates Web
Service 4.0, and the migration process, please see: http://tinyurl.com/ysorqy

Other changes with this patch:
 * added $tabsysprefs{PatronsPerPage}="Patrons";
 * Moved OPAC Features to OPAC in sysprefs
 * removed experimental OPACXISBNAmazonSimilarItems and XISBNAmazonSimilarItems features

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

s/Catalogue/Search/

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Search.pm - minor cleanup

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

opac-results.tmpl - Show publication year in results list, failing over to copyright date (MARC21).

The better fix for this would be for C4::Search to return the date in the same field
regardless of framework or other configurations, but this is good for now.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

C4::Search - vastly reduced calls to preference and repeatedly stepping through the same hashrefs to build keys

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

C4::Debug - should resolve conflict w/ CGI upload. Debug no longer uses CGI.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding acqui-home to breadcrumbs. Hopefully that satisfies Bug 1894

(Easy back link needed on suggestion accept/reject page to Acqui).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changes to cart: Replacing javascript alerts with same kind of popup as when you hover over the cart button.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Trying to fancy up the process of adding items to cart. Unfinished.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Tweaking cart and lists buttons for non-javascript users

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Increasing the size of opac and library notes fields in member entry, fixing Bug 1932, Need to enlarge the notes field display in the patron record in staff client

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding "Search for this title in..." links to opac detail, with links to WorldCat and Google Scholar.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for Bug 1930 ("Most Circulated Items" report template is broken) as well as other markup corrections.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Cleaning up label item search and results, fixing Bug 1929 (Navigation issue with label-item-search.tmpl)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixes to enable display and selection of individual items rather than bibs.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing bug that causes Volume information not to be displayed.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

typo fix: "recieve" => "receive"

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix errors with using today's date and format_date

This patch should reduce the occurrence of the following
message in the error log:

Illegal Date '2008-3-14' does not match 'iso' format: yyyy-mm-dd

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix initiation of transfer on return of non-issued item

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

another patch to display correct item type

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

waiting holds report: respect item-level_itypes setting

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1742: don't include items on loan in pending holds report

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix crash when recording payment for lost item

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix crash when writing off fine that is not associated with an item

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

after processing payment, redirect to patron account list

* redirecting to the account page shows operator that
  payment was recorded
* avoids a jarring transition

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed another non-initialized variable in TMPL_IF EXPR

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix crash when levying a rental charge

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more item-level_itypes fixes

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

check on max renewals now respects item-level item types

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

better way of fixing "renew all"

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed 'renew all' button on patron details page

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed invalid TMPL_IF EXPR

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed extra TMPL_ELSE

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed warns

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed use of TMPL_IF EXPR in circulation.tmpl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

added font to sample label templates

Signed-off-by: Joshua Ferraro <jmf@liblime.com>