]> git.koha-community.org Git - koha.git/log
koha.git
9 years agoBug 14325: Test calls C4::Context::set_userenv
Mark Tompsett [Wed, 3 Jun 2015 19:25:47 +0000 (15:25 -0400)]
Bug 14325: Test calls C4::Context::set_userenv

This is a case of works by accident. This patch corrects the
set_userenv call.

TEST PLAN
---------
1) prove t/db_dependent/Borrower_Discharge.t
   -- works
2) git grep :set_userenv
   -- only this one file.
3) Confirm the the C4/Context.pm has a set_userenv
   which shifts the first parameter, as intended for
   a -> call and not a :: call.
4) apply patch
5) prove t/db_dependent/Borrower_Discharge.t
   -- still works
6) git grep :set_userenv
   -- nothing now.
7) run koha qa test tools

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 8f12796633e71b9c1e8442cdeba2f7333e71ca52)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoUpdating version to 3.20.00.001
Chris Cormack [Thu, 4 Jun 2015 01:58:17 +0000 (13:58 +1200)]
Updating version to 3.20.00.001

9 years agoBug 14285: Bengali locale needs to be re-defined
Bernardo Gonzalez Kriegel [Thu, 28 May 2015 15:18:38 +0000 (12:18 -0300)]
Bug 14285: Bengali locale needs to be re-defined

This patch renames translation files for Bengali
language, from ben-* to bn-IN-*.
Also adds India as region

To test:
1) Apply the patch
2) Run updatedatabase
3) Install Bengali language
cd misc/translator
perl translate install bn-IN
enable

Check correct description

4) Create and install a fake Bengali variant
cd misc/translator
perl translate create bn-XX
perl translate install bn-XX
enable both variants

Check correct rendering of region

Results comply with expected test plan outcome. Signed off for bn-IN
Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit e365e6e53592a4639f18173def7e74e0ad24419c)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 14291: Fix OpacExportOptions text
Nicole C. Engard [Thu, 28 May 2015 16:39:29 +0000 (11:39 -0500)]
Bug 14291: Fix OpacExportOptions text

This patch removes the instruction to separate values by | in the
OpacExportOptions preference.

To test:

Go to system preferences
Find OpacExportOptions
Confirm text is right

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Test output compliant with expected test plan outcome.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Changed "List" to "Select" and removed a space before the : at the end.
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 959e6b7ae433d891a31c20b86690ab68446bf508)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 14047: Order z39.50 biblioservers in cataloguing
Zeno Tajoli [Wed, 22 Apr 2015 15:03:38 +0000 (17:03 +0200)]
Bug 14047: Order z39.50 biblioservers in cataloguing

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Bug 14047: Sort z39.50 servers in Acquisition

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Bug 14047: [QA Follow-up] Move result_class back into attributes

No need to put this into a separate call.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Note that we strictly speaking do not need the hashref inflator here,
because TT understands hash.column as well as object.property.

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit c7a67ea4f33402a1f3165864952d6a692f898953)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 11929: patron modification error shows borrowernumber
Marc Véron [Sun, 26 Apr 2015 19:36:25 +0000 (21:36 +0200)]
Bug 11929: patron modification error shows borrowernumber

If an error occurs in patron batch modification, a message similar to the following is displayed:
Can not update patron with borrowernumber 7055

It would be useful to have the cardnumber as well.

This patch adds the card number to the lists of errors.

It is not easy to trigger an error (see comments).
For testing, I tweaked the sub ModMember in C4/Members.pm to always return false.

TEST PLAN
---------
1) Log in as a superlibrarian and create a test user
2) Change the cardnumber to a number differing from the
   borrower number.
3) Home -> Tools -> Batch patron modification
4) Type in the cardnumber of that test user
5) Check the Library checkbox.
6) Click Save
   -- nice error, but it is borrower number instead of
      the card number which was entered.
7) Apply the patch
8) Repeat steps 3-6
   -- nice error, but it is now more informative.
9) run koha qa test tools.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 3b3f82de377c87f9108bf07dd0d293182e5b9bdc)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 14279: Remove CGI::scrolling_list from issues_avg_stats.pl
Bernardo Gonzalez Kriegel [Tue, 26 May 2015 17:45:22 +0000 (14:45 -0300)]
Bug 14279: Remove CGI::scrolling_list from issues_avg_stats.pl

This patch removes scrolling_lists from this file

To test
1) Go to Reports > Average loan time
2) Check dropdowns Patron category, Item type, Sort1/2 and Into application
will be changed
3) Apply the patch
4) Reload and check for regression

Followed test plan. Works as expected.
Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 154eb5f6f55c60632811bcae240cc8254fab7efb)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 14265 - Use $.trim instead of trim() in admin/categorie.tt
David Cook [Mon, 25 May 2015 04:01:09 +0000 (14:01 +1000)]
Bug 14265 - Use $.trim instead of trim() in admin/categorie.tt

This patch replaces trim() with $.trim() in admin/categorie.tt, as
$.trim() is more cross-platform (ie it is supported in "< IE9").

_TEST PLAN_

Before applying patch:

0) Use IE 8 or use Document Mode 8 in a newer IE using F12 Developer Tools
1) Go to Administration > Patron categories
2) Click "Edit" next to a category
3) Click "Save" at the bottom
4) Note the form doesn't submit (you can also notice the error in the
console log)

Apply the patch:

5) Hold down shift + refresh the page
6) Click "Save" at the bottom"
7) Note that the form does submit and there are no errors reported

Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
No regression found using iceweasel.
I did not know the staff interface was IE compatible.
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 06ef68046e52a56f690e656f30592ff46b21a383)

9 years agoBug 14266: Trim the email address in the pl script
Jonathan Druart [Tue, 26 May 2015 11:05:51 +0000 (13:05 +0200)]
Bug 14266: Trim the email address in the pl script

The original concern of bug 14266 was to provide a compatibility for
<IE9.
But actually we don't need to trim the email address template side.
It will even better to trim it in the perl script, so that the email
will be trimed even if JS is disabled.

Test plan:
1/ Share a list and does not provide any email address
2/ Submit
=> The form is not submited, no alert/message is displayed (same as
before this patch).
3/ Share a list and provide an email address with spaces before and
after
4/ Submit
=> You should receive the email

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Test output compliant with expected test plan outcome.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit c7a8e4dd25768870de74a5a96c63a92ff1c7fcc8)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 14266: Replace trim() with $.trim() in opac-shareshelf.tt
David Cook [Mon, 25 May 2015 04:07:27 +0000 (14:07 +1000)]
Bug 14266: Replace trim() with $.trim() in opac-shareshelf.tt

This patch replaces trim() with $.trim() which is supported
in versions of IE older than IE9.

Revised test plan
=================

Before applying patch:

0) Use IE 8 or Document Mode 8 in a newer IE using F12 Developer Tools
1) Set OpacAllowSharingPrivateLists to "Allow" in Global System Preferences
2) Create a private list in the OPAC
3) Add a record to the private list
4) Click "Share" or "Share list" on one of the list screens
5) Type in an email address and click "Send"
6) Note the error in the console log
7) The page should submit

Apply the patch:

7) Hold shift + refresh the browser to update any Javascript cache
8) Try to "Share" the list again
9) Note that the form submit after clicking "Send" and
that there are no errors in the console log

http://bugs.koha-community.org/show_bug.cgi?id=14266

Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
Remarks: Works as per revised test plan
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit e1ac8b431002ad15ba8bc19a61f2daf0424552e2)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 12066: New renew page in staff client doesn't record branch in statistics
Kyle M Hall [Wed, 20 May 2015 15:31:18 +0000 (11:31 -0400)]
Bug 12066: New renew page in staff client doesn't record branch in statistics

Test Plan:
1) Apply this patch
2) Renew an item via circ/renew.pl
3) Note the branch code of your logged in library is set as the
   branch in the generated statistic line

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested pre and post patch, now branch is saved
No errors

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit d78f832cb026ace04ff3e6d2c3765b39656e0e11)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 13946: Change order status 'Pending' to 'Ordered'
Katrin Fischer [Mon, 25 May 2015 09:22:07 +0000 (11:22 +0200)]
Bug 13946: Change order status 'Pending' to 'Ordered'

The order status after closing the basket is 'ordered' in the
database, but displays as 'pending' in the staff interface.

As we use 'pending' when you have to review a suggestion, this
clashes in translations and the meaning is different. The patch
renames 'pending' for the order status to 'Ordered' to be more
clear.

To test:
- Verfiy 'Ordered' shows in the pull down on the acq advanced
  search and search still works correctly
- Verify the results table also display 'Ordered' as the status

Signed-off-by: Cédric Vita <cedric.vita@dracenie.com>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 480ac8667971a638b4b27d0dc8e5bb29f9f2a372)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 14275: Remove CGI::scrolling_list from guided_reports.pl
Bernardo Gonzalez Kriegel [Tue, 26 May 2015 14:00:02 +0000 (11:00 -0300)]
Bug 14275: Remove CGI::scrolling_list from guided_reports.pl

Remove an instance of CGI::scrolling_list from this file

To test:
1) Go to Reports, Guided report wizard, New SQL report

2) Create a report with some auth value list, e.g.

SELECT surname,firstname FROM borrowers WHERE branchcode=<<Enter patrons library|branches>>

Save

3) Clic on 'Run this report", look at the dropdown, that will be changed

4) Apply the patch

5) Reload, check dropdown and any regression

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 764b425c1ce0573f9b02bfa3b9b2425137630f0c)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 14112: Silence warnings in t/Charset.t
Mark Tompsett [Fri, 22 May 2015 13:02:23 +0000 (09:02 -0400)]
Bug 14112: Silence warnings in t/Charset.t

After Jonathan said this was the wrong way to correct the issue,
www.utf8-chartable.de made it clear to me that the \c3\a9 were
missing x's.

TEST PLAN
---------
1) prove t/Charset.t
   -- noise
2) apply patch
3) prove t/Charset.t
   -- no noise
4) koha qa test tools

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 4d4582566ee7d2014f30f15db4889d4cad956316)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 12176: Fix for missing field_value in select
Marcel de Rooy [Sat, 23 May 2015 12:01:57 +0000 (14:01 +0200)]
Bug 12176: Fix for missing field_value in select

As Jonathan Druart discovered, we were still missing an important attribute
in the selects. Var mv.name was not filled, so the name was empty with nice
side-effects :)
While fixing this, it was also possible to delete some unused vars that Bernardo
already mentioned before: $attributes and $attributes_no_value.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
For me the simptom was different, when saving an edited item
fields were mangled beyond repear :(
No alert for empty mandatory fields.

But this last patch fix the problem.
Tested add/edit items
Cleaner pl file :)
No errors

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit e021b512e34d0521803fa5f32dd67f1532ddb73d)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 12176: [QA Follow-up] Capitalization typo after eleventh hour
Marcel de Rooy [Wed, 20 May 2015 14:42:34 +0000 (16:42 +0200)]
Bug 12176: [QA Follow-up] Capitalization typo after eleventh hour

While cleaning up, still found this super tiny string typo :)
Yes, Tag Editor should now be Tag editor.

Test plan :)
Git grep on Tag editor and Tag Editor

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 351b2f753f7b30665dc22be595af4a00589424e7)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 12176: [QA Follow-up] Small additem adjustments
Marcel de Rooy [Wed, 20 May 2015 12:56:48 +0000 (14:56 +0200)]
Bug 12176: [QA Follow-up] Small additem adjustments

Adjusting a few small things and making qa tools happy:

[1] Remove .hidden after [% avalue %] in additem.tt. (Typo)
[2] A closer look revealed that mv.avalue is useless too. An input element
    does not contain any content. Putting it after the hidden element
    in a non-visible context has no meaning.
[3] Change handling of select attributes readonly and disabled.
[4] Remove unused variable $attributes_no_value_textarea
[5] Removed a comment with TODO referring to this report.
[6] Moving a duplicated TT variable (mv.javascript) outside IF statement.
[7] And finally could not resist this one: Moving strings Tag editor and
    No popup from script to template.  Plugins++
    NOTE: Most item plugins redirect click to focus. In that case there is
    no popup, but unfortunately the text Tag editor comes up.
    When you remove or rename function Click, No popup comes up. So it works.

Sorry that this small list kept growing :)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 50d2b712883808a36b1d03ac770aed470c8d19d1)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 12176: Remove HTML from additem.pl
Bernardo Gonzalez Kriegel [Tue, 19 May 2015 16:06:34 +0000 (13:06 -0300)]
Bug 12176: Remove HTML from additem.pl

This patch removes HTML code from additem.pl.

To test:
1. Check no regressions on Add/Edit/Save items
2. Update translation files for a language,
   check new strings "Tag editor" & "No popup" on staff PO file
3. Check it passes xt/tt_valid.t

Patch partially rebased, part rewritten.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 47d2de9c024bfb93d56184f298f334b20685cd86)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
9 years agoBug 14025: Fix 865u-links in the OPAC for NORMARC
Magnus Enger [Wed, 29 Apr 2015 19:28:50 +0000 (21:28 +0200)]
Bug 14025: Fix 865u-links in the OPAC for NORMARC

The display of links found in 856$u for NORMARC has not been keeping up with
the one for MARC21, and several sysprefs have not been implemented. This
patch tries to fix that.

Affected sysprefs:
- OPACURLOpenInNewWindow
- URLLinkText
- OPACDisplay856uAsImage
- OPACTrackClicks

To test:
- Make sure you have a record with a URL in 856$u and marcflavor = NORMARC.
  (It does not have to be a full NORMARC setup or a NORMARC record, just make
  sure you are viewing the record through the NORMARC XSLT files.)
- View the record both in a result list and in detail view
- Check that the 4 involved sysprefs affect the display in the expected ways

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested on NORMARC setup and XSLTs
Works as described, each syspref works
No koha-qa errors

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Since it only affects NORMAC, I trust in Magnus :)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 9b1241ecfca68c104d9adbb5d05a7547b5761e17)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 14203: Message for non-existent lang removal
Indranil Das Gupta [Thu, 14 May 2015 19:42:11 +0000 (01:12 +0530)]
Bug 14203: Message for non-existent lang removal

A trivial string patch to update the error message displayed to
user if koha-translate is used to attempt removal of a language
that is not installed.

Test plan
=========

1/ attempt to remove a non-existent language by
   <installdir>/debian/scripts/koha-translate --remove <langcode>
2/ it should show "Error: the selected language is not already
   installed."
3/ apply patch
4/ repeat step 1; it should show "Error: the selected language is
   not installed."

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit d7dc11e61fea5dcc3f0087e46b6eee8d74c21c63)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 14184: Undefined $term causes noisy warns in C4/CourseReserves.pm
Aleisha [Tue, 12 May 2015 02:08:17 +0000 (02:08 +0000)]
Bug 14184: Undefined $term causes noisy warns in C4/CourseReserves.pm

This patch sets $term to be an empty string.

Test plan
=========

1/ enable 'UseCourseReserves' syspref in Circulation preferences
2/ in a terminal, run a `tail -f ` on your instance's opac-error.log
3/ go to the opac, click on 'Course reserve' tab to go to
   opac-course-reserves.pl
4/ notice the warning - "opac-course-reserves.pl: Use of uninitialized
   value $term" appear in the `tail`ed opac-error.log
5/ apply the patch
6/ reload the page (opac-course-reserves.pl)
7/ page works but the warning in step #4 is no longer logged
8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error

Remarks: Testing result match expected test plan output. The QA tests
         pass with "OK" for the commit.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 4f994e8baf3ffd209f6a0a85993039f753ec6e32)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl
Aleisha [Tue, 12 May 2015 03:01:35 +0000 (03:01 +0000)]
Bug 14185: Undefined $limit causes warn in opac/opac-readingrecord.pl

This patch sets $limit to be an empty string.

Test plan
=========

1/ login into the opac using your user account credentials
2/ in a terminal, run a `tail -f ` on your instance's opac-error.log
3/ go back to the opac, click on 'your reading history' tab to go to
   opac-readingrecord.pl
4/ notice the warning - "opac-readingrecord.pl: Use of uninitialized
   value $limit" appear in the `tail`ed opac-error.log
5/ apply the patch
6/ reload the page (opac-readingrecord.pl)
7/ page works but the warning in step #4 is no longer logged
8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error

Remarks: Testing result match expected test plan output. The QA tests
         pass with "OK" for the commit.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit fd14184873e707236150e368f39b19a6992760b8)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 14186 [QA Followup]: Undefined $reservedfor causes warn in opac-reserve.pl
Indranil Das Gupta [Thu, 14 May 2015 01:53:16 +0000 (07:23 +0530)]
Bug 14186 [QA Followup]: Undefined $reservedfor causes warn in opac-reserve.pl

This is a followup for Bug 14186 that removes the extraneous tab
char on line 470, so that the patch can clear QA tools.

This patch sets $reservedfor to an empty string.

Test plan
=========

1/ in a terminal, run `tail -f ` on your instance's opac-error.log
2/ go to the opac and search from an item that exists on the Koha
   instance.
3/ Select the title (if more than one title is returned) and click on
   'Place hold' link to go to opac-reserve.pl
4/ notice the warning - "opac-reserve.pl: Use of uninitialized value
   $reservedfor" appear in the `tail`ed opac-error.log
5/ apply the patch
6/ reload the page (opac-reserve.pl)
7/ page works but the warning in step #4 is no longer thrown up
8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error

Remarks: Testing result match expected test plan output. The QA tests
         pass with "OK" for the commit.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 642e6012cd125cbc3aeaca83e1fd2430ce43fdb0)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 14186: Undefined $reservedfor causes warn in opac-reserve.pl
Aleisha [Tue, 12 May 2015 03:30:46 +0000 (03:30 +0000)]
Bug 14186: Undefined $reservedfor causes warn in opac-reserve.pl

This patch sets $reservedfor to an empty string.

Test plan
=========

1/ in a terminal, run `tail -f ` on your instance's opac-error.log
2/ go to the opac and search from an item that exists on the Koha
   instance.
3/ Select the title (if more than one title is returned) and click on
   'Place hold' link to go to opac-reserve.pl
4/ notice the warning - "opac-reserve.pl: Use of uninitialized value
   $reservedfor" appear in the `tail`ed opac-error.log
5/ apply the patch
6/ reload the page (opac-reserve.pl)
7/ page works but the warning in step #4 is no longer thrown up
8/ run qa test (i.e. koha-qa.pl -c 1 -v 2), there should be no error

Remarks: The QA test failed - "forbidden pattern: tab char (line 470)".

         Marking this as 'FAILED QA'

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit 8fdd352bc9bb4d0dd84ca0df33b51558ee765ea1)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoBug 14130: Update columns.def
Katrin Fischer [Mon, 4 May 2015 20:08:04 +0000 (22:08 +0200)]
Bug 14130: Update columns.def

- Updates columns.def with new columns in items
- Adds some descriptions
- Corrects some existing column descrpitions

To test:
- Read the patch to see what has been changed
- Run the guided report builder for the 'circulation'
  module
- Observe changes show up

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Changes show up, no errors

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit cc4aaf891bdda0d94157c32a99c2a2acace41498)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years ago(RM followup) .mailmap updates
Tomas Cohen Arazi [Fri, 22 May 2015 20:01:57 +0000 (17:01 -0300)]
(RM followup) .mailmap updates

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 5d5802dd70a88fa42dc065bcfc4c0cc58377fff6)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
9 years agoKoha 3.20 is here v3.20.00
Tomas Cohen Arazi [Fri, 22 May 2015 15:55:09 +0000 (12:55 -0300)]
Koha 3.20 is here

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
9 years agoRelease notes for 3.20
Tomas Cohen Arazi [Fri, 22 May 2015 15:44:35 +0000 (12:44 -0300)]
Release notes for 3.20

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
9 years agoTranslation updates for Koha 3.20.0 release
Bernardo Gonzalez Kriegel [Fri, 22 May 2015 13:06:15 +0000 (10:06 -0300)]
Translation updates for Koha 3.20.0 release

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
9 years agoBug 14106: (QA followup) avoid failures if no instances created
Tomas Cohen Arazi [Fri, 22 May 2015 15:28:14 +0000 (12:28 -0300)]
Bug 14106: (QA followup) avoid failures if no instances created

If there are no instances already created on install/upgrade, the
koha-common.postinst script hungs in the absence of files to fix
and keeps waiting for user input.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
9 years agoBug 14106: patch existing zebra configs with new modulePath
Robin Sheat [Fri, 22 May 2015 01:48:13 +0000 (13:48 +1200)]
Bug 14106: patch existing zebra configs with new modulePath

This patches the zebra configuration of existing Koha installations so
that their modulePath will work on newer Debian (and presumably Ubuntu)
releases.

Testing:
* Install a package built with this patch onto a system with instances
  created by an older Koha version.
* Check that the files in /etc/koha/sites/*/zebra-*.cfg have the new
  modulePath: directive rather than the old one.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14106: fill up the zebra config with a list of modulePaths
Robin Sheat [Thu, 21 May 2015 03:48:06 +0000 (15:48 +1200)]
Bug 14106: fill up the zebra config with a list of modulePaths

This adds the full list of paths that debian might use for zebra to the
search path for modules.

It also means we can say we support s390x architecture. Whatever that is.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14145: Noisy warns in admin/preferences.pl
Mark Tompsett [Sat, 9 May 2015 05:31:37 +0000 (01:31 -0400)]
Bug 14145: Noisy warns in admin/preferences.pl

The problem with the odd number of hashes happens when not everything is selected.
The grep returns undef, because it isn't found in @values.
By turning the grep into a ternary-operator truth value, we can set a value (1 or 0) expressly.

The next problem is when nothing is selected in these multiple lists, $value is
undefined, so you can't split it. By splitting the definition of @values from
the actual splitting, we can split only if $value is defined, thus eliminating the
warning message.

TEST PLAN
---------
1) back up your koha error log file
2) blank your koha error log file
3) log in to the staff client
4) Home -> Koha administration -> Global system preferences
5) Click on every tab, EXCEPT local use.
6) notice the koha error log file has warnings.
7) blank the koha error log file again
8) apply this patch
9) Click on every tab, EXCEPT local use, again.
10) notice the koha error log file has no warnings.
11) koha qa test tools.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
I like more this version
Works as described
No koha-qa errors

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
To reproduce: go on the OPAC tab, OpacAdvSearchMoreOptions  or
OpacAdvSearchOptions should not have all options selected.
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14124: Add 'Unimarc only' note to IdRef system preference
Tomas Cohen Arazi [Wed, 6 May 2015 17:04:29 +0000 (14:04 -0300)]
Bug 14124: Add 'Unimarc only' note to IdRef system preference

This patch adds a note to the IdRef service syspref making it
clear that the feature is only available for UNIMARC setups.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Added a missing 'is'
No errors

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14254 - Unclosed <option> element in unimarc_field_116.tt
Bernardo Gonzalez Kriegel [Thu, 21 May 2015 23:25:41 +0000 (20:25 -0300)]
Bug 14254 - Unclosed <option> element in unimarc_field_116.tt

Unclosed <option>

To test:
1) Unimarc install
2) Edit a record
3) Edit 116 field, 10 position, Technique (prints) 3
4) Select litography, save
5) Run plugin again, will see litography/option>
6) Apply the patch
7) Check again, now is right (clean cache)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14118: Silence warnings t/DataTables/Members.t
Mark Tompsett [Sat, 2 May 2015 02:14:21 +0000 (22:14 -0400)]
Bug 14118: Silence warnings t/DataTables/Members.t

After cleaning 'prove t' up. 'prove -r t' was attempted next.
A couple uninitialized variable warning were triggered.

TEST PLAN
----------
1) prove t/DataTables/Members.t
   -- warnings.
2) apply patch
3) prove t/DataTables/Members.t
   -- no warnings.
4) koha qa test tools.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Cleaned. No errors

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14114: Silence warns and cleanup t/Debug.t
Mark Tompsett [Fri, 1 May 2015 21:09:58 +0000 (17:09 -0400)]
Bug 14114: Silence warns and cleanup t/Debug.t

TEST PLAN
---------
1) $ prove t/Debug.t
   -- What's with this BEFORE and AFTER stuff?!
2) apply patch
3) $ prove t/Debug.t
   -- cleaner, and you only get fuller output with -v.
4) koha qa test tools

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Cleaner, no koha-qa errors

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13486: Apache version empty in about page if Apache 2.4
Tomas Cohen Arazi [Thu, 5 Feb 2015 17:31:55 +0000 (14:31 -0300)]
Bug 13486: Apache version empty in about page if Apache 2.4

This patch makes about.pl query the running Apache version using
the apache2ctl command. I tested it on Apache 2.2 and is backwards
compatible (it is present in both).

To test:
( On an Apache 2.4 setup )
- Go to the about page
=> FAIL: "Apache version:" is empty
- Apply the patch
- Reload the page
=> SUCCESS: "Apache version:" shows the correct version.
- Sign off :-D

If you have an Apache 2.2 setup to try it, verify that there are no regressions
(trivial because you can run apache2ctl manually and verify the first result is the expecte).

Regards

PS. I even changed the order in which Apache version is tested because
most people is using Debian/Ubuntu and it was the last option.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested with apache 2.2/2.4, no errors

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Only tested with 2.4
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13650: Remove parens from links to fix searches
Winona Salesky [Thu, 29 Jan 2015 20:13:37 +0000 (14:13 -0600)]
Bug 13650: Remove parens from links to fix searches

This patch will resolve the issue of not being able to
search with parens in a subject heading by editing the xslt

To test:

* Apply patch
* Search Koha for a title with ( ) in the subject
* Click the subject
* Results should be returned
* Repeat in OPAC and Staff client

Signed-off-by: Nick <Nick@quechelibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14072: Followup: extra space
Mirko Tietgen [Wed, 20 May 2015 11:05:10 +0000 (13:05 +0200)]
Bug 14072: Followup: extra space

Detele extra space in sample notice

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14072: Update German web installer for 3.20
Katrin Fischer [Thu, 14 May 2015 15:28:29 +0000 (17:28 +0200)]
Bug 14072: Update German web installer for 3.20

- translates new notice ACQ_NOTIF_ON_RECEIV
- translates new permissions

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested German install till "Gratulation, die Installation ist abgeschlossen"
No errors

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Same results noted as above.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Tested installation, checked new translations in Koha and deleted an extra
space in the ACQ_NOTIF_ON_RECEIV notice

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11925: Check ages limits when creating/updating patrons
Jonathan Druart [Tue, 28 Apr 2015 09:45:46 +0000 (11:45 +0200)]
Bug 11925: Check ages limits when creating/updating patrons

The check on the ages limits is only done when the dateofbirth field is
mandatory, which does not make any sense.
This check should be done when the field is filled.

Test plan:
1/ Remove the dateofbirth field from the BorrowerMandatoryField pref
2/ Create a patron category for teenager (say between 12-17y)
3/ Try to create a patron in this category outside the range of the ages
limits.
You should not be able to do it.

Signed-off-by: Christopher Brannon <cbrannon@cdalibary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14195: (followup) increment number of tests
Bernardo Gonzalez Kriegel [Thu, 14 May 2015 18:36:56 +0000 (15:36 -0300)]
Bug 14195: (followup) increment number of tests

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14195: TestBuilder - A random string should not be longer than the DB field
Jonathan Druart [Wed, 13 May 2015 14:39:59 +0000 (16:39 +0200)]
Bug 14195: TestBuilder - A random string should not be longer than the DB field

t::lib::TestBuilder::_gen_text does not use correctly the regex and the
max parameter to generate the random string (String::Random).

This can cause future tests to fail.

http://bugs.koha-community.org/show_bug.cgi?id=14195
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Script tested, problem occurs, patch fixes it.
Bad number on commit subject
No errors

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14231: changes required for 3.20 release
Robin Sheat [Wed, 10 Dec 2014 04:33:14 +0000 (17:33 +1300)]
Bug 14231: changes required for 3.20 release

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 5338: (QA followup) update the tests for the new reports
Tomas Cohen Arazi [Tue, 19 May 2015 16:47:31 +0000 (13:47 -0300)]
Bug 5338: (QA followup) update the tests for the new reports

This patch fixes the unit tests related to guided reports.
It is needed now that there are more options available.

It also fixes a wrong 'savedsql' key (should be 'sql') that
caused the tests to print warnings.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13687: Move hold policy check into CanItemBeReserved
Julian Maurice [Tue, 10 Feb 2015 10:34:01 +0000 (11:34 +0100)]
Bug 13687: Move hold policy check into CanItemBeReserved

This way ILS-DI HoldItem and HoldTitle services also benefit from this
check

Test plan:

1/ Define some default holds policies by item type in
/admin/smart-rules.pl
2/ Use ILS-DI HoldItem service and check that those rules are respected
3/ Check that staff and opac hold behaviour is unchanged regarding
these rules.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script. No regressions found,
improves the ILS-DI HoldItem response.
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 10299: authority plugin - authority field are reversed
Jonathan Druart [Thu, 16 Apr 2015 13:52:33 +0000 (15:52 +0200)]
Bug 10299: authority plugin - authority field are reversed

If you click the plugin next to an authority field that is already
populated it takes the values from the field and puts them in the search
in the reverse order.

Test plan:
1/ Edit a biblio
2/ Fill the subfield for an authority field (for instance 650$v, 650$x,
650$y, etc.)
3/ Click on the authority plugin
Before this patch, the values were concatenated in the reverse order.
With this patch, it should not.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as described, no koha-qa errors

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 5338: DBRev 3.19.00.043
Tomas Cohen Arazi [Tue, 19 May 2015 13:29:55 +0000 (10:29 -0300)]
Bug 5338: DBRev 3.19.00.043

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 5338: Add the "SER" report group for all languages.
Jonathan Druart [Wed, 4 Mar 2015 11:26:59 +0000 (12:26 +0100)]
Bug 5338: Add the "SER" report group for all languages.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
9 years agoBug 5338: Use insert ignore to avoid a warning if 'SER' already exists
Jonathan Druart [Wed, 4 Mar 2015 11:26:34 +0000 (12:26 +0100)]
Bug 5338: Use insert ignore to avoid a warning if 'SER' already exists

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
9 years agoBug 5338: Add "Serials" to the report group list
Jonathan Druart [Wed, 14 Jan 2015 09:55:19 +0000 (10:55 +0100)]
Bug 5338: Add "Serials" to the report group list

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 5338: Serials Report
Jonathan Druart [Thu, 5 Apr 2012 13:44:32 +0000 (15:44 +0200)]
Bug 5338: Serials Report

Signed-off-by: Paola Rossi <paola.rossi@cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 7380: Add tests for TT plugins
Jonathan Druart [Fri, 17 Apr 2015 15:40:07 +0000 (17:40 +0200)]
Bug 7380: Add tests for TT plugins

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 7380: Rename filter to avoid confusion
Jonathan Druart [Tue, 14 Apr 2015 10:05:45 +0000 (12:05 +0200)]
Bug 7380: Rename filter to avoid confusion

The branchcode and categorycode parameter names are too common and are
confusing.
To remove the ambiguity, this patch renames them with branchcode_filter
and categorycode_filter.

Test plan:
1/ Go on the patron home page (members-home.pl)
2/ Fill the library and category dropdown list in the header search
3/ The patron result list appears and the filters (on the right) are
correctly set with what you have selected.
Make sure the ones in the header are also correctly selected.
4/ Click on a patron
5/ On the patron detail page (moremember.pl), the dropdown lists in the
header are not preselected.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 7380: Refactor the patron search box header
Jonathan Druart [Tue, 15 Jul 2014 10:44:23 +0000 (12:44 +0200)]
Bug 7380: Refactor the patron search box header

A lot of page uses the patron search box header include (git grep
patron-search.inc for the list) and the branch and category lists are
not generated for all of them.

For instance, on a patron detail page, there is a [+] link, but nothing
append on clicking on it.

This patch add a new template plugin "Categories" to get all patron
categories from the templates.

Test plan:
1/ Verify the [+] is working on all patron page (if that works for 2,
that should work for all).
2/ Launch a search from the header box and verify the library and
category dropdown lists select the correct value.
3/ Launch a search on the patron search page (patron home) and verify
the search is working correctly on selecting a category and/or a library

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14200: GetNormalizedISBN failing to normalize valid ISBNs in some cases
Kyle M Hall [Thu, 14 May 2015 10:20:00 +0000 (06:20 -0400)]
Bug 14200: GetNormalizedISBN failing to normalize valid ISBNs in some cases

For some reason the regular expression used to split the multiple ISBN
fields can fail which keeps Business::ISBN from being able to parse out
and return a valid isbn. Using split() instead of the regex fixes the
issue.

Test Plan:
1) Apply the unit test patch first
2) prove t/Koha.t
3) Note the failures
4) Apply the second patch
5) prove t/Koha.t
6) Note all tests pass

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Karen Bryant <kbryant@ccpl-fl.net>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14200: Regression tests
Kyle M Hall [Thu, 14 May 2015 10:19:39 +0000 (06:19 -0400)]
Bug 14200: Regression tests

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Karen Bryant <kbryant@ccpl-fl.net>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11607: Don't display all items in a single line
Jonathan Druart [Wed, 24 Dec 2014 12:09:27 +0000 (13:09 +0100)]
Bug 11607: Don't display all items in a single line

If the *DGST notices are sent in HTML, the items are displayed in a
single line.

To reproduce:
1/ Define a *DGST notice using the <<items.content>> pattern.
2/ Checkout at least 2 items to a patron and set the due date as today.
3/ Launch the advance_notices.pl and process_message_queue.pl cronjobs.
4/ Verify the email you will receive separates the items with a line
break.

Verify you don't find a regression for non-html letters.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Note: the display in the notices tab is misleading here,
needs to be verified checking the sent emails or database
entries in message_queue.
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 10947: Fix editing the default authority type
Jonathan Druart [Wed, 22 Apr 2015 11:45:44 +0000 (13:45 +0200)]
Bug 10947: Fix editing the default authority type

The default authority type cannot be defined.
The authtypecode is en empty string and the tests should be done on
"defined", not "exist".

Test plan:
Edit the default authority type, save it.

Note: There is no way to create an authority with an empty string, with
you deleted you won't be able to recreate it.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 9892: [QA Follow-up] Typo and updated usage
Marcel de Rooy [Fri, 8 May 2015 07:25:37 +0000 (09:25 +0200)]
Bug 9892: [QA Follow-up] Typo and updated usage

Corrected specifield.
Updated usage statement on use of delimiter pref.
Clarified the CONDITION explanation somewhat..

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 9892: Make export_borrowers.pl using the delimiter pref
Jonathan Druart [Thu, 9 Apr 2015 13:49:14 +0000 (15:49 +0200)]
Bug 9892: Make export_borrowers.pl using the delimiter pref

The original concern of bug 9892 was that this borrowers export script
cannot handle tabulation to separate columns.

With this patch, the delimiter preference is used as separator for the
output, to be consistent with others scripts.

This should be highlighted on the release, it can produce change in
behaviors.

Test plan:
Confirm that the 'delimiter' pref is used for the output, but you are able
to overwrite it with the 'separator' parameter

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works as expected, respect preference but is supeseeded by cmd line
No koha-qa errors

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 10011: Save branch limitations on creating a new patron category
Jonathan Druart [Fri, 10 Apr 2015 11:51:31 +0000 (13:51 +0200)]
Bug 10011: Save branch limitations on creating a new patron category

The code was just badly placed.
It should be executed on update but also on insert.

Test plan:
1/ Create a new patron category and select 1+ branch limitations
2/ Confirm it's correctly saved
3/ Edit it and change the branch limitations
4/ Confirm it's correctly saved

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
NOTE: Not a C4 or Koha library, so tests not required. Though,
      this code could be cleaned up and have the DB stuff put
      into some sort of library with tests to prevent regression.
      However, that dream is beyond the scope of this bug.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14213: Cataloging plugin in cloned field does not work
Marcel de Rooy [Mon, 18 May 2015 08:31:26 +0000 (10:31 +0200)]
Bug 14213: Cataloging plugin in cloned field does not work

A code change for report 10480 in cataloging.js does not work well in case
you clone a field with a plugin on a subfield.
The events (click, focus, etc.) do not work on the subfield of the clone.

This patch corrects the situation by finding the right html element for
adding event binding.
NOTE: The test plan uses EXAMPLE.pl since many old plugins do not operate
on the correct field value when cloning. This is corrected in bug 13437.

Test plan:
[1] Attach EXAMPLE.pl to field 007, 246h and 260c.
    In sql for 007: update marc_subfield_structure set
        value_builder='EXAMPLE.pl' where tagfield='007' and tagsubfield='@';
[2] Clone field 007. Verify that focus and click operate on both fields.
    Check also that the plugin works on the value corresponding with
    the button you clicked.
[3] Clone field 246. Do the same checks on both subfields $h.
[4] Clone subfield 260c. Do the same checks again.

Test Remarks:
============

1/ Setup a new framework (B213) based off 'Default' and fired off
   an SQL statement to update value_builder values for 007, 246$h
   and 269$c (UPDATE `marc_subfield_structure` SET value_builder
   = 'EXAMPLE.pl' WHERE frameworkcode = 'B213' AND ( (tagfield =
   '007' AND tagsubfield = '@') OR ( tagfield LIKE '246' AND
   tagsubfield = 'h') OR (tagfield = '260' AND tagsubfield = 'c'))

2/ Tested step 2, 3 and 4 of the given test plan above. The missing
   plugin support in the cloned fields were noted.

3/ Applied patch

4/ Re-tested steps 2, 3 and 4 as before. The defined plugins were
   correctly cloned and found to be functional.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 7143: [QA Follow-up] Restoring lost </li> tag
Marcel de Rooy [Tue, 19 May 2015 12:12:10 +0000 (14:12 +0200)]
Bug 7143: [QA Follow-up] Restoring lost </li> tag

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 7143: Small fix on the 3.20 release team
Tomas Cohen Arazi [Tue, 12 May 2015 15:08:49 +0000 (12:08 -0300)]
Bug 7143: Small fix on the 3.20 release team

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Magnus is alone, no errors

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 12109: Fix tab on the auth subfield configuration page
Jonathan Druart [Mon, 27 Apr 2015 15:16:32 +0000 (17:16 +0200)]
Bug 12109: Fix tab on the auth subfield configuration page

There is a condition in the template to not display the "New" tab if the
user is editing a control field.
But it results in a broken template.
Looking at the biblio frameworks, the New tab exists even for control
fields.

This patch only fixes the html structure, but a complete fix should be
provide, for auth and biblio, if we want not to let the ability to
create subfields for control fields.

Test plan:
Edit subfields for a control field
(admin/marc_subfields_structure.pl?op=add_form&tagfield=001&frameworkcode= for instance)
and confirm that the view is now fixed.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
NOTE: Checked LDR, 001, and 008.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14152: Re-check required dependencies during upgrade process
Chris Nighswonger [Tue, 5 May 2015 19:00:30 +0000 (15:00 -0400)]
Bug 14152: Re-check required dependencies during upgrade process

This code causes the installer to re-check dependencies during the
upgrade process.

Test Plan
---------
1) Log in to staff client
2) Koha Administration -> Global system preferences -> Local
3) Change Version to previous version -- DO NOT HIT SAVE YET!
4) In command line: sudo apt-get purge libpdf-fromhtml-perl
   NOTE: This could be ANY required library. I chose
         PDF::FromHTML, because it has been a thorn in my side.
5) NOW! Hit the 'Save' button.
6) Log in, etc. etc...
   -- Blows up on redirect to log in.
7) In command line, add it back (I had to compile my own so,
   I used sudo dpkg -i /path/to/libpdf-fromhtml-perl...)
8) Apply patch
9) Edit the C4/Installer/PerlDependencies.pm to make
   PDF::FromHTML required. See also bug 14103.
10) Log in to staff client
11) Koha Administration -> Global system preferences -> Local
12) Change Version to previous version -- DO NOT HIT SAVE YET!
13) In command line: sudo apt-get purge libpdf-fromhtml-perl
14) NOW! Hit the 'Save' button.
15) Log in, etc. etc...
16) Once warned you are missing it, add it back at the command line.
17) Click 'Recheck'
    -- Proceeds as expected now.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8399: Display tab number on the mandatory field alert (authority)
Jonathan Druart [Tue, 31 Mar 2015 13:29:49 +0000 (15:29 +0200)]
Bug 8399: Display tab number on the mandatory field alert (authority)

A wrong variable scope was used here, the number value is contained in
the BIG_LOOP (note for later: change this variable name...).

Test plan:
1/ Define 1+ mandatory fields for an authority type
2/ Create an authority and don't fill the mandatory fields
3/ Try to save: the popup alert should display the number of the tab.

Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8399: No need to truncate the marc field text to 22 chars
Jonathan Druart [Tue, 14 Apr 2015 09:23:21 +0000 (11:23 +0200)]
Bug 8399: No need to truncate the marc field text to 22 chars

The text for the marc field are truncated to 22 chars when displaying an
error on mandatory fields.
This limitation is useless and this patch removes it.

Test plan:
Create a mandatory subfield and set a long text (more than 22 chars)
edit or add an authority, click on save.
You should get the error displayed with the full text

Note that this patch modifies the same code for biblio.
Test plan is the same for biblio.

Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8480: (RM followup) DBIx updates
Tomas Cohen Arazi [Mon, 18 May 2015 14:24:12 +0000 (11:24 -0300)]
Bug 8480: (RM followup) DBIx updates

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8480: DBRev 3.19.00.042
Tomas Cohen Arazi [Mon, 18 May 2015 14:20:02 +0000 (11:20 -0300)]
Bug 8480: DBRev 3.19.00.042

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 8480: Add constraint on auth_subfield_structure.authtypecode
Jonathan Druart [Tue, 31 Mar 2015 11:18:21 +0000 (13:18 +0200)]
Bug 8480: Add constraint on auth_subfield_structure.authtypecode

In order not to have useless entries in the auth_subfield_structure
table, this patch modifies the DB structure to add a foreign key on the
authtypecode column.
Note that the auth_tag_structure already has this constraint.

Test plan:
0/ Don't apply this patch
1/ Create a now authority type 'RM_ME'
2/ Look at the MARC structure, to create the subfield structure and
populate the auth_subfield_structure table.
3/ Delete the authority type
4/ Using your SQL cli:
 SELECT COUNT(*) FROM auth_subfield_structure WHERE authtypecode='RM_ME';
=> The data are still in this table.
5/ Apply this patch
6/ Execute the updatedb entry
7/ Confirm the entries in the auth_subfield_structure table related to
RM_ME have been deleted
8/ Repeat 1, 2 and 3 and verify the auth_subfield_structure entries have
been correctly removed.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
- Works exactly as described in the (very good) test plan.
- After authority type deletion, auth_subfield_structure still contains
  entries for deleted authority type. Applying the patch clean the
  previously undeleted records in auth_subfield_strucute. Now deleting a
  authority type cleans propertly all appropriate records in
  auth_subfield_structure.
- Fix a merge conflict

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14172: Acq: Orders without items missing from 'spent' list
Katrin Fischer [Fri, 15 May 2015 10:19:16 +0000 (12:19 +0200)]
Bug 14172: Acq: Orders without items missing from 'spent' list

If the item for an order had been deleted since or there was never
an item created for the order (subscription orders) those records
where missing from the "Spent" page in acquisitions.

Patch corrects the SQL to list the correct records.

To test:
- Create different orders for one fund and receive them
  - normal order with a few items
  - subscription order (no item)
  - normal order with an item, delete the item after receiving
  - include some freight cost in one of the invoices
- Compare the amount spent shown on the acq start page
  with the amount shown at the end of the 'spent' page
- Without the patch, the amounts don't match and not all
  received titles are listed
- With the patch, amounts should match and list shoudl be complete

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13591: Pass OPACBaseURL to rss creation process
Colin Campbell [Tue, 10 Mar 2015 12:15:28 +0000 (12:15 +0000)]
Bug 13591: Pass OPACBaseURL to rss creation process

Links in rss templates were hardcoded to library.org.nz. Should pass and
use the system's OPACBaseURL.

Tested and verified.

Signed-off-by: Eivin Giske Skaaren <eskaaren@yahoo.no>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13986: Implement fix for OPAC
Kyle M Hall [Tue, 21 Apr 2015 18:44:57 +0000 (14:44 -0400)]
Bug 13986: Implement fix for OPAC

Tested wit OPAC, full list is printed.
Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13986: Printing a list only prints the results of the page you are viewing
Kyle M Hall [Mon, 13 Apr 2015 15:23:20 +0000 (11:23 -0400)]
Bug 13986: Printing a list only prints the results of the page you are viewing

The print list button only prints the page you are viewing, and not the
entire list.

Test Plan:
1) Apply this patch
2) Create a list with enough items that it will paginate
3) Browse to that list, click the 'print list' button
4) Note the entire list prints, not just the visible items

Tested in staff client, works as expected.
It would be great to have the same for OPAC as well (OPAC still prints first page only).
Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13673: (QA followup) Add license
Tomas Cohen Arazi [Fri, 15 May 2015 18:56:55 +0000 (15:56 -0300)]
Bug 13673: (QA followup) Add license

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t
Mark Tompsett [Fri, 8 May 2015 21:16:53 +0000 (17:16 -0400)]
Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t

This last patch catches all the warning messages in tests.

TEST PLAN
---------
1) Apply first two patches
2) $ prove t/db_dependent/Barcodes.t
   -- still noisy warnings.
3) apply last patch
4) $ prove t/db_dependent/Barcodes.t
   -- All noisy warnings are caught.
5) koha qa test tools.

Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13673: Remove diags
Mark Tompsett [Fri, 8 May 2015 20:42:55 +0000 (16:42 -0400)]
Bug 13673: Remove diags

TEST PLAN
---------
1) Apply first two patches
2) $ prove t/db_dependent/Barcodes.t
   -- Diags have been removed, just noisy warnings left.
3) $ git diff -w origin/master
   -- only excess print's and diag's removed.
4) koha qa test tools

Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13673: Fix whitespace issues
Mark Tompsett [Fri, 8 May 2015 20:25:32 +0000 (16:25 -0400)]
Bug 13673: Fix whitespace issues

Indentation was horrible. Fixed to meet 4 space standard.

TEST PLAN
---------
1) Notice tabs in t/db_dependent/Barcodes.t
2) $ prove t/db_dependent/Barcodes.t
3) apply patch
4) $ prove t/db_dependent/Barcodes.t
   -- same output as before.
5) $ git diff -w origin/master
   -- code is identical except for indentations.
6) koha qa test tools

Signed-off-by: Indranil Das Gupta <indradg@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 10913: The delete basket confirmation page is never displayed
Jonathan Druart [Wed, 22 Apr 2015 09:46:29 +0000 (11:46 +0200)]
Bug 10913: The delete basket confirmation page is never displayed

This condition is never reached, the confirmation to delete a basket is
done with a popup in the template.

Test plan:
Confirm you don't find any regression when creation/editing and deleting
a basket.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
NOTE: I didn't create or edit. However, the only perl script that uses
      the template is acqui/basket.pl and the only place delete_confirm
      is set in acqui/basket.pl is in that code which is only called if
      del_basket actually existed anywhere else, which it doesn't.
      I did have two baskets, one with two transfers from the first, so
      I transferred one back, and then proceeded to test the two delete
      buttons in the modal. No issues. Cancel (to close the modal) works
      too.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11385: Remove SQL::Helper
Jonathan Druart [Mon, 13 Apr 2015 14:27:39 +0000 (16:27 +0200)]
Bug 11385: Remove SQL::Helper

At this point, no occurrence of SQL::Helper should exist.
Let's remove the package and tests.

Test plan:
  git grep SQLHelper
and
  git grep InTable

Should not return anything in the Koha code.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 12633: Fix specific default values
Jonathan Druart [Tue, 21 Apr 2015 14:50:12 +0000 (16:50 +0200)]
Bug 12633: Fix specific default values

The dates should be set to undef if defined but empty, otherwise with an
empty string, '0000-00-00' will be inserted into the DB.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 12633: Remove SQLHelper in C4::Members
Jonathan Druart [Mon, 13 Apr 2015 14:21:50 +0000 (16:21 +0200)]
Bug 12633: Remove SQLHelper in C4::Members

This is the only places where SQLHelper is still called.
The C4::Members::Search is not used anymore, but ModMember and
AddMember.

This patch replaced the calls to SQLHelper to use DBIX::Class.
TODO: Move them to Koha::Borrower.

Test plan:
1/ Make sure the patron search still works (no changes expected since the
code was not in used).
2/ Add a patron with all fields filled
3/ Add another patron with some fields filled
4/ Update them with other values
5/ Delete them

You should not get any errors.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14038: Make nl-search.pl not using C4::Members::Search
Jonathan Druart [Wed, 22 Apr 2015 08:19:33 +0000 (10:19 +0200)]
Bug 14038: Make nl-search.pl not using C4::Members::Search

To get rid of SQLHelper, we should not use this C4::Members::Search anymore.

Test plan for Magnus :)
0/ Enable the pref you need to use the Norwegian national library card ft
1/ Go on the members/nl-search.pl page and search for patrons.
2/ Make sure you search by card number and by "social security number"

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Searching works the same with and without the patch. Thanks Jonathan!

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14204: (QA followup) remove unneeded messages
Tomas Cohen Arazi [Fri, 15 May 2015 18:28:56 +0000 (15:28 -0300)]
Bug 14204: (QA followup) remove unneeded messages

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14204: Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991
Nick Clemens [Thu, 14 May 2015 19:56:43 +0000 (19:56 +0000)]
Bug 14204: Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991

This patch updaes the batch_id variable after items are added to test batch

To test:
1. prove t/db_dependent/Labels/t_Batch.t and see two tests fail
2. apply patch
3. prove again, tests pass!

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
NOTE: The $batch->add_item() call to C4::Creators::Batch::add_item
      triggers the change of the batch_id so this line is necessary!
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 10235: Add DataTables filters on local use prefs
Jonathan Druart [Tue, 14 Apr 2015 14:07:07 +0000 (16:07 +0200)]
Bug 10235: Add DataTables filters on local use prefs

There is no way to search for local use prefs.
This patch provides an easy way to search for pref present in
of local use prefs table.

Test plan:
1/ Go on the system preferences administration page
2/ Click on the Local Use table
3/ Confirm you are able to filter the table by pref name or description
using the DataTables filters on top of it.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
NOTE: Local use tab is distinct from other tabs, so implementing
      'Search system preferences' across all tabs would be very
      difficult. This patch adds a filter to the Local Use tab,
      which nicely allows for filtering, as per Owen's suggestion
      in comment #1.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 9067: Fix space error
Mark Tompsett [Sat, 25 Apr 2015 15:44:06 +0000 (11:44 -0400)]
Bug 9067: Fix space error

There was a [ % END %] which triggered template parsing errors.
Follow the test plan in comment #7 with both patches applied.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 9067: Hide item related strings when importing staged authority records
Jonathan Druart [Wed, 1 Apr 2015 11:28:20 +0000 (13:28 +0200)]
Bug 9067: Hide item related strings when importing staged authority records

On importing authority records, the items related string should not be
displayed.

Test plan:
1/ Import an authority record
2/ Confirm the item related string are not displayed.
3/ Before this script, the record_type param was lost just after
importing the records. Now you should see
"Processing authority records" of "Processing bibliographic records" in
the "MARC staging results"
4/ Revert the import and check there is not item related strings.

No behavior should exist on importing bibliographic records.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14132: DBRev 3.19.00.041
Tomas Cohen Arazi [Thu, 14 May 2015 15:13:47 +0000 (12:13 -0300)]
Bug 14132: DBRev 3.19.00.041

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14132: suggestions table is missing indexes - atomicupdate
Fridolin Somers [Mon, 4 May 2015 11:49:53 +0000 (13:49 +0200)]
Bug 14132: suggestions table is missing indexes - atomicupdate

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Sorry but removed backticks
No errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14132: suggestions table is missing indexes
Fridolin Somers [Mon, 4 May 2015 11:35:07 +0000 (13:35 +0200)]
Bug 14132: suggestions table is missing indexes

Suggestions table is missing some indexes.

Index on biblionumber will speed up C4::Suggestions::GetSuggestionInfoFromBiblionumber(), often called in a loop.
Index on status and branchcode will speed up many queries.
Note that an index on budgetid is automatically added by the creation of the foreign key constraint.

Test plan :
- Check performance with an invoice containing a lot of orders.
- Check suggestions pages are faster or at least not slower.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14194: Restore the HH:MM to 23:59 for onsite-checkouts
Jonathan Druart [Tue, 12 May 2015 11:11:40 +0000 (13:11 +0200)]
Bug 14194: Restore the HH:MM to 23:59 for onsite-checkouts

(Introduced by bug 13601)

Test plan
=========
1/ enable 'OnSiteCheckouts' pref under Circulation Preferences
2/ go to the checkouts page and try to issue an item to any user.
3/ when the item barcode entry form shows, select the 'On-site
   checkout' checkbox
4/ the default date due should show as today with 00:00 as HH:MM
5/ apply the patch
6/ repeat steps 2 - 3. The default date due should show today's
   date with 23:59 as HH:MM.
7/ run koha-qa.pl -c 1 -v 2

Remarks: Testing result match expected test plan output. The QA tests
         pass with "OK" for the commit.

Technical note: There is a confusion with iso and sql date formats at
some places in the code.
A better way should be provided (later) to fix globally the mismatch
between these 2 formats.
What happened before this patch: the DateTime was cast to a string and
the template received "YYYY-MM-DDTHH:MM:SS" which is an iso formatted
date. BUT this format is not managed by Koha::DateUtils::output_pref
("iso" and "sql" are considered as indentical which is wrong).
As I did not estimated the problem (how big it is) I prefer to fix it
easily (and dirty) for now.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13423: Fix number of tests in Serials.t
Jonathan Druart [Wed, 29 Apr 2015 08:56:42 +0000 (10:56 +0200)]
Bug 13423: Fix number of tests in Serials.t

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13423: Remove unused serials-recieve
Bernardo Gonzalez Kriegel [Sat, 25 Apr 2015 12:01:44 +0000 (09:01 -0300)]
Bug 13423: Remove unused serials-recieve

This patch removes two files, serials-recieve.pl and serial-recieve.tt
serials-recieve.pl is not called anyware
(it's recieve!)

Also removes the sub removeMissingIssue called only from serials-recieve.pl

git grep serials-recieve.pl .
C4/Serials.pm:called when a missing issue is found from the serials-recieve.pl file
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt:     <form method="post" name="f" action="serials-recieve.pl" onsubmit="return barcode_check()">
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt:     <form method="post" name="f2" action="serials-recieve.pl">
serials/serials-recieve.pl:serials-recieve.pl

Just a POD entry and self reference.

After removing of files

git grep removeMissingIssue .
C4/Serials.pm:      &check_routing &updateClaim &removeMissingIssue
C4/Serials.pm:=head2 removeMissingIssue
C4/Serials.pm:removeMissingIssue($subscriptionid)
C4/Serials.pm:sub removeMissingIssue {
t/db_dependent/Serials.t:is(C4::Serials::removeMissingIssue(), undef, 'test removing a missing issue');

Not used anymore

To test:
1) Apply the patch
2) Check serials workflow, no changes must be noted

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13423: Remove unused JS function in serials-edit.tt
Bernardo Gonzalez Kriegel [Tue, 24 Mar 2015 17:54:57 +0000 (14:54 -0300)]
Bug 13423: Remove unused JS function in serials-edit.tt

This patch removes unused code:
 * barcode_check() function, with untranslatable strings
 * commented call to this function

To test:
1. Apply the patch
2. Check serials receive, no changes shall be detected

NOTE: I did not run this test plan.

Verification steps
------------------
1. Find out where barcode_check is used.
   $ git grep barcode_check
   -- This is only in serials-edit.tt and serials-receive.tt
2. This patch only affects serials-edit.tt, so
   check who put the <!--onsubmit="return barcode_check()">-->
   $ git blame -L130 koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
   -- note the commit related number.
3. Check out the commit.
   $ git show 77b64098
   -- should show bug 5917, but the patches on bugzilla don't
      have the change nicely, so...
4. Hunt through the pages to find the change.
   -- Note: it is part of a "new file" diff!
5. Since this code hasn't been running since it was added...
6. apply the patch
7. run koha-qa test tools

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 14077: Remove unused AUTH_UPDATE_FAILED from moremember.tt
Marc Véron [Wed, 29 Apr 2015 09:34:40 +0000 (11:34 +0200)]
Bug 14077: Remove unused AUTH_UPDATE_FAILED from moremember.tt

'AUTH_UPDATE_FAILED' in moremember.tt is never set and should be removed (see comment #6 on Bug 13910).

To verify: git grep 'AUTH_UPDATE_FAILED'
Result: Only one occurence (in moremember.tt)

Test plan:
- Apply patch (on top of Bug 13910)
- Verify that the part with AUTH_UPDATE_FAILED is removed from moremember.tt
- Go to a patron's detail page and verify that nothing is broken (Home > Patrons > Patrons details for...)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This has been introduced by
  commit 1a91801b06607ee9e5f8c21d531a7b7a3ca3b683
  Date:   Sat Dec 1 20:56:27 2007 -0600
      Add Staff member type. Add permissions checks for bug# 1269
      and related permissions on memberentry and mods.
But was already not used...

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13910: Line with AUTH_UPDATE_FAILED restored
Marc Véron [Wed, 29 Apr 2015 09:18:08 +0000 (11:18 +0200)]
Bug 13910: Line with AUTH_UPDATE_FAILED restored

As of comment #6

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This should be fixed in a separate patch, this error is not sent to the
template and the related code could be removed.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>