From 2fc0e258ea349cb574091b0b677d1808e87a4ecc Mon Sep 17 00:00:00 2001 From: Fridolyn SOMERS Date: Mon, 15 Jul 2013 12:14:53 +0200 Subject: [PATCH] Bug 10588: improve selection of default branch for OPAC popular items pag In OPAC most popular items page: With user is logged-in his branch should be selected by default. When a branch is manually selected and form is submitted, this branch should be selected in results page. When looking at HTML, you see that all options are selected in combobox. This patch corrects by using the hidden input 'do_it' to distinguish form display and no branch filter selected. Test plan : - Make sure there are issues on records created in the past 3 month - Go to OPAC not logged-in - Click on "Most popular" => You get to page with results, "All libraries" is selected - Select a branch and submit => You get to page with results, the branch is selected [testing opac-topissues.inc from] - Select a branch and perform a search that does not have results (for example an item type never issued) => You get to page without results, the branch is selected [testing opac-topissues.tt form] - Log-in with a user - Click on "Most popular" => You get to page with results, user's branch is selected - Select "All libraries" and submit => You get to page with results, "All libraries" is selected [testing opac-topissues.inc from] - Select "All libraries" and perform a search that does not have results (for example an item type never issued) => You get to page without results, "All libraries" is selected [testing opac-topissues.tt form] Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Works nicely and passes all tests. Signed-off-by: Galen Charlton (cherry picked from commit 600e953dff44c29fe7a2996fbacbd8e57cd7eb35) Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 4afc06d76a39cff5471ae3e364357019334259f4) Signed-off-by: Bernardo Gonzalez Kriegel (cherry picked from commit 4afc06d76a39cff5471ae3e364357019334259f4) --- koha-tmpl/opac-tmpl/prog/en/includes/opac-topissues.inc | 2 +- opac/opac-topissues.pl | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/opac-topissues.inc b/koha-tmpl/opac-tmpl/prog/en/includes/opac-topissues.inc index 20b1d9b473..55501fc18c 100644 --- a/koha-tmpl/opac-tmpl/prog/en/includes/opac-topissues.inc +++ b/koha-tmpl/opac-tmpl/prog/en/includes/opac-topissues.inc @@ -17,7 +17,7 @@