From 9e65f89443219b283d505f33bc84d7347b03f66a Mon Sep 17 00:00:00 2001
From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Date: Wed, 16 Oct 2024 09:56:20 +0000
Subject: [PATCH] Bug 35570: (QA follow-up): Fix DVD type

I've added some DVD specific fields: language, format, genre, studio.
Happy to have this discussed and/or updated but hoping this is good enough for now.
To test:
1) Create an ILL request of 'DVD' type on both OPAC and Staff
2) Verify the form is shown without issues
3) Fill all fields and verify all fields are stored and shown correctly on both OPAC and STaff

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 Koha/ILL/Backend/Standard.pm                  |  4 +++
 .../ILL/Backend/shared-includes/forms/dvd.inc | 33 +++++++++++++++++++
 2 files changed, 37 insertions(+)
 create mode 100644 Koha/ILL/Backend/shared-includes/forms/dvd.inc

diff --git a/Koha/ILL/Backend/Standard.pm b/Koha/ILL/Backend/Standard.pm
index 5222e96528..f64908adff 100644
--- a/Koha/ILL/Backend/Standard.pm
+++ b/Koha/ILL/Backend/Standard.pm
@@ -928,11 +928,14 @@ sub _get_core_fields {
         conference_date => 'Conference date',
         doi             => 'DOI',
         editor          => 'Editor',
+        format          => 'Format',
+        genre           => 'Genre',
         institution     => 'Institution',
         isbn            => 'ISBN',
         issn            => 'ISSN',
         issue           => 'Issue',
         item_date       => 'Date',
+        language        => 'Language',
         pages           => 'Pages',
         pagination      => 'Pagination',
         paper_author    => 'Paper author',
@@ -943,6 +946,7 @@ sub _get_core_fields {
         published_place => 'Place of publication',
         publisher       => 'Publisher',
         sponsor         => 'Sponsor',
+        studio          => 'Studio',
         title           => 'Title',
         type            => 'Type',
         venue           => 'Venue',
diff --git a/Koha/ILL/Backend/shared-includes/forms/dvd.inc b/Koha/ILL/Backend/shared-includes/forms/dvd.inc
new file mode 100644
index 0000000000..e90a581987
--- /dev/null
+++ b/Koha/ILL/Backend/shared-includes/forms/dvd.inc
@@ -0,0 +1,33 @@
+<fieldset id="dvd-standard-fieldset" class="rows">
+    <legend>DVD details</legend>
+    <ol id="publication-standard-fields">
+        <li>
+            <label for="title">Title:</label>
+            <input type="text" name="title" id="title" value="[% whole.value.other.title | html %]" />
+        </li>
+        <li>
+            <label for="author">Author:</label>
+            <input type="text" name="author" id="author" value="[% whole.value.other.author | html %]" />
+        </li>
+        <li>
+            <label for="studio">Studio:</label>
+            <input type="text" name="studio" id="studio" value="[% whole.value.other.studio | html %]" />
+        </li>
+        <li>
+            <label for="genre">Genre:</label>
+            <input type="text" name="genre" id="genre" value="[% whole.value.other.genre | html %]" />
+        </li>
+        <li>
+            <label for="year">Year:</label>
+            <input type="text" name="year" id="year" value="[% whole.value.other.year | html %]" />
+        </li>
+        <li>
+            <label for="format">Format:</label>
+            <input type="text" name="format" id="format" value="[% whole.value.other.format | html %]" />
+        </li>
+        <li>
+            <label for="language">Language:</label>
+            <input type="text" name="language" id="language" value="[% whole.value.other.language | html %]" />
+        </li>
+    </ol>
+</fieldset>
-- 
2.39.5