From c678eccdb6844ed8d8e5a15ff263dfff2827f3fe Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 13 Mar 2018 10:15:31 +0000
Subject: [PATCH] Bug 20383: Hide link to plugin management if plugins are not
 enabled
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

This patch adds a check in admin-home.pl to see whether plugins are
enabled. If plugins are disabled, the link to plugins management is
hidden even if the user has plugin management permission.

To test, view the administration home page with plugins enabled and
disabled via the enable_plugins flag in the Koha configuration file.
Also test using users with different plugins permissions:

- Plugins enabled
  - CAN_user_plugins = 1
    -> Plugins link appears
  - CAN_user_plugins = 0
    -> Plugins link hidden

- Plugins disabled
  - CAN_user_plugins = 1,
  - CAN_user_plugins = 0
    -> Plugins link hidden

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 8450d2020bdfd524ebd20f0de8d278497fce0759)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 admin/admin-home.pl                                         | 6 ++++++
 koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/admin/admin-home.pl b/admin/admin-home.pl
index 08c6ed196a..156df0c55d 100755
--- a/admin/admin-home.pl
+++ b/admin/admin-home.pl
@@ -21,8 +21,12 @@ use warnings;
 use CGI qw ( -utf8 );
 use C4::Auth;
 use C4::Output;
+use Koha::Plugins;
 
 my $query = new CGI;
+
+my $plugins_enabled = C4::Context->preference('UseKohaPlugins') && C4::Context->config("enable_plugins");
+
 my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
     {
         template_name   => "admin/admin-home.tt",
@@ -34,4 +38,6 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
     }
 );
 
+$template->param( plugins_enabled => $plugins_enabled, );
+
 output_html_with_http_headers $query, $cookie, $template->output;
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
index 0d43e6f949..e6108e79c4 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
@@ -56,7 +56,7 @@
                     <dt><a href="/cgi-bin/koha/admin/cities.pl">Cities and towns</a></dt>
                     <dd>Define cities and towns that your patrons live in.</dd>
                 </dl>
-                [% IF CAN_user_plugins %]
+                [% IF CAN_user_plugins && plugins_enabled %]
                     <h3>Plugins</h3>
                     <dl>
                         <dt><a href="/cgi-bin/koha/plugins/plugins-home.pl">Manage plugins</a></dt>
-- 
2.39.5